Click to See Complete Forum and Search --> : can someone help me shorten this up?


gogotina
06-03-2003, 11:47 PM
Can someone help me shorten this up with loops? Im not having any luck...Soory for the stupid question...

<script language="javascript">
function Control() {
var NewCount = 0
var NewCount2 = 0
if (document.item1.A1.checked)
{NewCount = NewCount + 1}
if (document.item1.A2.checked)
{NewCount = NewCount + 1}
if (document.item1.A3.checked)
{NewCount = NewCount + 1}
if (document.item1.A4.checked)
{NewCount = NewCount + 1}
if (document.item1.A5.checked)
{NewCount = NewCount + 1}
if (document.item1.A6.checked)
{NewCount = NewCount + 1}
if (document.item1.A7.checked)
{NewCount = NewCount + 1}
if (document.item1.A8.checked)
{NewCount = NewCount + 1}
if (document.item1.A9.checked)
{NewCount = NewCount + 1}
if (document.item1.A10.checked)
{NewCount = NewCount + 1}
if (NewCount == 6)
{
alert('Pick Just Five Numbers Please')
document.item1; return false;
}
if (document.item1.B1.checked)
{NewCount2 = NewCount2 + 1}
if (document.item1.B2.checked)
{NewCount2 = NewCount2 + 1}
if (document.item1.B3.checked)
{NewCount2 = NewCount2 + 1}
if (document.item1.B4.checked)
{NewCount2 = NewCount2 + 1}
if (document.item1.B5.checked)
{NewCount2 = NewCount2 + 1}
if (document.item1.B6.checked)
{NewCount2 = NewCount2 + 1}
if (document.item1.B7.checked)
{NewCount2 = NewCount2 + 1}
if (document.item1.B8.checked)
{NewCount2 = NewCount2 + 1}
if (document.item1.B9.checked)
{NewCount2 = NewCount2 + 1}
if (document.item1.B10.checked)
{NewCount2 = NewCount2 + 1}
if (NewCount2 == 6)
{
alert('Pick Just Five Numbers Please')
document.item1; return false;
}
}
</script>

Jona
06-04-2003, 12:05 AM
<script type="text/javascript">
function Control() {
var NewCount = 0;
var NewCount2 = 0;
for(len=0;len<10;len++){
eval("if(document.item1.A"+len+".checked){NewCount+=1}");
}
if(NewCount==6){
alert('Pick Just Five Numbers Please')
document.item1; return false;}
for(len=0;len<10;len++){
eval("if(document.item1.B"+len+".checked){NewCount2+=1}");
if(NewCount2 == 6){
alert('Pick Just Five Numbers Please')
document.item1; return false;
} }
/***
Note: Untested Code
***/
</script>


Jona

Khalid Ali
06-04-2003, 12:05 AM
Something on these lines may work

var frm1 = document.item1;
var len = frm.length;
for(var x=0;x<len;x++){
if(NewCount>5){
alert('Pick Just Five Numbers Please')
return false;
}
if(frm[x].type=="checkbox" && frm[x].checked){
NewCount++;
}
}

Use the same coding for the second set as well...