help?

[Jonathan]

What is wrong with this script?


function checkform()
if (document.feedback.Name.value="")
{
alert("Please enter your name");
document.feedback.Name.focus();return false
}

[Jona]

if(document.feedback.Name.value==""){


[J]ona

[Jonathan]

how come?

[David Harrison]

You've missed out some braces that should surround your function:

function checkform(){
if (document.feedback.Name.value="")
{
alert("Please enter your name");
document.feedback.Name.focus();return false
}
}

[Jona]

You must also use two equals signs for comparisons.

[J]ona

[Jonathan]

oh yeah, i see it now

[Jonathan]

How come the following code doesn't return false if they click submit, it says error, but keeps the process going...


<script language="JavaScript" type="text/javascript">
<!--
function checkform(){
if (document.feedback.Name.value=="")
{
alert("Please enter your name");
document.feedback.Name.focus();return false
}

if (document.feedback.Email.value=="")
{
alert("Please enter your e-mail address");
document.feedback.Email.focus();return false
}

if (document.feedback.Email.value!="")
{if (document.feedback.Email.value.indexOf("@")==-1 || document.feedback.Email.value.indexOf(".")==-1 || document.feedback.Email.value.indexOf(" ")!=-1 || document.feedback.Email.value.lenfth<6)
{alert("Sorry, but your e-mail address is invalid.");
document.feedback.Email.focus();return false}
}

if (document.feedback.Name.value!="")
{if (document.feedback.Name.value.indexOf("!")!=-1 || document.feedback.Name.value.indexOf("@")!=-1 || document.feedback.Name.value.indexOf("#")!=-1 || document.feedback.Name.value.indexOf("$")!=-1 || document.feedback.Name.value.indexOf("%")!=-1 || document.feedback.Name.value.indexOf("^")!=-1 || document.feedback.Name.value.indexOf("&")!=-1 || document.feedback.Name.value.indexOf("*")!=-1 || document.feedback.Name.value.indexOf("+")!=-1 || document.feedback.Name.value.indexOf("-")!=-1 || document.feedback.Name.value.length<=2)
{alert("Sorry, the name you entered is invalid.")
document.feedback.Name.focus();return false}
}
}
//-->
</script>

[Jona]

Make sure your form's onsubmit looks like this:


onsubmit="return checkform();"


[J]ona

[Jonathan]

oops i didnt do the return... and.. does that go in the submit button or the form tag

[Jona]

Form tag.

[J]ona

[Jonathan]

Thanks

[Jona]

You're welcome.

[J]ona