Click to See Complete Forum and Search --> : Externalize Dreamweaver Image Rollover Script


ccountey
02-18-2008, 09:29 AM
Hello,

I am having trouble externalizing a Dreamweaver rollover script for the sake of SEO.

Here is the script I need to externalize:

<script language="JavaScript">
<!--



function MM_preloadImages() { //v3.0
var d=document; if(d.images){ if(!d.MM_p) d.MM_p=new Array();
var i,j=d.MM_p.length,a=MM_preloadImages.arguments; for(i=0; i<a.length; i++)
if (a[i].indexOf("#")!=0){ d.MM_p[j]=new Image; d.MM_p[j++].src=a[i];}}
}


function MM_findObj(n, d) { //v4.01
var p,i,x; if(!d) d=document; if((p=n.indexOf("?"))>0&&parent.frames.length) {
d=parent.frames[n.substring(p+1)].document; n=n.substring(0,p);}
if(!(x=d[n])&&d.all) x=d.all[n]; for (i=0;!x&&i<d.forms.length;i++) x=d.forms[i][n];
for(i=0;!x&&d.layers&&i<d.layers.length;i++) x=MM_findObj(n,d.layers[i].document);
if(!x && d.getElementById) x=d.getElementById(n); return x;
}

function MM_swapImgRestore() { //v3.0
var i,x,a=document.MM_sr; for(i=0;a&&i<a.length&&(x=a[i])&&x.oSrc;i++) x.src=x.oSrc;
}

function MM_swapImage() { //v3.0
var i,j=0,x,a=MM_swapImage.arguments; document.MM_sr=new Array; for(i=0;i<(a.length-2);i+=3)
if ((x=MM_findObj(a[i]))!=null){document.MM_sr[j++]=x; if(!x.oSrc) x.oSrc=x.src; x.src=a[i+2];}
}

//-->
</script>


I created external .js files and referenced them as follows:

<script type="text/javascript" src="MM_findObj.js">

</script>

<script type="text/javascript" src="MM_swapImgRestore.js">
<!-- -->
</script>

<script type="text/javascript" src="MM_swapImage.js">
<!-- -->
</script>

<script type="text/javascript" src="MM_preloadImages.js">
<!-- -->
</script>

I think I am calling these functions incorrectly as I am getting an "Object expected" error on the following page: http://www.appletreeanswers.com/newindex2.html


Any help would be greatly appreciated. Thanks!

Centauri
02-18-2008, 04:44 PM
Actually, you would be much better off ditching all the javascript completely, and using the css :hover property to swap backgrounds - much cleaner and more accessible.
http://www.wellstyled.com/css-nopreload-rollovers.html