basic calculations problem [Archive]

Click to See Complete Forum and Search --> : basic calculations problem

tinernet

10-07-2003, 12:03 PM

this has gone from fairly simple to mind boggelingly complicated. i keep getting an error on line 23, char 43, and it thinks there should be a ";" somwhere...........
HELP!

<script type="text/javascript">
function menchng() {
var cash=document.men.cash.value;
var cashend=(cash-((infbuy*1000)-(flambuy*2000)-(combuy*5000)))+((eval(infsell)*800)+(eval(flamsell)*1500)+(eval(comsell)*4000));
if (cashend<0) {
document.writeln('Not enough money. <a href="men.htm">Back</a>');
}
if((infbuy != "")&&(infsell != "")) {
var infbuy=document.men.infbuy.value;
var infsell=document.men.infsell.value;
var infcur=document.men.infcur.value;
var inftot=(infcur+eval(infbuy))-infsell
document.writeln('Infantry ');
document.writeln('Infantry Bought: '+infbuy+' ');
document.writeln('Infantry Sold: '+infsell+' ');
document.writeln('Infantry Total: '+inftot+' ');

elseif((flambuy != "")&&(flamsell != "")) {
var flambuy=document.men.flambuy.value;
var flamsell=document.men.flamsell.value;
var flamcur=document.men.flamcur.value;
var flamtot=(flamcur+eval(flambuy))-flamsell
document.writeln('FlameTroopers ');
document.writeln('FlameTroopers Bought: '+infbuy+' ');
document.writeln('FlameTroopers Sold: '+infsell+' ');
document.writeln('FlameTroopers Total: '+inftot+' ');

elseif((combuy != "")&&(comsell != "")) {
var combuy=document.men.combuy.value;
var comsell=document.men.comsell.value;
var comcur=document.men.comcur.value;
var comtot=(comcur+eval(combuy))-comsell
document.writeln('Commandos ');
document.writeln('Commandos Bought: '+infbuy+' ');
document.writeln('Commandos Sold: '+infsell+' ');
document.writeln('Commandos Total: '+inftot+' ');
}
}
document.writeln('Cash Remaning: $'+cashend);
}
</script>

AdamBrill

10-07-2003, 12:11 PM

All of the elseif's should be else if... If that doesn't fix the problem, could you post a link to where you have the page?

tinernet

10-07-2003, 03:15 PM

um nowhere at the mo as tripod seems to be broked. heres the whoe code:

<html>
<head>
<title>:::< Epic Infantry Section >:::</title>
<script type="text/javascript">
function menchng() {
var cash=document.men.cash.value;
var cashend=(cash-((infbuy*1000)-(flambuy*2000)-(combuy*5000)))+((eval(infsell)*800)+(eval(flamsell)*1500)+(eval(comsell)*4000));
if (cashend<0) {
document.writeln('Not enough money. <a href="men.htm">Back</a>');
}
if((infbuy != "")&&(infsell != "")) {
var infbuy=document.men.infbuy.value;
var infsell=document.men.infsell.value;
var infcur=document.men.infcur.value;
var inftot=(infcur+eval(infbuy))-infsell
document.writeln('Infantry ');
document.writeln('Infantry Bought: '+infbuy+' ');
document.writeln('Infantry Sold: '+infsell+' ');
document.writeln('Infantry Total: '+inftot+' ');

else if((flambuy != "")&&(flamsell != "")) {
var flambuy=document.men.flambuy.value;
var flamsell=document.men.flamsell.value;
var flamcur=document.men.flamcur.value;
var flamtot=(flamcur+eval(flambuy))-flamsell
document.writeln('FlameTroopers ');
document.writeln('FlameTroopers Bought: '+infbuy+' ');
document.writeln('FlameTroopers Sold: '+infsell+' ');
document.writeln('FlameTroopers Total: '+inftot+' ');

else if((combuy != "")&&(comsell != "")) {
var combuy=document.men.combuy.value;
var comsell=document.men.comsell.value;
var comcur=document.men.comcur.value;
var comtot=(comcur+eval(combuy))-comsell
document.writeln('Commandos ');
document.writeln('Commandos Bought: '+infbuy+' ');
document.writeln('Commandos Sold: '+infsell+' ');
document.writeln('Commandos Total: '+inftot+' ');
}
}
document.writeln('Cash Remaning: $'+cashend);
}
</script>
</head>
<body>
<form onsubmit="menchng()" name="men">
Infantry 
Infantry buy: <input type="text" name="infbuy" size="20"> 
Infantry sell: <input type="text" name="infsell" size="20"> 
Current infantry: <input type="text" name="infcur" size="20"> 
FlameTroopers 
FlameTroopers buy: <input type="text" name="flambuy" size="20"> 
FlameTroopers sell: <input type="text" name="flamsell" size="20"> 
Current FlameTroopers: <input type="text" name="flamcur" size="20"> 
Commandos 
Commandos buy: <input type="text" name="combuy" size="20"> 
Commandos sell: <input type="text" name="comsell" size="20"> 
Current Commandos: <input type="text" name="comcur" size="20"> 
Cash: $<input type="text" name="cash" size="20"> 
<input type="submit" value="Submit">
</form>
</body>
</html>

yeah i kno my html is poor il change it all l8r........

AdamBrill

10-07-2003, 07:56 PM

Ok, try this instead:<script type="text/javascript">
function menchng() {
var cash=document.men.cash.value;
var cashend=(cash-((infbuy*1000)-(flambuy*2000)- (combuy*5000)))+((eval(infsell)*800)+(eval(flamsell)*1500)+(eval(comsell)*4000));
if (cashend<0) {
document.writeln('Not enough money. <a href="men.htm">Back</a>');
}
if((infbuy != "")&&(infsell != "")) {
var infbuy=document.men.infbuy.value;
var infsell=document.men.infsell.value;
var infcur=document.men.infcur.value;
var inftot=(infcur+eval(infbuy))-infsell
document.writeln('Infantry ');
document.writeln('Infantry Bought: '+infbuy+' ');
document.writeln('Infantry Sold: '+infsell+' ');
document.writeln('Infantry Total: '+inftot+' ');
}else if((flambuy != "")&&(flamsell != "")) {
var flambuy=document.men.flambuy.value;
var flamsell=document.men.flamsell.value;
var flamcur=document.men.flamcur.value;
var flamtot=(flamcur+eval(flambuy))-flamsell
document.writeln('FlameTroopers ');
document.writeln('FlameTroopers Bought: '+infbuy+' ');
document.writeln('FlameTroopers Sold: '+infsell+' ');
document.writeln('FlameTroopers Total: '+inftot+' ');
}else if((combuy != "")&&(comsell != "")) {
var combuy=document.men.combuy.value;
var comsell=document.men.comsell.value;
var comcur=document.men.comcur.value;
var comtot=(comcur+eval(combuy))-comsell
document.writeln('Commandos ');
document.writeln('Commandos Bought: '+infbuy+' ');
document.writeln('Commandos Sold: '+infsell+' ');
document.writeln('Commandos Total: '+inftot+' ');
}
document.writeln('Cash Remaning: $'+cashend);
}
</script>You just had a couple of your }'s in the wrong spot. ;)