Click to See Complete Forum and Search --> : Need opinions
cserednyj
08-13-2008, 08:37 PM
This is my first client. My first official site. What do you think??? Outside of the issues I am having with my flash banner (if you are looking through IE) not appearing. I put a post up about that but it hasn't shown up yet. But other than that...opinions?
scragar
08-13-2008, 08:40 PM
erm... a link or problem would be nice :P
cserednyj
08-13-2008, 09:21 PM
hahaha...I'm sorry! you're right that would probably help!!
It's www.djsmostwanted.com (http://www.djsmostwanted.com)
scragar
08-13-2008, 10:50 PM
well I've got a few little problems with it, firstly your links at the top are a little hard to read, especially the longer words like services and testimonials.
Can I also insist that you add alt and title text for images? I tool the liberty of testing the page in both lynx and links(2 command line browsers which give a good idea of how screen readers will present the content, and other than the fact that I got stupid name for the links(so in lynx I get ones like [about.gif] while links only gives my [IMG] which is even worse) you did quite well, the iframe was a little annoying, but it was still accessible in both browsers).
konqueror has a few complaints about your image rollover script, but nothing to worry about(since your average user won't be using konqueror and it's not an essential feature).
cserednyj
08-13-2008, 11:26 PM
I was thinking the same about the links..I like the disc's so maybe if I change the font it would be better you think?
I am sorry...Can I also insist that you add alt and title text for images? I tool the liberty of testing the page in both lynx and links(2 command line browsers which give a good idea of how screen readers will present the content, and other than the fact that I got stupid name for the links(so in lynx I get ones like [about.gif] while links only gives my [IMG] which is even worse) you did quite well, the iframe was a little annoying, but it was still accessible in both browsers).....I don't understand...you mean change the name of the .gif? And I know that I know what iframe is, but I can't seem to remember. I am new at this. Obviously. I like it and I am determined to learn everything I can...if you could explain what you meant, I'd appreciate it. I feel stupid, I'm sorry.
scragar
08-13-2008, 11:31 PM
what I mean:
<img src="images/home_button.gif" name="home" width="98" height="65" border="0" id="home" alt='home' title='home' />
alt is used when the image cannot be loaded, very useful for text browsers, title is supposed to be used when the image is hovered over, although with most browsers if the title text is not used the alt text is used, this is not done with all browsers though.
cserednyj
08-13-2008, 11:35 PM
Oh...I see. I guess I have to add it manually..I didn't realize that. Ok...Is the iframe from me using a table to create the pages?
scragar
08-14-2008, 12:18 AM
the iframe does use tables for layout(if that is not what you wanted to know rephrase please :P).
I also took the time to validate your page, it did fail, however the errors are nothing serious as far as I can tell(although you couldn't go wrong to correct a number of them)
http://validator.w3.org/check?uri=http%3A%2F%2Fwww.djsmostwanted.com%2F&charset=(detect+automatically)&doctype=Inline&group=1&verbose=1&user-agent=W3C_Validator%2F1.591
the first 3 errors are solved by removing the unwanted " from the end of the tag, the next ones in that group are really just complaining about your lack of the <tbody> tag which should go inside the table before <tr> and close just before you close the table(google it if you didn't understand)
in the next section it's complaining that _ is not a valid character in the name field, use - instead.
the next error explains itself, align should be middle, not center. use CSS to get "text-align: center" which is what you want.
few complaints about missing atributes(mostly alt text on your images, but the script tag needs a type as well:<script type='text/javascript'>)
the complaints in the next box should be skipped for now, since they are a bit much, learn more and fix future sites rather than risk breaking the fact that this works(but isn't standards compliant) trying to get a bit more compliant with knowledge you don't have yet.
there's another complaint about the " shortly after that, and it ends with a complaint about noscript being in the wrong places, but again, ignore that till you have a better understanding of the standards etc.
cserednyj
08-14-2008, 01:12 AM
Whew...wow....I will look at all of this...definitely a lot more to learn. Thank you so much! I never would have figured these things out. I changed the font and added alt and title to the pages. I think you can read it better now.
scragar
08-14-2008, 02:15 AM
it's a lot yes, but for now your site works more than I can say for some sites(I'm gonna keep the list to myself, but it's amazing how some sites can just ignore large portions of the audience for no real reason(as I said, the command line browsers give a good idea of what screen readers for blind people repesents, as well as an idea of what really old browsers will see, it may not be required to support those users for your current needs, but you should ALWAYs cater for them, because closed intranets have a habit of suddenly becoming a part of the companies website, or the site you built to sell photographs suddenly the idea of branching into selling furniture or whatever, believe me, it happens)).
learn what you need as you advance, I started off thinking front page was the start of web design and dreamweaver was the end, now I do all my work in a text editor cutting in bits from various other text files I have built as samples(so I've got one with a couple of basic menu's(like yours), a couple of sample footers and such, while another has a list of doctypes for me to pick from, a basic layout for XHTML or HTML documents... the list goes on for quite a while), if you stick with it you'll learn all you need to(and mostly likely a bit more) eventually.
cserednyj
08-14-2008, 03:36 AM
oh wow...well hopefully I'll get that good some day! Thank you for all of your help. Did the flash banner work for you in internet explorer? My husband is trying it from his computer and it won't work. But I think it might just be that computer.
scragar
08-14-2008, 03:49 AM
I won't be able to test flash from IE for around an hour, when I go to work(I'll test it from a windows machine at work), I shall test it then.