CupidDeLocke
10-29-2003, 10:18 PM
Now that i'm finally (mostly) done my site, i would love to have some people i don't know tear it apart. Or just give me feedback.
http://www.tylerstalman.com
http://www.tylerstalman.com
Click to See Complete Forum and Search --> : Could i get some site feedback?
Sux0rZh@jc0rz
10-29-2003, 11:20 PM
didnt check any of your code, but the site looks nice and loads fast. nice effects with the photo's btw. too bad there wasnt more content to browser through!
spufi
10-30-2003, 12:48 AM
http://validator.w3.org/check?uri=http%3A%2F%2Fwww.tylerstalman.com%2Fmain.php
There's your validation errors for your main page. Change the one <meta> tag so it's in HTML form and not XHTML form and that should clean up a number of errors. You seem to use some XHTML styled tags on a number of your pages. Either go with HTML, or XHTML.
http://www.alistapart.com/articles/flashsatay/
That link is going to help validate your <object> tag you use for Flash.
Since you have a external CSS file, there's no real reason to have stlyes defined within a tag. You can also get rid of the align attribute and define it in your external CSS file.
Granted me using a 1400X1050 resolution with a maxed out window isn't near the norm for what people view sites with, but that is a lot of white. Maybe using a ever so slight grey, or some other color for a background color around your main content area could help focus more towards your content. It just looks kind of sparse right now.
Your copyright statement could be more visible. It being bigger would be a good place to start.
The contact link probably should be in the regular menu. Why do you have a little form for contact and then you have a mailto option on your info page? I would just use a form for e-mail and not the mailto link. A form looks more professional to me.
I do like the site though.
There's your validation errors for your main page. Change the one <meta> tag so it's in HTML form and not XHTML form and that should clean up a number of errors. You seem to use some XHTML styled tags on a number of your pages. Either go with HTML, or XHTML.
http://www.alistapart.com/articles/flashsatay/
That link is going to help validate your <object> tag you use for Flash.
Since you have a external CSS file, there's no real reason to have stlyes defined within a tag. You can also get rid of the align attribute and define it in your external CSS file.
Granted me using a 1400X1050 resolution with a maxed out window isn't near the norm for what people view sites with, but that is a lot of white. Maybe using a ever so slight grey, or some other color for a background color around your main content area could help focus more towards your content. It just looks kind of sparse right now.
Your copyright statement could be more visible. It being bigger would be a good place to start.
The contact link probably should be in the regular menu. Why do you have a little form for contact and then you have a mailto option on your info page? I would just use a form for e-mail and not the mailto link. A form looks more professional to me.
I do like the site though.
CupidDeLocke
10-30-2003, 04:27 PM
wow, that has to be the most informative helpful reply i could have gotten. thanks a lot :)
CupidDeLocke
10-30-2003, 10:12 PM
i am a little confused as to where this xhtml reference is.
spufi
10-30-2003, 10:28 PM
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<link href="styles_net.css" rel="stylesheet" type="text/css" />
<img src="images/girl11a.jpg" width=300 height=225 title="Click photo to enlarge"\>
The first two are in all of your <head> tags. XHTML requires all tags to have a closing tag. The problem with things like <meta>, <link>, and <img> tags, is there are no closing tags for them because they are considered empty tags. Empty as in all of the info is in the definition of the tag and nothing between the opening and closing tags. Anyway, change the <meta> and <link> tags to this.
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<link href="styles_net.css" rel="stylesheet" type="text/css">
The <img> tag is only partly correct for XHTML. I only checked the one page for the <img> tag, so I can only assume the others were done just like it. Here's the HTML version.
<img src="images/girl11a.jpg" width="300px" height="225px" alt="Name of girl incase the image doesn't display" title="Click photo to enlarge">
Technically an <img> tag in XHTML would look like this
<img src="images/girl11a.jpg" width="300px" height="225px" alt="Name of girl incase the image doesn't display" title="Click photo to enlarge" />
<link href="styles_net.css" rel="stylesheet" type="text/css" />
<img src="images/girl11a.jpg" width=300 height=225 title="Click photo to enlarge"\>
The first two are in all of your <head> tags. XHTML requires all tags to have a closing tag. The problem with things like <meta>, <link>, and <img> tags, is there are no closing tags for them because they are considered empty tags. Empty as in all of the info is in the definition of the tag and nothing between the opening and closing tags. Anyway, change the <meta> and <link> tags to this.
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<link href="styles_net.css" rel="stylesheet" type="text/css">
The <img> tag is only partly correct for XHTML. I only checked the one page for the <img> tag, so I can only assume the others were done just like it. Here's the HTML version.
<img src="images/girl11a.jpg" width="300px" height="225px" alt="Name of girl incase the image doesn't display" title="Click photo to enlarge">
Technically an <img> tag in XHTML would look like this
<img src="images/girl11a.jpg" width="300px" height="225px" alt="Name of girl incase the image doesn't display" title="Click photo to enlarge" />
pyro
10-30-2003, 10:59 PM
Originally posted by spufi
Technically an <img> tag in XHTML would look like this
<img src="images/girl11a.jpg" width="300px" height="225px" alt="Name of girl incase the image doesn't display" title="Click photo to enlarge" /> Just one little thing to note with that: the width and height should be specified as nn for pixels and nn% for percentages (no px unless you are using styles). http://www.w3.org/TR/xhtml1/dtds.html#dtdentry_xhtml1-strict.dtd_Length
Technically an <img> tag in XHTML would look like this
<img src="images/girl11a.jpg" width="300px" height="225px" alt="Name of girl incase the image doesn't display" title="Click photo to enlarge" /> Just one little thing to note with that: the width and height should be specified as nn for pixels and nn% for percentages (no px unless you are using styles). http://www.w3.org/TR/xhtml1/dtds.html#dtdentry_xhtml1-strict.dtd_Length
spufi
10-30-2003, 11:32 PM
Just note that if you do define them with "px" in XHTML, they will validate. At least in XHTML 1.1 they do.
CupidDeLocke
10-30-2003, 11:43 PM
You guys rock my world, thanks. I fixed most of the things you mentioned, and took the others into consideration. When i get time i'm going to create a higher resolution version with larger thumbnails and photos.
However I'm still getting scads of errors on my embed tags, which i have no clue how to rectify.
However I'm still getting scads of errors on my embed tags, which i have no clue how to rectify.
spufi
10-31-2003, 12:10 AM
Originally posted by CupidDeLocke
However I'm still getting scads of errors on my embed tags, which i have no clue how to rectify.
If you work your way through the Flash article I linked to, you will end up not using the <embed> tag at all. ;)
However I'm still getting scads of errors on my embed tags, which i have no clue how to rectify.
If you work your way through the Flash article I linked to, you will end up not using the <embed> tag at all. ;)
webdeveloper.com
Copyright Internet.com Inc., All Rights Reserved.
Copyright Internet.com Inc., All Rights Reserved.