Click to See Complete Forum and Search --> : need help to open new persionified window


befou35
07-15-2004, 09:43 PM
Hi, I try to call a new window where there will be certain elements, according to certain conditions. Can you help me finding what code I wrote wrong ?

Benjamin Fournier
webmaster beginning in javascript



<script type="text/javascript">

function MyWindow(message) {
now = new Date();
LocalTime = now.toLocaleString();

//Defining contents of page
contents=
'<body bgcolor="white">'+
'<h2>Prodimax inc.</h2>'+
'Close the Window<br>'+
'<A HREF="javascript:window.close()" >'+
'message' +
'</A>'+
'if(ycheck==on)document.write(ybox())'+
'if(coudecheck==on)document.write(coudebox())'+
'if(volantcheck==on)document.write(volantbox())'+
'if(jointcheck==on)document.write(jointbox())'+
'if(valvecheck==on)document.write(valvecheckbox())'+
'if(valvetetebassecheck==on)document.write(valvetetebassecheckbox())'+
'if(valvetetehautecheck==on)document.write(valvetetehautebox())'+
'if(valveteterectcheck==on)document.write(vavlveteterectbox())'


//Creating new Window
options = "toolbar=0,status=0,menubar=0,scrollbars=0," +
"resizable=0,width=500,height=800";

newwindow=window.open("","MyWindow", options);
newwindow.document.writeln(LocalTime);
newwindow.document.write(contents);
newwindow.document.close();

}

Kor
07-16-2004, 04:26 AM
- to insert a variable into a string don't use quotes

'<A HREF="javascript:window.close()" >'+
message +
'</A>'+

- The following code lines have no meaning to me

+
'if(ycheck==on)document.write(ybox())'+
'if(coudecheck==on)document.write(coudebox())'+
'if(volantcheck==on)document.write(volantbox())'+
'if(jointcheck==on)document.write(jointbox())'+
'if(valvecheck==on)document.write(valvecheckbox())'+
'if(valvetetebassecheck==on)document.write(valvetetebassecheckbox())'+
'if(valvetetehautecheck==on)document.write(valvetetehautebox())'+
'if(valveteterectcheck==on)document.write(vavlveteterectbox())'

It looks like you add some javascript code after HTML lines in a string... I don't get what you want to do, but it looks certainly wrong to me this add.