Click to See Complete Forum and Search --> : Redesigned Homepage!!!


theuedimaster
01-06-2005, 04:40 PM
Hehe, I finally finished the basic color scheme of the whole site I am making, and I finished the homepage - minus some text. Please review! Thanks! Also... about the background image thing...... for my organizational purposes as a webdeveloper, it is so much easier for me to analyze my site by using the img tags. Thanks!

http://www.sigmaseven.net

akadis
01-06-2005, 06:49 PM
It looks good, however there are some things that need fixing:
You have a PHP error:
<br />
<b>Warning</b>: main(variable.php): failed to open stream: No such file or directory in <b>/home/sigma7/public_html/index.php</b> on line <b>4</b><br />
<br />
<b>Warning</b>: main(variable.php): failed to open stream: No such file or directory in <b>/home/sigma7/public_html/index.php</b> on line <b>4</b><br />
<br />
<b>Warning</b>: main(): Failed opening 'variable.php' for inclusion (include_path='.:/usr/lib/php:/usr/local/lib/php') in <b>/home/sigma7/public_html/index.php</b> on line <b>4</b><br />
I suggest you do the following:
// In php:
ini_set ( display_errors, "0" ); // Do not display errors
ini_set ( log_errors, "1" ); // Turn on error logging (they get put in a log instead of on the screen)
ini_set("error_log","/path/to/error_log"); // Change your error log's path, most hosts have a default, but this may be easier

// In Apache's .htaccess
php_flag display_errors 0
php_flag log_errors 1
php_value error_log /path/to/error_log

// In a php.ini
display_errors = off
log_errors = on
error_log = /path/to/error_log
You have a few html errors:
You cannot use an id more than once on a page, instead use classes:
Replace id="Window1" and id="navpic" etc... with class="Window1" class="navpic" etc...
Instead of using inline CSS: e.g. style="position:absolute; left:3px; top:54px; z-index:3" use an external CSS, it makes it easier to edit for future use, its easier to read, and instead of typing/copying and pasting it a bunch of times you can simply do:
.Window1 {
position:absolute;
left:3px;
top:54px;
z-index:3
}
All images must have alt attributes, even if you just do alt="" it makes it easier for screen readers, as they will skip over the image instead of saying "No alt attribute specified" or something to that effect.
For the Nav bar, I would suggest using an unordered list instead of many div tags. While what you did is not wrong per-se, its more semantically correct.

I would suggest trying XHTML instead of HTML, again because it is more semantic, but that is a matter of choice.

Good luck with your website, it needs some work, but you'll get it.

theuedimaster
01-06-2005, 06:55 PM
Thanks for the info, It'll help a lot. Anyways, what do you guys think of the design? The coding is something more of for myself, I want to make it clean and all, but the *stupid* user just wants functionality (my opinion).... so I am sort of concerned with design..... and code too . Anyways, thanks for the help. Anymore reviews?

amazing_andr3
01-06-2005, 07:33 PM
It falls apart if I increase the text size.

use external css. the whole point of classes is not to repeat
style="position:absolute; left:512px; top:187px; z-index:2;
for each element.

<a href="">&nbsp ;&nbsp ;&nbsp ;&nbsp ;&nbsp ;&nbsp ;&nbsp ;Highschool/College-Budget</a>
repettitive &nbsp ; is not intended for positioning. padding is.

Don't repeat this for every link:
<img src="Images/Otherpics/Homepage/Nav/Block/block.gif" width="12" height="12">
make the links a list and set it as list-style-image

I do like the jpgs.