Click to See Complete Forum and Search --> : Request for Review: http://vivin.net/


vi5in
06-27-2005, 02:43 PM
I redid my site so that it validates as XHTML 1.1. I got rid of iframes, and the only table I use is for the calendar.

I'm going to change the main banner to something better - I just made that one with the time I had.

Let me know what you think (please be gentle ;)).

http://vivin.net/

the tree
06-27-2005, 02:53 PM
The first thing to strike me is that vertical scroll bar a the bottom of my browser* window.

Someone is going to come in and scream at you for mixing an xhtml doctype and a html mime type.

The design isn't groundbreaking, but it isn't bad either.

*FF at 1024.

crh3675
06-27-2005, 03:46 PM
What's with all the bizarre line breaks for each attribute in the code? You have over 152 bytes of un-necessary line breaks and 3986 bytes of extra spaces in your code. The vertical nav could be narrower and the calendar takes up too much space. Your hyperlink color is too close to black and without underlines, who can tell what's text and what's a hyperlink.

vi5in
06-27-2005, 04:33 PM
The first thing to strike me is that vertical scroll bar a the bottom of my browser* window.

Vertical scroll bar at the bottom? Do you mean the horizontal scroll bar? I've removed that - it should be fine now.

Someone is going to come in and scream at you for mixing an xhtml doctype and a html mime type.

Would that be you? :) D'oh! I had that coded in there (to send application/xhtml+xml to FF and other supporting browsers and text/html to IE) but when I reverted to an earlier version I forgot to add it back in. It should be working now.

What's with all the bizarre line breaks for each attribute in the code? You have over 152 bytes of un-necessary line breaks and 3986 bytes of extra spaces in your code.

I do that to make my code more readable (for myself when editing). But I guess that takes longer to load? So that's 4138 bytes, or 4.04kb - I'm guessing that's too much? Thanks for pointing this out. My background is mainly programming (C/Perl/etc) and I started doing that before web development so I try to make my code look very clean - but I guess you have to sacrifice what you think might be "clean" for size?

The vertical nav could be narrower and the calenda
r takes up too much space.

Yeah, I've noticed that it looks much bigger in 800x600 - how much smaller do you think I should make it? It is 274px wide now.

Your hyperlink color is too close to black and without underlines, who can tell what's text and what's a hyperlink.

I'll change that ASAP.

Thank you both for your feedback!

vi5in
06-27-2005, 04:43 PM
*removed*

dera
06-28-2005, 05:57 AM
good work, you need to fix your title with a title http://fabio.ugtech.net/webdev/46/using-the-title-tag-correctly also good work make it complient, to fix your website so it works in all resolutions which all website should be put your banner as a backround for the div in css if you dont get wat i mean ill explain

vi5in
06-28-2005, 12:00 PM
Thanks for the suggestion, dera!

I use the image as a background for the div using the background-image and the background-repeat:no-repeat property.