PDA

Click to See Complete Forum and Search --> : Urgent: What's wrong with my code?

caroldhn
04-23-2003, 07:55 PM
Can you please tell me what's wrong with my script below?

Thankyou so much!!!

<html>
<script type="text/javascript">
function click_y(idNum, theFunc){
var obj1 = document.getElementById("cb1");
var obj2 = document.getElementById("cb2");
var prop1;
var prop2;
if (obj1) {
if (theFunc) {
prop1 = "visible";
prop2 = "hidden";
} else {
prop1 = "hidden";
prop2 = "hidden";
}
} else if (obj2) {
if (theFunc) {
prop1 = "hidden";
prop2 = "visible";
} else {
prop1 = "hidden";
prop2 = "hidden";
}
} else {
}
obj1.style.visibility = prop1;
obj2.style.visibility = prop2;
}

</script>
</head>
<body>
<form name="frm" action="">
<table>
<tr><td>
New? (Never in inventory)
<input type="radio" name="check" onclick="click_y(cb1, 0);"><br>
Reprint? (Additional stock of existing item.<br>I.E. - More of the same)
<input type="radio" name="check" onclick="click_y(cb1, 1);"><br>
Version or Revision: (*Different version or<br>updated revision of a current stock item)
<input type="radio" name="check" onclick="click_y(cb2, 1);">
<br>
<p id="cb1" style="visibility:hidden;"> Number: <input type="text" name="number" size="20" value="cb1"></p>
<p id="cb2" style="visibility:hidden;"> Number: <input type="text" name="number" size="20" value="cb2"> number 2 <input type="text" name="number" size="20" value="cb2-num2"></p>
</td>
</tr>
</table>
</form>
</body>
</html>
khalidali63
04-23-2003, 08:37 PM
Nope, there is nothing wrong with it.Its perfect....(unless you describe your problem..that is)
DrDaMour
04-23-2003, 09:09 PM
logically i can see an error since obj1 always exists the first if branchis the only one getting called ever

if (obj1) {
if (theFunc) {
prop1 = "visible";
prop2 = "hidden";
} else {
prop1 = "hidden";
prop2 = "hidden";
}
}

will always get called.

you never used the firs parameter of your function like you wanted to i think but you'll have to explain what you wanted
caroldhn
04-24-2003, 01:12 AM
my problem is that when i run that page, it looks like the below block of code never gets executed:

else if (obj2) {
if (theFunc) {
prop1 = "hidden";
prop2 = "visible";
} else {
prop1 = "hidden";
prop2 = "hidden";
}

when:

<input type="radio" name="check" onclick="click_y(cb2, 1);">


I get:

<p id="cb1" style="visibility:hidden;"> Number: <input type="text" name="number" size="20" value="cb1"></p>

instead of:

<p id="cb2" style="visibility:hidden;"> Number: <input type="text" name="number" size="20" value="cb2"> number 2 <input type="text" name="number" size="20" value="cb2-num2"></p>


Why is that? Something wrong with my logic?

Thank you for replying.

CN
DrDaMour
04-24-2003, 03:07 AM
in an

if(true){
code1
}
else if(true){
code2
}
else{
code3
}

code1 will always get done, while code2 will never get done, nor code3
caroldhn
04-24-2003, 12:01 PM
Thank you for pointing it out. However, I don't know how to edit that code to make it work. Do you have any idea? By the way, do you know where I can get a complete javascript documentation?

Thank you,
CN
Jona
04-24-2003, 12:07 PM
I think you had a boo-boo, caroldhn... Accidental reply? ;)
caroldhn
04-24-2003, 12:10 PM
Yes. It was an accident. LOL. Anyway, I repost my msg at the correct place.

Thanks,
CN