Help With A Xena Instant Story

[Carly]

I can't work out what I'm doing wrong, but my instant story just won't work. Can you take a look and see what I've done?


www.angelfire.com/ego/ares/instant.html

[khalidali63]

Its a huge form to be filled by some one to find out whats wrong with it,you have a better chance of getting help if you described whats wrong and may be posted your error too.

[Carly]

Thanks Khalid. I can't get the story to come up. The problem is in the form.story.value section. If I put other words in there between the " and " marks, it works. But what I've got doesn't work, I can't understand why??


function compute(form) {
form.title.value = ("''LOVE SHACK,'' by " + form.firstName.value + " " + form.lastName.value);
if(form.gender.value == "Male" || form.gender.value == "male") {var boyGirl = "boy"} else {var boyGirl = "girl"};
if(form.gender.value == "Male" || form.gender.value == "male") {var heShe = "he"} else {var heShe = "she"};
if(form.gender.value == "Male" || form.gender.value == "male") {var hisHer = "his"} else {var hisHer = "her"};
if(form.gender.value == "Male" || form.gender.value == "male") {var himHer = "him"} else {var himHer = "her"};

form.story.value = (" What on earth are you doing, Ares?’ Xena asked, raising an eyebrow. She looked around. The old " + form.house.value + " was in exactly the same condition as it had been that morning – or in fact, it was worse.`I’m fixing the roof, like you said,’ Ares replied sulkily.`So why are you on the floor?’ Xena asked. Then she looked up. `Oh.’`Yeah, oh.’ Ares raised himself on one elbow, and sneezed as the dust rose up around him. Xena was wearing her " + form.colour.value + " dress; there was only one thing to do.Xena shook her head and reached out her hand. ‘Come on, then-‘Ares grasped her hand. Then pulled.‘ " + form.exclaim.value + " !’ Xena fell crashing down on top of him. `Why, you –‘Ares silenced any further exclamations by an unusually effective method; he kissed her. Then he sat up.‘Where’s Gabrielle?’ he asked casually.‘She’s spending the rest of the day at " + form.place.value + " .’‘Hmm, that creates something of a difficulty then, doesn’t it?’ Ares went on slowly.‘What do you mean?’ Xena asked, her eyes narrowing.‘Well, how am I going to keep my hands off you for the rest of the day, knowing that Gabrielle isn’t going to be around to interrupt us?’Xena shook her head, and then laughed. ‘You’ve got me there –‘‘Where?’Xena leant forward, her mouth an inch away from his. ‘Here . . .’She hesitated just a moment longer before touching her lips to his own. Moving closer, she slid her hands over his bare chest before settling her arms around his neck, drawing him close to her.‘Ares?’The pair separated hastily.‘Uh – " + form.person.value + " ?’ Ares called back, getting up hastily and pulling Xena up with him. ‘What are you doing here?'‘Just popped in for a visit!’ " + form.person.value + " said brightly. ‘Here, I’ve brought some home-made " + form.food.value + " for us to share . . .’ Then " + heShe + " stopped. ‘Oh. Was I interrupting . . .’‘No,’ said Xena.‘Yes,’ said Ares.They looked at one another. " + form.person.value + “coughed. ‘I’ll just leave it on the " + form.furniture.value + " here, shall I? I want the plate returned though . . .’Xena looked around, embarrassed. ‘This place is so " + form.adjective.value + " , isn’t it . . .’‘Don’t change the subject, Xena . . . did " + form.person.value + " interrupt something, or – did you feel nothing?’‘I – I –‘ Xena began, then stopped. ‘I felt something,’ she said hoarsely. Then she stepped closer. ‘I feel something . . .’Their fingers touched, intertwined, in the space between them. Then they were back in each other’s arms, in the middle of the " + form.adjective. value + " room, a hole in the roof, a " + form.food.value + " on the " form.furniture.value + " . But they were nowhere at all, except with the other. Their kisses drove them breathless and wild; a " + form.maleclothes.value + " found its way to one end of the room, while a " + form.femaleclothes.value + " lay somewhere opposite. Moving towards the staircase, they pushed over a " + form.object.value + " , while a " + form.ornament.value + " smashed into a thousand pieces on the ground.‘I don’t think we’re going to make it to the " + form.room.value + " ,’ Ares said hoarsely.
Xena didn’t bother to answer, her mouth moving over his " + form.malebody.value + " until he groaned, pushing her back against the wall, and focusing his attentions on her " + form.femalebody.value + " , while she flung her head back and sighed with pleasure.‘Xena?' " + form.exclaim.value + " !’ Xena cried out. ‘Gabrielle’s back!’ She looked around. ‘All right – I’ll handle this – you get upstairs . . .’
Ares obeyed reluctantly.‘Xena? What’s – this place is a mess!’ Gabrielle exclaimed. ‘And what did you do to the poor " + form.pet.value + " hiding under the verandah?’ Then she looked at Xena more closely. ‘Are you all right? You’re all flushed, and –'‘I do get kind of worked up when " + form.person.value + " comes over to visit,’ Xena admitted hastily. ‘In fact, I ended up having to work off the excess energy by –‘‘Practising your kicks inside? I thought we had a rule about that, Xena,’ Gabrielle said, shaking her head. ‘Here, I brought back some " + form.liquid.value + " .’ She looked up at the staircase. `You’d better come down, Ares, and help us drink it!' ");
}

[DrDaMour]

first off angelfire is screwing up some stuff, because of their added code.

also:
your quotes are getting all messed up heres some help


said Ares.They looked at one another. " + form.person.value + “coughed.

should be

said Ares.They looked at one another. " + form.person.value + " “coughed.


Also you can't devide up a string like you did by having a carriage return in the middle of it, i'm referring ot the lines

Ares said hoarsely.
Xena didn’t bother to answer

and

ll handle this – you get upstairs . . .’
Ares obeyed reluctantly.‘Xena? What


Finaly, you can't have the variable of yoru function be named form, it confuses the browser, so change yoru compute(form) to somelike like compute(f) and change all the form 's to f 's

i got it working by doing all that.

[Carly]

Thanks for those tips, although I'm working on it right now and it has made no difference whatsoever . . . argh!!

[skriptor]

Hi Carly,
another thing you use a field form.person your form has no field person, I think field age should be renamed...

Good luck, skriptor

[DrDaMour]

yeah i noticed that too. And it has made a differnece, you have a good amount of errors, each fix is a ding in teh armor

[Carly]

Thanks for pointing that one out. The browser is now registering that there are errors - maybe that's a step forward at least . . . :rolleyes:

[skriptor]

Hi Carly,
another thing: you use a field form.liquid but your form has no such field. I think field drink should be renamed...

Good luck, skriptor