simple hide function is not working as intended

Printable View

10-01-2010, 02:05 PM
jschick

simple hide function is not working as intended

Hi all,

First of aal sorry for my ignorance, but i just started with javascript.
I made small function with that hides or shos a div. In addition to that i made a small button that class that function.

Maybe someone could take a look at it and point me in the right direction:
this i put in my <head> </head>

Code:

<script type="text/javascript"> function hide_me(haha){ var el = document.getElementById(haha) if (el.style.display != 'none'){ el.style.display = 'none'; }else{ el.style.display = ''; } } </script>

and in the body i have this

Code:

<div id="haha"> <p>moehaha i am invisible</p> </div> <input type="submit" onclick="hide_me(haha)" value="press me" />
10-01-2010, 02:37 PM
jschick

I solved it myself by adding a single quotes around the value in the button.
Like:

Code:

<input type="button" onmouseover="hideDiv('mydiv')" value="HIDE!!!"/>

But there is one thing that is really confusing me. Why do i have to use single quotes here and why a function like below doesn't use them? This maybe a noobie question, but if someone could explain me why it would help me alot, I searched for parameters javascript functions, but I didn't found a direct answer to this question.

Code:

function toggle(obj){ // etc }
10-02-2010, 03:48 AM
Fang

In the onmouseover function you are passing a string, hence the need for quotes.
The function argument is a reference to the string.
It's a bit like defining a variable

Code:

var foo = 'bar';

The name of the variable isn't quoted, but it's string value is.
10-02-2010, 07:57 AM
jschick

Ah, that makes sense. Thanks alot for the explanation.
Cheers!