www.webdeveloper.com
Results 1 to 2 of 2

Thread: File upload 0 bytes

  1. #1
    Join Date
    Jan 2006
    Posts
    10

    File upload 0 bytes

    This uploads the file but the file has 0 bytes. I know it should work because I have done the exact same thing in other scripts. But this one will not work. I have ENCTYPE in the form (see below), so that is not the problem. Does anyone see anything wrong with this?

    <form ENCTYPE="multipart/form-data" action="customerm2.cgi" method="post" name="customerm">

    $query = new CGI;
    $cgi = new CGI;

    $directory_name = $query->param('directory_name');
    $photo1 = $query->param('photo1');

    print $cgi->header(-type=>'text/html');

    if ($photo1 ne "") {
    $upload_dir = "../gallery/$directory_name/";
    $photo_name = $photo1;
    $photo_name =~ s/^.*(\\|\/)//g;
    if($photo_name){
    open(OUT, ">>$upload_dir/$photo_name") || die print "Fail to upload: $!";
    while(<$photo_name>) {
    print OUT;
    }
    close(OUT);
    }
    }

    Thanks!
    -tdavis

  2. #2
    Join Date
    Jan 2003
    Location
    USA
    Posts
    687
    You've got a couple of fundamental elements missing.
    Code:
    $query = new CGI;
    #$cgi = new CGI; <- NOT NEEDED - Only using one CGI object
    
    $directory_name = $query->param('directory_name');
    $photo1 = $query->param('photo1');
    
    if ($photo1 ne "") {
    $upload_dir = "$directory_name/";
    $photo_name = $photo1;
    $photo_name =~ s/^.*(\\|\/)//g;
    if($photo_name){
    my $upload = $query->upload('photo1');
    open(OUT, ">$upload_dir/$photo_name") || die "Failed to upload: $!"; 
    binmode OUT; #Utilizes binary mode for Windows machines
    while(<$upload>) {
    print OUT;
    }
    close(OUT);
    }
    }
    print $query->header, "DONE";
    I'd recommend that you use the strict pragma and also validate your directory_name input.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.17542 seconds
  • Memory Usage 2,833KB
  • Queries Executed 13 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (1)bbcode_code
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (2)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (2)postbit
  • (2)postbit_onlinestatus
  • (2)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (70):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates