www.webdeveloper.com
Results 1 to 6 of 6

Thread: [RESOLVED] More Efficient?

  1. #1
    Join Date
    Oct 2006
    Posts
    1,297

    resolved [RESOLVED] More Efficient?

    The following works perfectly. But, I'd like to know if there is a more efficient way to do it -- because I've got another object, with 24 properties, that needs to be loaded into a MySQL table right after this one. Thanks.
    PHP Code:
    for ($x=0$x<count($res['Identities']); ++$x):
        
    $full_name     mysql_escape_string($res['Identities'][$x]->full_name);
        
    $email_address mysql_escape_string($res['Identities'][$x]->email_address);
        
    $reply_to      mysql_escape_string($res['Identities'][$x]->reply_to);
        
    $signature     mysql_escape_string($res['Identities'][$x]->signature);
        
    $use_sig       mysql_escape_string($res['Identities'][$x]->use_sig);
        
    $sig_reply     mysql_escape_string($res['Identities'][$x]->sig_reply);
        
    $sig_forward   mysql_escape_string($res['Identities'][$x]->sig_forward);
        
    $sql "Insert Into `user_identities` (`userid`, `full_name`, `email_address`, `reply_to`, `signature`, `use_sig`, `sig_reply`, `sig_forward`)
                Values(
    {$userid}, '{$full_name}', '{$email_address}', '{$reply_to}', '{$signature}', '{$use_sig}', '{$sig_reply}', '{$sig_forward}');";
        if (!
    $result mysql_query($sql)):
            echo 
    '<p>Error: ' .mysql_errno(). '; ' .mysql_error(). "<br>\n".
                 
    "sql = \"{$sql}\"</p>\n";
            exit;
        endif;
    endfor; 
    Last edited by so_is_this; 11-28-2006 at 07:05 PM.

  2. #2
    Join Date
    Mar 2005
    Location
    Guayaquil - Ecuador
    Posts
    144
    PHP Code:


    foreach ($res['Identities'] as $x) {
        
    $full_name     mysql_escape_string($x->full_name);
        
    $email_address mysql_escape_string($x->email_address);
        
    $reply_to      mysql_escape_string($x->reply_to);
        
    $signature     mysql_escape_string($x->signature);
        
    $use_sig       mysql_escape_string($x->use_sig);
        
    $sig_reply     mysql_escape_string($x->sig_reply);
        
    $sig_forward   mysql_escape_string($x->sig_forward);
        
    $sql "Insert Into `user_identities` (`userid`, `full_name`, `email_address`, `reply_to`, `signature`, `use_sig`, `sig_reply`, `sig_forward`)
                Values(
    {$userid}, '{$full_name}', '{$email_address}', '{$reply_to}', '{$signature}', '{$use_sig}', '{$sig_reply}', '{$sig_forward}');";
        if (!
    mysql_query($sql)) {
            echo 
    '<p>Error: ' .mysql_errno(). '; ' .mysql_error(). "<br>\nsql = \"{$sql}\"</p>\n";
        }

    Last edited by delr2691; 11-28-2006 at 07:15 PM.
    Diego Luces

  3. #3
    Join Date
    Oct 2006
    Posts
    1,297
    Yeah, that much I already figured. I was hoping for more.

  4. #4
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,335
    PHP Code:
    // create an array of value lists:
    $values = array();
    foreach (
    $res['Identities'] as $x
    {
       
    $values[] = sprintf("($userid,'%','%','%','%','%','%','%')",
                           
    mysql_escape_string($x->full_name),
                           
    mysql_escape_string($x->email_address),
                           
    mysql_escape_string($x->reply_to),
                           
    mysql_escape_string($x->signature),
                           
    mysql_escape_string($x->use_sig),
                           
    mysql_escape_string($x->sig_reply),
                           
    mysql_escape_string($x->sig_forward));
    }
    // now you can do just one insert query with multiple value lists:
    $sql "Insert Into `user_identities` (`userid`, `full_name`, `email_address`, `reply_to`, `signature`, `use_sig`, `sig_reply`, `sig_forward`) VALUES ".implode(', '$values);
    $result mysql_query($sql) or die(mysql_error() . ": $sql"); 
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  5. #5
    Join Date
    Oct 2006
    Posts
    1,297
    Thanks, NogDog, but I was really also wanting to avoid hard-coding a bunch of property and column names, too.
    So, this is what I've come up with -- and it works. Reactions?
    PHP Code:
    foreach ($res['Identities'] as $obj):
        
    object_to_field_list($obj$fields=''$values='');
        
    $sql "Insert Into `user_identities` (`userid`,{$fields}) Values({$userid},{$values});";
        if (!
    $result execute_sql($sql)) exit;
    endforeach; 
    PHP Code:
    function object_to_field_list(&$obj, &$field_list, &$values_list)
    {
        foreach(
    $obj as $key => $value):
            if (
    strlen($field_list) > 0):
                
    $field_list .= ',';
                
    $values_list .= ',';
            endif;
            
    $field_list .= '`' .$key'`';
            if (
    is_numeric($value)):
                
    $values_list .= $value;
            else:
                
    $values_list .= "'" .mysql_escape_string($value). "'";
            endif;
        endforeach;
    }
    function 
    report_mysql_error($sql)
    {
        echo 
    '<p>Error: ' .mysql_errno(). '; ' .mysql_error(). "<br />\n".
             
    "sql = \"{$sql}\"</p>\n";
    }
    function 
    execute_sql($sql)
    {
        if (!
    $result mysql_query($sql)):
            
    report_mysql_error($sql);
            return 
    false;
        endif;
        return 
    $result;


  6. #6
    Join Date
    Nov 2006
    Posts
    41
    Run it through a benchmark.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.10219 seconds
  • Memory Usage 2,933KB
  • Queries Executed 13 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (5)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (6)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (6)postbit
  • (6)postbit_onlinestatus
  • (6)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (70):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates