Whyam i getting errors???

**skatermike21988** · 12-30-2006 01:44 AM

ok i have a code that pulls data out from a xml file, once pulled i have the javascript parse it to the page, that all works, now i need it to have add a link to refer to another javascript function.

The problem is this.

My code works fine like this:

Code:

<script type="text/javascript">
function changemusic(id) {

xmlDoc=loadXMLDoc('changemusic.php?id='+id);
var playlist_div=document.getElementById("playlist");
playlist_div.innerHTML='';


var x=xmlDoc.getElementsByTagName('artist');
var k=xmlDoc.getElementsByTagName('title');
var j=xmlDoc.getElementsByTagName('java');
for (i=0;i<x.length;i++)
  {
var artist=(x[i].childNodes[0].nodeValue)
var title=(k[i].childNodes[0].nodeValue) 
var java=(j[i].childNodes[0].nodeValue)

 
document.getElementById("playlist").innerHTML +=artist+' - '+title+'<input type=button  value=play><br>';
 }

}
</script>

Butonce i add the onclick command to the button i recieve errors

Code:

<script type="text/javascript">
function changemusic(id) {

xmlDoc=loadXMLDoc('changemusic.php?id='+id);
var playlist_div=document.getElementById("playlist");
playlist_div.innerHTML='';


var x=xmlDoc.getElementsByTagName('artist');
var k=xmlDoc.getElementsByTagName('title');
var j=xmlDoc.getElementsByTagName('java');
for (i=0;i<x.length;i++)
  {
var artist=(x[i].childNodes[0].nodeValue)
var title=(k[i].childNodes[0].nodeValue) 
var java=(j[i].childNodes[0].nodeValue)

 
document.getElementById("playlist").innerHTML +=artist+' - '+title+'<input type=button value onclick='+java+'><br>';
 }

}
</script>

Here is all related code:

here is a link to my page

http://www.music.friendshideout.com/desktopplayer.php

you will need to register in order to view, the register page will open in a seperate window, once registered you can exit and login, you will see my picture as i am an instant friend, click on it and a list of songs will be displayed, when i click play is when i recieve the errors.

it comes up with errors only when i add onclick="somefunction();"

i have even tried making up a basic function to display data in a div and i still recieve errors. Here is the whole code

desktopplayer.php:

Code:



<html>
<head>




<script type="text/javascript" src="loadxmldoc.js"> 
<script type="text/javascript">

function song(what,who){
document.getElementById("music1").innerHTML='<object id="mediaplayer1" width="200" height="45" classid="CLSID:6BF52A52-394A-11d3-B153-00C04F79FAA6" type="application/x-oleobject"><param name="URL" value="'+what+'"><param name="AutoStart" VALUE="True"><param name="uiMode" value="full"><embed type="application/x-mplayer2" src="'+what+'" ShowControls="1" AutoStart="1" width="200" height="45"></embed></object>';
nowplaying(who);
return false;
}

function nowplaying(who)
{
document.getElementById("playing").innerHTML='<font color="blue"><h4>Now Playing '+who;
		
	
}



function changemusic(id) {

xmlDoc=loadXMLDoc('changemusic.php?id='+id);
var playlist_div=document.getElementById("playlist");
playlist_div.innerHTML='';


var x=xmlDoc.getElementsByTagName('artist');
var k=xmlDoc.getElementsByTagName('title');
var j=xmlDoc.getElementsByTagName('java');
var playlist = document.getElementById("playlist");
for (i=0;i<x.length;i++)
  {
var artist=(x[i].childNodes[0].nodeValue);
var title=(k[i].childNodes[0].nodeValue) ;
var java=(j[i].childNodes[0].nodeValue);




 
document.getElementById("playlist").innerHTML +=artist+' - '+title+'<input type="button" value="Play" onclick="'+java'+"><br>';

 }

}
</script>












</head>
<body>
<?




echo"<center>Welcome $displayname";





echo"<table><tr><td width='500' colspan=2><br><div id='playing'></div>";

echo"
<div id='playing'></div>
<div id='music1'>
<object width='200' height='45' 
classid='CLSID:6BF52A52-394A-11d3-B153-00C04F79FAA6'
type='application/x-oleobject'>
<param name='URL' value=''>
<param name='AutoStart' VALUE='True'>
<param name='uiMode' value='full'>
<embed type='application/x-mplayer2'
src=''
ShowControls='1'
width='200'
height='45'>
</embed>
</object>
</div>";

echo"<div id='playlist'></div></td></tr>";

//User has no blogs

echo"</table>";



echo"<table><tr><td colspan=10>Listen To Friends Music</td></tr>";








$data1 = mysql_query("SELECT * FROM friends WHERE user_id='$id' LIMIT 10") 
or die(mysql_error()); 
while($info1 = mysql_fetch_array( $data1 )) { 


$friendid=$info1['friend_id'];

$data = mysql_query("SELECT * FROM users WHERE user_id='$friendid'") 
or die(mysql_error()); 
while($info = mysql_fetch_array( $data )) {

 
 $display=$info['display_name'];
 $photo=$info['default_photo'];
 $online=$info['online'];




?><td valign=top><center><a href='#' style="text-decoration:none;" onclick="changemusic('<? echo"$friendid";?>');">
<?
echo "<font color='blue'>$display<br>";

Print "<img src='$photo' height='75' width='75' border='0'></a>"; 
//display if user is online
if ($online=='0') {
echo"</font></td>";
}
else
{
echo "<br><img src='http://www.friendshideout.com/images/online.gif'></font></td>";
}
}

}

here is loadxmldoc.js

Code:

function loadXMLDoc(dname)
{
var xmlDoc;
// code for IE
if (window.ActiveXObject)
{
xmlDoc=new ActiveXObject("Microsoft.XMLDOM");
}
// code for Mozilla, Firefox, Opera, etc.
else if (document.implementation && document.implementation.createDocument)
{
xmlDoc=document.implementation.createDocument("","",null);
}
else
{
alert('Your browser cannot handle this script');
}
xmlDoc.async=false;
xmlDoc.load(dname);
return(xmlDoc);
}

and changemusic.php:

(this is where the value for java comes from)

Code:

$xml = '<?xml version="1.0" ?><root>';
$data2 = mysql_query("SELECT * FROM music WHERE user_id='$userid' ORDER BY artist ASC") 
or die(mysql_error()); 
while($info2 = mysql_fetch_array( $data2 )) {




//Pull data from database about that user

$songid="".$info2['song_id'] . "";
$source="".$info2['source'] . "";
$artist="".$info2['artist'] . "";
$title="".$info2['title'] . "";



//Display 5 most recent blogs

$xml .= '<song id="' . $songid . '">';
$xml .= "<artist>" . $artist . "</artist>";
$xml .= "<java>song('" . $source . "','" . $artist . " - " . $title . "')</java>";
$xml .= '<title>' . $title . '</title>';
$xml .= '<source>' . $source . '</source>';
$xml .= '</song>';


}
$xml .= '</root>';
echo $xml;

That is all code related to that page. Hope this helps

**Kor** · 12-30-2006 02:38 AM

innerHTML is not a standard method. It is a crossbrowser one, it is true, but it is useful only in case you want simply to change the layout. If you need to really create/append/remove dynamically new elements and to attach events to them, you should use DOM standard methods createElement(), appendChild().... and so on.

http://www.howtocreate.co.uk/tutoria...omintroduction
http://www.w3schools.com/js/js_obj_htmldom.asp

On the other hand, to create an event handler for an element, you may use DOM 0 level syntax and an anonymous

element.onclick=function(){myFunction(arguments)}

**skatermike21988** · 12-30-2006 03:03 AM

Originally Posted by Kor

innerHTML is not a standard method. It is a crossbrowser one, it is true, but it is useful only in case you want simply to change the layout. If you need to really create/append/remove dynamically new elements and to attach events to them, you should use DOM standard methods createElement(), appendChild().... and so on.

http://www.howtocreate.co.uk/tutoria...omintroduction
http://www.w3schools.com/js/js_obj_htmldom.asp

On the other hand, to create an event handler for an element, you may use DOM 0 level syntax and an anonymous

element.onclick=function(){myFunction(arguments)}

Well thanks anyway but i found out what was wrong, my very first <script> tag wasn't closed, i closed it and all works, i appreciate you putting in the effort. Thanks

Thread: Whyam i getting errors???

Thread Tools

Display

(SOLVED) Why am i getting errors???

Thread Information

Users Browsing this Thread

Bookmarks

Bookmarks

Posting Permissions

Thread: Whyam i getting errors???

Thread Tools

Display

(**SOLVED**) Why am i getting errors???

Thread Information

Users Browsing this Thread

Bookmarks

Bookmarks

Posting Permissions

(SOLVED) Why am i getting errors???