Update db function

[cwilkey]

Greetings.

I'm writing my own banner management system. As a result, I will be updating a db to calculate impressions/clicks. I will need to do this several times throughout the site, therefore, I thought I would create a function to perform the update and just call the function.

Below is my function and how I'm calling it. For some reason, it isn't executing the update. Can someone help?

<?php

function banner_stats($banner_id, $banner_location) {
	$update_banner = "INSERT INTO banner_stats (location, impressions, banner_id) VALUES('$banner_location',impressions + 1, $banner_id)"; 
	mysql_query($update_banner, $connection) or die(mysql_error()); 
	}
?>

...and here is the call...

[code]
<?php banner_stats('home page', '1234']); } ?>

[NogDog]

For more debug info, try adding the following to the beginning of the script...

<?php
ini_set("display_errors", 1);
error_reporting(E_ALL);

...and add some more error-checking to the mysql_query:

function banner_stats($banner_id, $banner_location) {
   $update_banner = "INSERT INTO banner_stats (location, impressions, banner_id) VALUES('$banner_location',impressions + 1, $banner_id)"; 
   mysql_query($update_banner, $connection) or die(mysql_error() . "<br>Query: $update_banner");
   if(mysql_affected_rows() == 0)
   {
      user_error("Now rows updated. Query: $update_banner", E_USER_WARNING);
   }
} 

[cwilkey]

Here is what the error reports:

Notice: Undefined variable: .... on line 13.

Line 13 is mysql_query($update_banner, $connection) or die(mysql_error())

[NogDog]

The $connection variable is not defined in your function, so you either need to (a) pass it as another function parameter, (b) declare it as global within the function, or (c) just leave it out of the mysql_query() call if you only have one connection established in your script (and thus can just let it use that one by default).