www.webdeveloper.com
Results 1 to 3 of 3

Thread: Coldfusion Query / SQL Syntax Problem.

  1. #1
    Join Date
    May 2007
    Posts
    2

    Coldfusion Query / SQL Syntax Problem.

    Hey,
    I'm getting an error when i try and information to my access databse from my form. I'm knew to Coldfusion and SQL but i have searched high and low for the cause of my syntax error but no matter what i try i cant get it to work, so any help would be greatly appreciated.

    Here is the code:

    Code:
    <cfquery name="qInsert" datasource="A13060_13398620">
    
    INSERT INTO Listings
    
    (Price, Address, Status_ID, Suburb_ID, Bathrooms, Bedrooms, Comments,
    Pool, Fireplace, Garage, Laundry, )
    
    VALUES
    
    (#form.Price#, '#form.Address#', #form.Status_ID#, #form.Suburb_ID#,
    #form.Bathrooms#, #form.Bedrooms#, '#form.Comments#',
    
    <cfif isDefined("form.Pool") >
             'Yes'
    <cfelse>
              'No'
    </cfif>,
    
    <cfif isDefined("form.Fireplace") >
             'Yes'
    <cfelse>
              'No'
    </cfif>,
    
    <cfif isDefined("form.Garage") >
             'Yes'
    <cfelse>
              'No'
    </cfif>,
    
    <cfif isDefined("form.Laundry") >
             'Yes'
    <cfelse>
              'No'
    </cfif> )
    
    
    </cfquery>
    Basically the last four were checkboxes and i just want it to insert yes or no into the related record.

    Here are the datatypes in access:
    Price = Currency
    Address = Memo
    Status_ID = Number
    Suburb_ID = Number
    Bathrooms = Number
    Bedrooms = Number
    Comments = Memo
    Pool = Text
    Fireplace = Text
    Garage = Text
    Laundry = text

    And here is the error

    [Macromedia][SequeLink JDBC Driver][ODBC Socket][Microsoft][ODBC Microsoft Access Driver] Syntax error in INSERT INTO statement.


    Once again thanks

    Ben

  2. #2
    Join Date
    Dec 2006
    Location
    gold coast
    Posts
    34

    It is a syntax error

    <cfquery name="qInsert" datasource="A13060_13398620">

    INSERT INTO Listings

    (Price, Address, Status_ID, Suburb_ID, Bathrooms, Bedrooms, Comments,
    Pool, Fireplace, Garage, Laundry )

    VALUES

    (#form.Price#, '#form.Address#', #form.Status_ID#, #form.Suburb_ID#,
    #form.Bathrooms#, #form.Bedrooms#, '#form.Comments#',

    <cfif isDefined("form.Pool") >
    'Yes'
    <cfelse>
    'No'
    </cfif>,

    <cfif isDefined("form.Fireplace") >
    'Yes'
    <cfelse>
    'No'
    </cfif>,

    <cfif isDefined("form.Garage") >
    'Yes'
    <cfelse>
    'No'
    </cfif>,

    <cfif isDefined("form.Laundry") >
    'Yes'
    <cfelse>
    'No'
    </cfif> )


    </cfquery>


    That should work , but i won't recommend using cfif in the query statements, u would much rather cfset them before the query, but its ur call
    Last edited by GoldCoast_Nerd; 05-22-2007 at 07:23 PM.

  3. #3
    Join Date
    Jul 2007
    Location
    Tampa, FL
    Posts
    5

    You Left A Comma

    You left a an extra comma in the insert statement.

    Also, the query is too vunerable to hacking. Whenever using inline SQL you MUST use CFQUERYPARAM. An example on one of yours would be:
    <CFQUERYPARAM CFSQLTYPE="CF_SQL_INTEGER" MAXLENGTH="8" VALUE="#form.Price#">,

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.14429 seconds
  • Memory Usage 2,846KB
  • Queries Executed 13 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (1)bbcode_code
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (3)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (3)postbit
  • (3)postbit_onlinestatus
  • (3)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (70):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates