www.webdeveloper.com
Results 1 to 7 of 7

Thread: [RESOLVED] Simple if else not working. Please help!

  1. #1
    Join Date
    Jun 2008
    Posts
    207

    resolved [RESOLVED] Simple if else not working. Please help!

    Hi, Can anyone tell me why this is not working? I'm just trying to get a div to be made visible or hidden at the click of a link.

    <script language="JavaScript">
    function showhide()
    {
    var testvar = document.getElementById("mydiv").style.visibility
    if (testvar = "visible")
    {
    document.getElementById("mydiv").style.visibility = "hidden";
    }
    else
    {
    document.getElementById("mydiv").style.visibility = "visible";
    }
    }
    </script>


    <div id="mydiv" style="visibility:visible;">
    Blah blah blah...
    </div>

    <a href="javascript:showhide()">Click here to enable the element<a/>

  2. #2
    Join Date
    Apr 2003
    Location
    Netherlands
    Posts
    21,654
    compare:
    Code:
    if (testvar == "visible")
    At least 98% of internet users' DNA is identical to that of chimpanzees

  3. #3
    Join Date
    Jun 2008
    Posts
    207
    Thank you, and i'm a little embarrassed...

  4. #4
    Join Date
    Apr 2003
    Location
    Netherlands
    Posts
    21,654
    Code:
    <script  type="text/javascript">
    function showhide()
    {
    var testvar = document.getElementById("mydiv");
    testvar.style.visibility=(testvar.style.visibility == "visible")? "hidden" : "visible";
    }
    </script>
    At least 98% of internet users' DNA is identical to that of chimpanzees

  5. #5
    Join Date
    Jun 2008
    Posts
    207
    I have a problem: The first click on the checkbox doesn't change the visibility. You need to click twice for it to start working. Is there anyway to change this?

    <script language="JavaScript">
    function showhide()
    {
    var testvar = document.getElementById("mydiv").style.visibility
    if (testvar == "visible")
    {
    document.getElementById("mydiv").style.visibility = "hidden";
    }
    else
    {
    document.getElementById("mydiv").style.visibility = "visible";
    }
    }
    </script>

    <form>
    <input type="checkbox" id="show" onclick="showhide()" checked="checked"> Yes please send me an SMS reminder of the event<br>
    </form>


    <div id="mydiv">
    Mobile number form field
    </div>

  6. #6
    Join Date
    Apr 2003
    Location
    Netherlands
    Posts
    21,654
    It must be explicitly set in the div, else the visibility property returns "" empty:
    Code:
    <div id="mydiv" style="visibility:visible;">
    At least 98% of internet users' DNA is identical to that of chimpanzees

  7. #7
    Join Date
    Jun 2008
    Posts
    207
    Thanks Fang. You legend.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.13261 seconds
  • Memory Usage 2,891KB
  • Queries Executed 13 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (3)bbcode_code
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (7)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (7)postbit
  • (7)postbit_onlinestatus
  • (7)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (70):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates