Classes and Function Prototyping

[Taldos]

Hello all. I'm trying to work my way around creation of Objects and prototyping. First time I'm really trying to OOP route, and not resorting to simply using basic function.

Below is my class definition and prototype.

function user(){
    //Declaring Variables
    this.alias = "Sample Name";
}
user.prototype.getAlias = getAlias;
user.prototype.setAlias = setAlias;
function getAlias(){
    return this.alias;    
}
function setAlias = function(val){
    this.alias = val;
} 

Next I create a user array populated by xml. For each user I'm looking to instantiate the object, then proceed by calling the 'setAlias' method.

UserList = new Array();
<xsl:for-each select="UserList/User">
    UserList[<xsl:value-of select="position()-1"/>] = new user();
    var tmpFc = FcList[<xsl:value-of select="position()-1"/>];
    tmpFc.setAlias = "<xsl:value-of select="Alias"/>";
</xsl:for-each>
function TestObject(){
    alert(UserList[0].getAlias);
} 

When I make a call to the 'Test Object' function to see if the property is being correctly set. the function declartion is returned as a string. ie: the alert displays the following:

function(){
    return this.alias;    
} 

I would expect to get the property returned not the function declaration. I'm pretty certain I'm making a simple error, but I'm lost. Any help is appreciated at this point.

Thank you.

[hoangkc]

function TestObject(){
    alert(UserList[0].getAlias());
}

getAlias is method, not property

[Dok]

Some suggestions.

Start class names with uppercase letters to follow convention

function User(){ 
    //Declaring Variables 
    this.alias = "Sample Name"; 
}

You don't need to create global functions and later assign them. Instead of

user.prototype.getAlias = getAlias; 
function getAlias(){ 
    return this.alias;     
}

do

User.prototype.getAlias = function(){return this.alias;}

[Declan1991]

And if you have a lot of prototypes assign an object to the prototype.

User.prototype = {
getAlias:function() {
return this.alias;
},
setAlias:function(a) {
this.alias = a;
}
}

[Taldos]

Thx for the quick feedback. the "()" after the method call did the trick. the additional information on multiple method declaration and adhering to standards is much appreciated.

Cheers