hide() function always moves page back to top

[coldscooter]

Hi I am trying to use this code that was submitted on dreamincode.net. The trouble i am having is that the page will always go back to the top everytime i click the link. Does anyone know how i can prevent this from happening?

Thanks


<script type="text/javascript">

function hide(status) {

if (status == "hidden") {
document.getElementById("textbox").style.visibility = "hidden";
document.getElementById("button").innerHTML = "<a onclick=\"hide(\'show\')\" href=\"#\">Show Textbox<\/a>";
}
else {
document.getElementById("textbox").style.visibility = "visible";
document.getElementById("button").innerHTML = "<a onclick=\"hide(\'hidden\')\" href=\"#\">Hide Textbox<\/a>";
}

}

</script>

<textarea id="textbox"></textarea><br>

<span id="button">
<a onclick="hide('hidden')" href="#">Hide Textbox</a>
</span>

[gil davis]

<a onclick="hide('hidden');return false" href="#">Hide Textbox</a>

[coldscooter]

Hi, Thanks for the post. That works the first time you click it, but the second time will throw you back to the top of the page. Any ideas? Thanks

[toicontien]

Then the second time the hide() function is run, it must be encountering a JavaScript error. Can you post the source code for the hide() function?

[coldscooter]

function hide(status) {

if (status == "hidden") {
document.getElementById("textbox").style.visibility = "hidden";
document.getElementById("button").innerHTML = "<a onclick=\"hide(\'show\')\" href=\"#\">Show Textbox<\/a>";
}
else {
document.getElementById("textbox").style.visibility = "visible";
document.getElementById("button").innerHTML = "<a onclick=\"hide(\'hidden\')\" href=\"#\">Hide Textbox<\/a>";
}

}


Thanks for your help

[slaughters]

It's because he is over writing the span containing the link.

document.getElementById("button").innerHTML = "<a onclick=\"hide(\'hidden\')\" href=\"#\">Hide Textbox<\/a>";

Add the return false there as well.

[coldscooter]

Ah i can see where it is going wrong. Each time it's clicked it changes the html for the button and the second time it does not include the "return false". It is now sorted. Thanks for your time and help.