www.webdeveloper.com
Results 1 to 5 of 5

Thread: Need help with a Basic Calculator

  1. #1
    Join Date
    Feb 2009
    Posts
    30

    Need help with a Basic Calculator

    I am in a Java script class and I need a littel help.

    My teacher want me to make a calculator. with three textboxes and 3 radio buttons.

    1) In the first textbox you put a number
    2) Then select on of the radio buttons +,x or -.
    3) Then you put another number in the second textbox.
    4) You press the = button and the ansour apears in the 3rd texbox.


    Here is what I came up with so far.



    <script type="text/javascript">

    function multipier(){
    var x=document.getElementById("tb1").value
    var y=document.getElementById("tb2").value

    }

    function subtracter(){
    var a=document.getElementById("tb1").value
    var b=document.getElementById("tb2").value
    document.getElementById("tb3").value=a -b
    }


    function adder(){
    var c=document.getElementById("tb1").value
    var d=document.getElementById("tb2").value
    document.getElementById("tb3").value=c +d
    }

    function divide(){
    var e=document.getElementById("tb1").value
    var f=document.getElementById("tb2").value
    document.getElementById("tb3").value=e /f
    }

    function evalit(){
    document.form1.box1.value=eval(document.form1.box1.value)
    document.getElementById("tb3").value=x *y
    }

    </script>


    <BODY>

    <form name="form1">

    <input type="text"size="2" id="tb1"/>

    <br/><input type="radio" name="r" value="*" onClick="multipier()"/>*
    <br/><input type="radio" name="r" value="-" onClick="subtracter()"/>-
    <br/><input type="radio" name="r" value="+" onClick="adder()"/>+
    <br/><input type="radio" name="r" value="/" onClick="divide()"/>/
    <input type="text"size="2" id="tb2"/>
    <input type="button" value="=" name="eq" onClick="evalit()">
    <input type="text"size="2" name="box1" id="tb3"/>

    </form>


    </BODY>
    </HTML>

  2. #2
    Join Date
    Dec 2005
    Location
    TX
    Posts
    7,943

    Lightbulb

    Because JS works with strings from input, not numbers
    Use parseFloat for each value input

    OR
    Multiply each input value by 1 to convert to number.
    Example:
    Code:
    function multipier(){
      var x=document.getElementById("tb1").value * 1;
      var y=document.getElementById("tb2").value * 1;
      document.getElementById("tb3").value=x * y;
    }
    Also not that division by zero is illegal, so you might want to check for that.
    And, users sometimes do not type correctly, so may want to check isNaN().

  3. #3
    Join Date
    Feb 2009
    Posts
    30
    Thanks JMRKER.

    The real problem I am having is that I don't want the anser to go in the text box until I press the = button. I would like to do this with the aval function in the = button.
    Or is there a better way?

  4. #4
    Join Date
    Dec 2005
    Location
    TX
    Posts
    7,943

    Lightbulb

    Simplified to match your code ...
    Code:
    <HTML>
    <head>
    <title>Simple Calculator</title>
    
    <script type="text/javascript">
    var ans = 0;
    
    function calc(action){
      var x=document.getElementById("tb1").value * 1;
      var y=document.getElementById("tb2").value * 1;
      switch (action) {
        case '+' : ans = x+y;  break;
        case '-' : ans = x-y;  break;
        case '*' : ans = x*y;  break;
        case '/' : ans = x/y;  break;  // still need division by zero check
        default : alert(action+' is invalid operation');
      }
    }
    
    function evalit(){
      document.getElementById("tb3").value= ans;
    }
    
    </script>
    </head>
    
    <BODY>
    
    <form name="form1">
    
    <input type="text"size="2" id="tb1"/>
    
    <br/><input type="radio" name="r" value="*" onClick="calc(this.value)"/>*
    <br/><input type="radio" name="r" value="-" onClick="calc(this.value)"/>-
    <br/><input type="radio" name="r" value="+" onClick="calc(this.value)"/>+
    <br/><input type="radio" name="r" value="/" onClick="calc(this.value)"/>/
    <br/>
    <input type="text"size="2" id="tb2"/>
    <br />
    <input type="button" value="=" name="eq" onClick="evalit()">
    <input type="text"size="2" name="box1" id="tb3"/>
    
    </form>
    
    </BODY>
    </HTML>

  5. #5
    Join Date
    Feb 2009
    Posts
    30
    Thanks JMRKER.

    The works great

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.13105 seconds
  • Memory Usage 2,882KB
  • Queries Executed 15 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (2)bbcode_code
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (5)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (5)postbit
  • (5)postbit_onlinestatus
  • (5)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (70):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates