www.webdeveloper.com
Results 1 to 3 of 3

Thread: trouble creating an external JS file

  1. #1
    Join Date
    Jun 2008
    Posts
    9

    trouble creating an external JS file

    I have a form with a validation script that works when it is in the <head> of the document but not when I relocate it to an external file. This is what I have in the <head> of the doc:
    Code:
    <script language="JavaScript" type="text/javascript">
    <!--
    function checkform ( form )
    {
    
      if	((form.requestType[0].checked == false )
    		&& (form.requestType[1].checked == false)
    		&& (form.requestType[2].checked == false))
    	{
    		alert ("Please choose a data request type");
    		form.requestType[0].focus();
    		return false ;
    	}
    }
    //-->
    And in the body:
    Code:
    <form id="dataRequest" name="f1" action="" enctype="multipart/form-data" method="POST" onsubmit="return checkform(this);">
    The JavaScript file that I created is simply this:
    Code:
    function checkform ( form )
    {
    
      if	((form.requestType[0].checked == false )
    		&& (form.requestType[1].checked == false)
    		&& (form.requestType[2].checked == false))
    	{
    		alert ("Please choose a data request type");
    		form.requestType[0].focus();
    		return false ;
    	}
    }
    And I called for it as such:
    Code:
    <script language="javascript" type="text/javascript" src="/includes/javaScript/validation.js"></script>
    The code works fine embedded in the page but not as an external file. I'm sure that there is a simple syntax issue that I'm missing but I can't figure it out. Any help is appreciated.

    Thanks,
    Todd

  2. #2
    Join Date
    Jan 2007
    Location
    Wisconsin
    Posts
    2,120
    I'm pretty sure the following is redundant:
    HTML Code:
    ... language="javascript" type="text/javascript" ...
    I don't think that will prevent your script from working though. You should really just check your browser's error-log to see what's going on. I'd load the page in Firefox and check the error-log there, if I were you.

    Edit:
    I tend not to use the language attribute anymore (just the type attribute). Though, I seem to recall the language attribute being case-sensitive. Is it possible that your browser is thrown by the uncapitalized language in the external version?
    Last edited by svidgen; 06-18-2009 at 09:47 AM.
    Jon Wire

    thepointless.com | rounded corner generator

    I agree with Apple. Flash is just terrible.

    Use CODE tags!

  3. #3
    Join Date
    Dec 2005
    Location
    TX
    Posts
    7,931
    Don't know if this will help, but needs to be asked:

    1. You do remove the redundant code in the <HEAD> section when calling the external version?

    2. The external file is located in the directory path specified? And spelled correctly?

    3. If on a server, you have set the permissions of the external file so that it is readable?
    I typically use permissions of '664' or '644' on my unix server.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.30066 seconds
  • Memory Usage 2,864KB
  • Queries Executed 15 (?)
More Information
Template Usage (34):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (4)bbcode_code
  • (1)bbcode_html
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (3)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (3)postbit
  • (3)postbit_onlinestatus
  • (3)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (70):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates