Variable contents in html :S

[javawizkid]

I seem to have a problem with my javascript code. What I want to do is make the last line of code alert out the value of a html checkbox name which has been dynamically made in javascript. It is trying to look for prechecksub in the html but I want to the value of prechecksub and insert it into the alert if this makes sense. Probably not

function catboxclick(cat)
{
	alert("catboxclick called");
	
		var prechecksub = "checksub" + cat;
		alert(prechecksub);
	alert(document.catcheckboxes.checkcatgroup.length);
	alert(document.catcheckboxes.checksub0.length);
	
	alert(document.catcheckboxes.prechecksub.length); // this doesnt work, there is no such html element as prechecksub, it is made in JS.
}

[Kor]

I seem to have a problem with my javascript code. What I want to do is make the last line of code alert out the value of a html checkbox name which has been dynamically made in javascript.

Made how? Can we see the way you have created and appended that checkbox?

[javawizkid]

for (cat = 0; cat < category.length; ++cat)
	{
		html += '<div class="mH"><input type="checkbox" name ="checkcatgroup" checked onclick="catboxclick(' + cat + ')" /><div class="mH" onclick="toggleMenu' + "('menu" + cat + "')" +'">&#177 ' + category[cat] + '<br/></div></div>';
		html += '<div id="menu' + cat + '" class="mL">';
			for (sub = 0; sub < subcategory[cat].length; ++sub)
			{
			html += '<div class="mO"><input type="checkbox" name="checksub'  + cat + '" checked onclick="subboxclick('+ cat +',' + sub + ')" />' + subcategory [cat] [sub] +'<br/></div>';
			}
		html += '</div>';	
		}
		html += '</div></form>';
	
	
	document.getElementById("infobox").innerHTML = html;

[Kor]

innerHTML is not a standard DOM method, thus it might not insert quite well the new elements or their attributes into the DOM tree. I would have rather use DOM standard methods to create and append a new element (createElement(), setAttribute() and so on)

On the other hand, you may try something else: in case of a single radio or checkbox element referenced by name, the classical reference (document.formname.elementname) could fail. Try first the DOM 1+ method:

document.getElementsByName('prechecksub')[0]

Keep in mind that getElementsByName() method is to be used only upon form's elements (well, it works upon images, frames and links as well, but I woun't bet on the future of) and will return always a collection (that means you always need an index to point a certain element)

[javawizkid]

Not quite sure what you mean.

Like this:

document.catcheckboxes.getElementByname('prechecksub').length

[Kor]

Not quite sure what you mean.

Like this:

document.catcheckboxes.getElementByname('prechecksub').length

Nope.Try:

document.getElementsByName('prechecksub').length

[javawizkid]

Yes that works, but it returns a value of 0 and not 10. :S

My bad, forgot the form name. Thanks all working now!

Nope, still not working.

[Kor]

give as the link to the test page.

[javawizkid]

http://jacksononline.co.uk/treetest/test