preg_match_all problem

[kingdm]

Hello everyone.

I've been playing a lot of time experimenting on this preg_match_all. I have a problem regarding my preg_match_all to accept a "newline" or Enter. I tried to put \r\n still no luck. What am I missing?

if(preg_match_all('/[^a-z0-9~\.,$ñ\s-\(\)!@#]/i', $announcement_post, $invalid)) 

[NogDog]

Not sure if this has anything to do with the stated problem, but I suspect you want to escape the hyphen right after the "\s", as I'm assuming you want a literal hyphen there ("\-").

In any case, the newline and carriage return characters should be included in your "\s" character type, though the '\r\n' characters should also work.

[kingdm]

Not sure if this has anything to do with the stated problem, but I suspect you want to escape the hyphen right after the "\s", as I'm assuming you want a literal hyphen there ("\-").

In any case, the newline and carriage return characters should be included in your "\s" character type, though the '\r\n' characters should also work.

Thanks for your reply NogDog.

You're right I want to have a literal hyphen so I changed "\s-" into "\s\-". My only problem is the newline. My textarea won't accept it, say my input is:

The quick brownfox.

And the lazy dog.

The preg_match_all script I have invalidates this and returns a value of:

The quick brownfox.\r\n\r\nAnd the lazy dog.

[kingdm]

Not sure if this has anything to do with the stated problem, but I suspect you want to escape the hyphen right after the "\s", as I'm assuming you want a literal hyphen there ("\-").

In any case, the newline and carriage return characters should be included in your "\s" character type, though the '\r\n' characters should also work.

Thanks for your reply NogDog.

You're right I want to have a literal hyphen so I changed "\s-" into "\s\-". My only problem is the newline. My textarea won't accept it, say my input is:

The quick brownfox.

And the lazy dog.

The preg_match_all script I have invalidates this and returns a value of:

The quick brownfox.\r\n\r\nAnd the lazy dog.

[SrWebDeveloper]

if(preg_match_all('#[^a-z0-9~\.,$ñ\s\-\(\)!@\#]|[\r\n]#im', $announcement_post, $invalid)) 

Not sure what you want, but this checks if any of those chars you originally checked for via the starts with/end with sequence OR any instance of \r or \n anywhere. I also used # delimiter to reduce the escaping and also added m pattern modifier on the end for multi-line parsing. Even if this isn't what you want, you can probably more easily make changes now.

-jim

[NogDog]

if(preg_match_all('#[^a-z0-9~\.,$ñ\s\-\(\)!@\#]|[\r\n]#im', $announcement_post, $invalid)) 

Not sure what you want, but this checks if any of those chars you originally checked for via the starts with/end with sequence OR any instance of \r or \n anywhere. I also used # delimiter to reduce the escaping and also added m pattern modifier on the end for multi-line parsing. Even if this isn't what you want, you can probably more easily make changes now.

-jim

I was assuming that since the first character class is negated, it is listing all allowed characters, so the "\r\n" would be included within it:

'/[^a-z0-9~\.,$ñ\s\-\(\)!@#\r\n]/i' 

[kingdm]

Thanks for your reply. Your suggestion works, however, I see the real problem is on my cleanString function.

$announcement_post = cleanString($_POST['announcement_post']); 

When I try to make it in like this:

$announcement_post = $_POST['announcement_post']; 

The preg_match_all works as you suggested.

This is the cleanString code:

function cleanString($str, $encode_ent = false) {
    $str  = @trim($str);
    if($encode_ent) {
        $str = htmlentities($str);
    }
    if(version_compare(phpversion(),'4.3.0') >= 0) {
        if(get_magic_quotes_gpc()) {
            $str = stripslashes($str);
        }
        if(@mysql_ping()) {
            $str = mysql_real_escape_string($str);
        }
        else {
            $str = addslashes($str);
        }
    }
    else {
        if(!get_magic_quotes_gpc()) {
            $str = addslashes($str);
        }
    }
    return $str;
} 

Can you suggest of revision in this cleanString that would work on this matter?