www.webdeveloper.com
Results 1 to 7 of 7

Thread: preg_match_all problem

  1. #1
    Join Date
    Dec 2009
    Location
    City of Smiles
    Posts
    172

    preg_match_all problem

    Hello everyone.

    I've been playing a lot of time experimenting on this preg_match_all. I have a problem regarding my preg_match_all to accept a "newline" or Enter. I tried to put \r\n still no luck. What am I missing?

    PHP Code:
    if(preg_match_all('/[^a-z0-9~\.,$\s-\(\)!@#]/i'$announcement_post$invalid)) 
    Can't stand long hours coding in front of computer without being intoxicated.

  2. #2
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,287
    Not sure if this has anything to do with the stated problem, but I suspect you want to escape the hyphen right after the "\s", as I'm assuming you want a literal hyphen there ("\-").

    In any case, the newline and carriage return characters should be included in your "\s" character type, though the '\r\n' characters should also work.
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  3. #3
    Join Date
    Dec 2009
    Location
    City of Smiles
    Posts
    172
    Quote Originally Posted by NogDog View Post
    Not sure if this has anything to do with the stated problem, but I suspect you want to escape the hyphen right after the "\s", as I'm assuming you want a literal hyphen there ("\-").

    In any case, the newline and carriage return characters should be included in your "\s" character type, though the '\r\n' characters should also work.
    Thanks for your reply NogDog.

    You're right I want to have a literal hyphen so I changed "\s-" into "\s\-". My only problem is the newline. My textarea won't accept it, say my input is:

    Code:
    The quick brownfox.
    
    And the lazy dog.
    The preg_match_all script I have invalidates this and returns a value of:

    The quick brownfox.\r\n\r\nAnd the lazy dog.
    Can't stand long hours coding in front of computer without being intoxicated.

  4. #4
    Join Date
    Dec 2009
    Location
    City of Smiles
    Posts
    172
    Quote Originally Posted by NogDog View Post
    Not sure if this has anything to do with the stated problem, but I suspect you want to escape the hyphen right after the "\s", as I'm assuming you want a literal hyphen there ("\-").

    In any case, the newline and carriage return characters should be included in your "\s" character type, though the '\r\n' characters should also work.
    Thanks for your reply NogDog.

    You're right I want to have a literal hyphen so I changed "\s-" into "\s\-". My only problem is the newline. My textarea won't accept it, say my input is:

    Code:
    The quick brownfox.
    
    And the lazy dog.
    The preg_match_all script I have invalidates this and returns a value of:

    The quick brownfox.\r\n\r\nAnd the lazy dog.
    Can't stand long hours coding in front of computer without being intoxicated.

  5. #5
    Join Date
    Jul 2009
    Location
    Falls Church, Va.
    Posts
    780
    PHP Code:
    if(preg_match_all('#[^a-z0-9~\.,$ñ\s\-\(\)!@\#]|[\r\n]#im'$announcement_post$invalid)) 
    Not sure what you want, but this checks if any of those chars you originally checked for via the starts with/end with sequence OR any instance of \r or \n anywhere. I also used # delimiter to reduce the escaping and also added m pattern modifier on the end for multi-line parsing. Even if this isn't what you want, you can probably more easily make changes now.

    -jim

  6. #6
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,287
    Quote Originally Posted by SrWebDeveloper View Post
    PHP Code:
    if(preg_match_all('#[^a-z0-9~\.,$\s\-\(\)!@\#]|[\r\n]#im'$announcement_post$invalid)) 
    Not sure what you want, but this checks if any of those chars you originally checked for via the starts with/end with sequence OR any instance of \r or \n anywhere. I also used # delimiter to reduce the escaping and also added m pattern modifier on the end for multi-line parsing. Even if this isn't what you want, you can probably more easily make changes now.

    -jim
    I was assuming that since the first character class is negated, it is listing all allowed characters, so the "\r\n" would be included within it:
    PHP Code:
    '/[^a-z0-9~\.,$\s\-\(\)!@#\r\n]/i' 
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  7. #7
    Join Date
    Dec 2009
    Location
    City of Smiles
    Posts
    172
    Thanks for your reply. Your suggestion works, however, I see the real problem is on my cleanString function.

    PHP Code:
    $announcement_post cleanString($_POST['announcement_post']); 
    When I try to make it in like this:

    PHP Code:
    $announcement_post $_POST['announcement_post']; 
    The preg_match_all works as you suggested.

    This is the cleanString code:
    PHP Code:
    function cleanString($str$encode_ent false) {
        
    $str  = @trim($str);
        if(
    $encode_ent) {
            
    $str htmlentities($str);
        }
        if(
    version_compare(phpversion(),'4.3.0') >= 0) {
            if(
    get_magic_quotes_gpc()) {
                
    $str stripslashes($str);
            }
            if(@
    mysql_ping()) {
                
    $str mysql_real_escape_string($str);
            }
            else {
                
    $str addslashes($str);
            }
        }
        else {
            if(!
    get_magic_quotes_gpc()) {
                
    $str addslashes($str);
            }
        }
        return 
    $str;

    Can you suggest of revision in this cleanString that would work on this matter?
    Last edited by kingdm; 01-17-2010 at 06:39 AM. Reason: typo
    Can't stand long hours coding in front of computer without being intoxicated.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.30437 seconds
  • Memory Usage 2,933KB
  • Queries Executed 15 (?)
More Information
Template Usage (35):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (2)bbcode_code
  • (7)bbcode_php
  • (3)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (7)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (7)postbit
  • (7)postbit_onlinestatus
  • (7)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (70):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • bbcode_parse_start
  • postbit_imicons
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates