Text not being displayed after calling a function. Easy problem, please help!

**JavaNoobz** · 11-02-2009 10:07 PM

I'm coding a simple random sentence generator & this is the beginning part of what I'm trying to accomplish.

I created 3 different functions with 3 separate buttons & 3 separate text areas to display the noun, verb, or article once the button is pressed.

However, when I press a button, nothing shows up in the text area! Can someone please tell me what I'm doing wrong & give me a fix? It has to be a simple problem, but I am very very new to this & need help. Thanks in advance!

Code:

<?xml version="1.0" encoding="ISO-8859-1"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">


<head>

<script language="JavaScript">

    function noun()
    // Assumes: nothing
    // Returns: a random noun
    {
        return RandomOneOf(["man", "woman", "ball"]);
    }

</script>


<script language="JavaScript">

    function verb()
    // Assumes: nothing
    // Returns: a random noun
    {
        return RandomOneOf(["hit", "liked", "smelled"]);
    }

</script>


<script language="JavaScript">

    function article()
    // Assumes: nothing
    // Returns: a random noun
    {
        return RandomOneOf(["the", "a", "some"]);
    }

</script>

</head>

<body>


<input type="button" value="Noun"
           onclick="document.getElementById('OutNoun').value = noun();" />

<TEXTAREA ID="OutNoun" ROWS=1 COLS=15 WRAP VALUE=""></TEXTAREA> 



<input type="button" value="Verb"
           onclick="document.getElementById('OutVerb').value = verb();" />

<TEXTAREA ID="OutVerb" ROWS=1 COLS=15 WRAP VALUE=""></TEXTAREA> 



<input type="button" value="Article"
           onclick="document.getElementById('OutArticle').value = article();" />

<TEXTAREA ID="OutArticle" ROWS=1 COLS=15 WRAP VALUE=""></TEXTAREA> 






</body>
</html>

**JMRKER** · 11-02-2009 10:19 PM

You can combine all three <script...> sections into one
<script type="text/javascript">
// your code
</script>
But I do not see where you have RandomOneOf() function defined.

Probably failing because it cannot find the function.
What kind of errors are you getting in error console if using FF
or any kind of alert message using MSIE browser?

**JMRKER** · 11-02-2009 10:32 PM

Assuming I have added the missing function correctly...
Try this:

Code:

<?xml version="1.0" encoding="ISO-8859-1"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>

<script type="text/javascript">
// From: http://www.webdeveloper.com/forum/showthread.php?p=1045646#post1045646

function RandomOneOf(arr) {  // alert(arr.join('\n'));
  var cnt = arr.length;
  var rnd = Math.floor(Math.random() * cnt);
  return arr[rnd];
}

function noun() {
// Assumes: nothing
// Returns: a random noun
  return RandomOneOf(["man", "woman", "ball"]);
}

function verb() {
// Assumes: nothing
// Returns: a random noun
  return RandomOneOf(["hit", "liked", "smelled"]);
}

function article() {
// Assumes: nothing
// Returns: a random noun
  return RandomOneOf(["the", "a", "some"]);
}

</script>
</head>

<body>
<input type="button" value="Noun"
           onclick="document.getElementById('OutNoun').value = noun();" />
<TEXTAREA ID="OutNoun" ROWS=1 COLS=15 WRAP VALUE=""></TEXTAREA> 
<input type="button" value="Verb"
           onclick="document.getElementById('OutVerb').value = verb();" />
<TEXTAREA ID="OutVerb" ROWS=1 COLS=15 WRAP VALUE=""></TEXTAREA> 
<input type="button" value="Article"
           onclick="document.getElementById('OutArticle').value = article();" />
<TEXTAREA ID="OutArticle" ROWS=1 COLS=15 WRAP VALUE=""></TEXTAREA> 

</body>
</html>

**JavaNoobz** · 11-02-2009 10:39 PM

Thank you for the replies! I am following a set of guidelines (its a project for school) & was supposed to link an external javascript file into the code. I feel pretty stupid, but your help was greatly appreciated. I also got rid of the extra <script> tags.

**studentj** · 01-23-2010 05:26 PM

If I wanted to create a function called "sentence" that called each of the three previous functions in order to generate a random sentence with the form "article"+"noun"+verb", how would I do that?

**JMRKER** · 01-23-2010 07:11 PM

Code:

function sentence() {
  return article()+' '+noun()+' '+verb();
}

Thread: Text not being displayed after calling a function. Easy problem, please help!

Thread Tools

Display

Text not being displayed after calling a function. Easy problem, please help!

Missing some code ...

Consider this ...

Thread Information

Users Browsing this Thread

Bookmarks

Bookmarks

Posting Permissions