www.webdeveloper.com
Results 1 to 9 of 9

Thread: Javascript - How to make it external?

  1. #1
    Join Date
    Oct 2009
    Posts
    44

    Javascript - How to make it external?

    Could anyone help me in making the following Javascript external?

    ------
    <script type="text/JavaScript">
    <!--
    function MM_preloadImages() { //v3.0
    var d=document; if(d.images){ if(!d.MM_p) d.MM_p=new Array();
    var i,j=d.MM_p.length,a=MM_preloadImages.arguments; for(i=0; i<a.length; i++)
    if (a[i].indexOf("#")!=0){ d.MM_p[j]=new Image; d.MM_p[j++].src=a[i];}}
    }

    function MM_swapImgRestore() { //v3.0
    var i,x,a=document.MM_sr; for(i=0;a&&i<a.length&&(x=a[i])&&x.oSrc;i++) x.src=x.oSrc;
    }

    function MM_findObj(n, d) { //v4.01
    var p,i,x; if(!d) d=document; if((p=n.indexOf("?"))>0&&parent.frames.length) {
    d=parent.frames[n.substring(p+1)].document; n=n.substring(0,p);}
    if(!(x=d[n])&&d.all) x=d.all[n]; for (i=0;!x&&i<d.forms.length;i++) x=d.forms[i][n];
    for(i=0;!x&&d.layers&&i<d.layers.length;i++) x=MM_findObj(n,d.layers[i].document);
    if(!x && d.getElementById) x=d.getElementById(n); return x;
    }

    function MM_swapImage() { //v3.0
    var i,j=0,x,a=MM_swapImage.arguments; document.MM_sr=new Array; for(i=0;i<(a.length-2);i+=3)
    if ((x=MM_findObj(a[i]))!=null){document.MM_sr[j++]=x; if(!x.oSrc) x.oSrc=x.src; x.src=a[i+2];}
    }
    //-->
    </script>
    ------
    The page can be seen live at:
    www.laurelsfurniture.com/torrance.html

    I know this is a very basic question, but I tried doing it myself and the page didn't function properly, so I uploaded the older version.

    Thanks!

  2. #2
    Join Date
    Jul 2008
    Location
    urbana, il
    Posts
    2,787
    just paste the code into a new text file, save it as something.js, and link to something.js at the bottom of your body tag using a <script> tag...

  3. #3
    Join Date
    Jan 2010
    Posts
    24
    Quote Originally Posted by rnd me View Post
    just paste the code into a new text file, save it as something.js, and link to something.js at the bottom of your body tag using a <script> tag...
    what he said but to add to it

    <script src="FILE URL HERE" type="text/javascript">
    //<![CDATA[

    //]]>
    </script>

  4. #4
    Join Date
    Jul 2008
    Location
    urbana, il
    Posts
    2,787
    Quote Originally Posted by MrEnder View Post
    what he said but to add to it

    <script src="FILE URL HERE" type="text/javascript">
    //<![CDATA[

    //]]>
    </script>
    No.

    there is no reason to do that.

  5. #5
    Join Date
    Jan 2010
    Posts
    24
    Quote Originally Posted by rnd me View Post
    No.

    there is no reason to do that.
    You need a src for it to work and a type for it to validate and rule of thumb is put in the CDATA so ya like I said.

    Dont be lazy

  6. #6
    Join Date
    Jul 2008
    Location
    urbana, il
    Posts
    2,787
    Quote Originally Posted by MrEnder View Post
    You need a src for it to work and a type for it to validate and rule of thumb is put in the CDATA so ya like I said.

    Dont be lazy
    i would amputate that last thumb...

    you only need cdata for the case of backwards compatibility with xhtml when using javascript code which contains xml literals like ">", and "&&" inside the HTML document .

    i recommend placing all javascript in external tags, especially with XHTML, so that these literals never have an XML context.

    at any rate, you certainly don't need to add anything to the middle of an external script tag; that's just a waste of bytes that gains absolutely nothing for anyone.

  7. #7
    Join Date
    Aug 2007
    Posts
    3,767
    Quote Originally Posted by MrEnder View Post
    A type for it to validate.
    And for an external JavaScript there is no point in a type because it is determined by the MIME type anyway.
    Great wit and madness are near allied, and fine a line their bounds divide.

  8. #8
    Join Date
    Jul 2008
    Location
    urbana, il
    Posts
    2,787
    Quote Originally Posted by Declan1991 View Post
    And for an external JavaScript there is no point in a type because it is determined by the MIME type anyway.
    No, the mimeType is ignored. I serve my scripts as text/html so that browsing to the script provides a richer text view/clickable links. Some libraries like jQuery check the type if they pull the script file using ajax, but it doesn't matter to <script> tags.

    As far as i know, javascript is the default/only scripting language widely supported. That means unless you care about validation, you can omit the "type='text/javascript'", which the HTML spec demands.

  9. #9
    Join Date
    Oct 2009
    Posts
    44

    Thumbs up resolved

    Thanks guys! I've taken your advice and now it's working great.

    http://www.laurelsfurniture.com/torrance.html

Thread Information

Users Browsing this Thread

There are currently 2 users browsing this thread. (0 members and 2 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center



Recent Articles