www.webdeveloper.com
Results 1 to 7 of 7

Thread: Please help with this javascript slideshow bug

Threaded View

  1. #1
    Join Date
    Sep 2008
    Posts
    7

    Question Please help with this javascript slideshow bug

    Hi,

    In the slide show code below, there's a function to press "previous" and "next" links. The "next" one works fine, and if you keep pressing it, it cycles through all the slides.

    The "previous" one is a bit messed up, for some reason - it will go back a slide or two but then it will just go blank!

    Could you please help?
    Thank you!

    Code:
    <script type="text/javascript">
            start_slideshow(1, 3, 3000);
    
            var currentSlide = 1;
    
            function start_slideshow(start_frame, end_frame, delay) {
                id = setTimeout(switch_slides(start_frame,start_frame,end_frame, delay), delay);
            }
    
            function switch_slides(frame, start_frame, end_frame, delay) {
                
                return (function() {
                                 
                    Effect.Fade('slide' + frame, { duration: 1.0 });
                    
                    if (frame == end_frame) {
                        frame = start_frame; 
                        currentSlide = frame;
                    } else {
                        frame = frame + 1; 
                        currentSlide = frame;
                    }
                    
                    Effect.Appear('slide' + frame, { duration: 1.0 });
                    
                    if (delay == 1000) {
                        delay = 3000; 
                    }
                    
                    id = setTimeout(switch_slides(frame, start_frame, end_frame, delay), delay);
                })
            }
    
            function stop_slideshow() {
                clearTimeout(id);
            }
            
            function next_slide() {
                
                clearTimeout(id);
    
                Effect.Fade('slide' + currentSlide, { duration: 1.0 });
                
                if (currentSlide == 4) {
                    currentSlide = 0;
                }
                
                currentSlide = currentSlide + 1;
                Effect.Appear('slide' + currentSlide, { duration: 1.0 });
                id = setTimeout(switch_slides(currentSlide, currentSlide, currentSlide, delay), delay);
            }
            
            function previous_slide() {
                
                clearTimeout(id);
                
                if (currentSlide == 0) {
                    currentSlide = 1;
                } else {
                  Effect.Fade('slide' + currentSlide, { duration: 1.0 });
                  
                  currentSlide = currentSlide - 1;
                  Effect.Appear('slide' + currentSlide, { duration: 1.0 });
                  id = setTimeout(switch_slides(currentSlide, currentSlide, currentSlide, delay), delay);
                }
            }
            
        </script>
    The previous/next links are like this:

    Code:
    <a href="#" onclick="next_slide()">Next</a>
    <a href="#" onclick="previous_slide()">Previous</a>
    Last edited by lisali; 01-29-2010 at 08:46 AM.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.18715 seconds
  • Memory Usage 3,179KB
  • Queries Executed 14 (?)
More Information
Template Usage (31):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (4)bbcode_code
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (7)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (7)postbit
  • (7)postbit_onlinestatus
  • (7)postbit_wrapper
  • (1)showthread_list
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (27):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./includes/functions_threadedmode.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (74):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids_threaded
  • showthread_threaded_construct_link
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates