www.webdeveloper.com
Results 1 to 6 of 6

Thread: foreach Statement error

  1. #1
    Join Date
    Apr 2009
    Posts
    107

    foreach Statement error

    I am getting an error from a foreach statement, not sure why, here is the code:
    PHP Code:
    $new_prod_id $count 100;

    function 
    arrayQuery($f_prod_id,$table

       
    $sql=mysql_query("SELECT * FROM $table WHERE prod_id='$f_prod_id'"); 
       if(
    mysql_num_rows($sql)) 
       { 
          return(
    mysql_fetch_assoc($sql)); // use fetch_assoc 
       

       return 
    false


    function 
    createSpec($f_desc,$f_step_num,$f_prod_id) {
        
    $sql=mysql_query("INSERT INTO specs (descriptor,num,prod_id) VALUES ('$f_desc','$f_step_num','$f_prod_id')") or die (mysql_error());
    }

    $spec=arrayQuery($type,"specs");    
        
        
    $i=0

        
    foreach($spec['descriptor'] as $descriptor) {
            
    createSpec($spec['descriptor'],[$i],$new_prod_id);
            
    $i++;
        } 
    "descriptor" is a column in the specs DB.

    I am trying to write 27 rows in the specs database from a template created. I get the values using "$spec=arrayQuery($type,"specs");" and then I want to loop for each array value and create a new row in the specs DB.

    This is the error I am getting:"Parse error: syntax error, unexpected T_FOREACH in"

    Any help would be greatly appreciated.
    Last edited by themonkey40; 02-11-2010 at 01:03 AM.

  2. #2
    Join Date
    Feb 2010
    Posts
    5
    you need to put a semi colon after your $i variable is setup

    $i=0(semicolon)

    $i=0;

  3. #3
    Join Date
    Sep 2004
    Posts
    10
    A couple things. $spec could be false. You can't run foreach on a boolean, so you may want to check that.

    Secondly, $spec is a 1-dimensional array (assoc). $spec['descriptor'] is just a single element of the array. I may be missing something, but running foreach over one element is a bit wordy.

    Oh, and the semicolon is missing in the previous line.


    --Dave

  4. #4
    Join Date
    Apr 2009
    Posts
    107
    Hampster, do you have a better piece of code I can use. Basically I can't get the loop to run. I fixed the semicolon (late night mistake).

    When I run the script now, I get an error that there is an unexpected [.
    PHP Code:
    $i=0;

        foreach(
    $spec['descriptor'] as $descriptor) {
            
    createSpec($spec['descriptor'],[$i],$new_prod_id);
            
    $i++;
        } 
    What I want to do here is run the loop every time there is a $spec['descriptor'] and write a new line in the database.

  5. #5
    Join Date
    Jan 2009
    Location
    Ohio
    Posts
    3,356
    You are probably looking for:
    while($row = mysql_fetch_assoc($mysql_resource)){

    This would change your function a bit as well...
    PHP Code:
    function arrayQuery($f_prod_id,$table)
    {
       
    $sql=mysql_query("SELECT * FROM $table WHERE prod_id='$f_prod_id'");
       if(!
    $sql){
          
    //query failed;
          
    return false;
       }
       if(
    mysql_num_rows($sql) != 0)
       {
          return(
    $sql); // use fetch_assoc
       
    }
       return 
    false;

    ...
    PHP Code:
    $spec=arrayQuery($type,"specs");    
        
        
    $i=0

        
    while($row mysql_fetch_assoc($spec)) {
            
    //not sure how this will affect your other code as I didn't look
            //this should give you a starting point for what you need
            //createSpec($row['descriptor'],[$i],$new_prod_id);
            
    echo "Row: ".$i."; "$row['descriptor']."<br />";
            
    $i++;
        } 

  6. #6
    Join Date
    Apr 2009
    Posts
    107
    Thanks again criterion9. I used the while statement and it worked.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.18241 seconds
  • Memory Usage 2,905KB
  • Queries Executed 15 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (4)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (6)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (6)postbit
  • (6)postbit_onlinestatus
  • (6)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (73):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates