1. Registered User
Join Date
Mar 2010
Posts
1

Hi All,

I need to change my coding so that it only converts numbers from 1-50 but cannot get it to work as my code allows users to type in numbers above this and it produces a number. Please can you help??

function converter(e){
var t = drawNumerals;
var a = [[50,'L'],
[40,'XL'],[10,'X'],
[9,'IX'],[5,'V'],[4,'IV'],[1,'I']];
for (var i = 0; i < a.length; i++){
while (e - a[i][0] >= 0){
t(a[i][1]);
if (a[i].length == 3){
t(a[i][2]);
}
e -= a[i][0];
}
}
}

Thanks Israa

2. Registered User+
Join Date
Feb 2006
Posts
2,930
You can use the built-in toRoman method of the Number object, and pass it the upper limit as an argument.

function converter(n){
return n.toRoman(50);
}

If a browser does not have the method natively, it is easy to add it:

Code:
```Number.prototype.toRoman=Number.prototype.toRoman ||
function(limit){
var n= this, val, s= '', limit=limit || 3999,
v= [1000, 900, 500, 400, 100, 90, 50, 40, 10, 9, 5, 4, 1],
r= ['M','CM','D','CD','C','XC','L','XL','X','IX','V','IV','I'];

limit=Math.min(3999,limit);
if(n< 1 || n> limit) return '';
for(var i= 0; i < 13; i++){
val= v[i];
while(n>= val){
n-= val;
s+= r[i];
}
if(n== 0) return s;
}
return '';
}```
You could also rewrite the method to not need the argument,
by setting limit to 50, and looping through the last 7 items in the arrays.
Last edited by mrhoo; 03-07-2010 at 10:18 AM.

There are currently 1 users browsing this thread. (0 members and 1 guests)

#### Posting Permissions

• You may not post new threads
• You may not post replies
• You may not post attachments
• You may not edit your posts
•

"

"

## X vBulletin 4.2.2 Debug Information

• Page Generation 0.10309 seconds
• Memory Usage 2,838KB
• Queries Executed 15 (?)
Template Usage (33):
• (1)bbcode_code
• (1)footer
• (1)forumjump
• (1)forumrules
• (1)gobutton
• (2)memberaction_dropdown
• (1)navbar
• (1)navbar_moderation
• (1)navbar_noticebit
• (1)navbar_tabs
• (2)option
• (2)postbit
• (2)postbit_onlinestatus
• (2)postbit_wrapper
• (1)spacer_close
• (1)spacer_open
• (1)tagbit_wrapper

Phrase Groups Available (6):
• global
• inlinemod
• postbit
• posting
• reputationlevel
Included Files (26):
• ./global.php
• ./includes/class_bootstrap.php
• ./includes/init.php
• ./includes/class_core.php
• ./includes/config.php
• ./includes/functions.php
• ./includes/class_friendly_url.php
• ./includes/class_hook.php
• ./includes/class_bootstrap_framework.php
• ./vb/vb.php
• ./vb/phrase.php
• ./includes/functions_calendar.php
• ./includes/functions_bigthree.php
• ./includes/class_postbit.php
• ./includes/class_bbcode.php
• ./includes/functions_reputation.php
• ./includes/functions_notice.php
• ./packages/vbattach/attach.php
• ./vb/types.php
• ./vb/cache.php
• ./vb/cache/db.php
• ./vb/cache/observer/db.php
• ./vb/cache/observer.php

Hooks Called (70):
• init_startup
• friendlyurl_resolve_class
• init_startup_session_setup_start
• database_pre_fetch_array
• database_post_fetch_array
• init_startup_session_setup_complete
• global_bootstrap_init_start
• global_bootstrap_init_complete
• cache_permissions
• fetch_foruminfo
• global_state_check
• global_bootstrap_complete
• global_start
• style_fetch
• global_setup_complete
• strip_bbcode
• friendlyurl_clean_fragment
• friendlyurl_geturl
• forumjump
• cache_templates
• cache_templates_process
• template_register_var
• template_render_output
• fetch_template_start
• fetch_template_complete
• parse_templates
• notices_check_start
• notices_noticebit
• process_templates_complete
• friendlyurl_redirect_canonical
• bbcode_fetch_tags
• bbcode_create
• postbit_factory
• postbit_display_start
• postbit_imicons
• bbcode_parse_start
• bbcode_parse_complete_precache
• bbcode_parse_complete
• postbit_display_complete
• memberaction_dropdown
• tag_fetchbit_complete
• forumrules
• navbits
• navbits_complete