Break Commands in Functions

[worldtraveller]

I had to do a break function and scripts in this portion. I am wondering if my format is correct

here is what i made

     function createBar(partyType,percent){ // script element to create blank cells
switch(partyType) {
case "D": document.write("<td class='dem'></td>");
break;
case "E": document.write("<td class='rep'></td>");
break;
case "I": document.write("<td class='ind'></td>");
break;
case "G": document.write("<td class='green'></td>");
break;
case "L": document.write("<td class='lib'></td>");
break;
}
var barTxt = partyType

for (i=0; i < percent; i++)
{
document.write(barText);
}

Let me know if this makes sense as I am still learning.

[Kor]

Not a good approach from the beginning. It is not about the switch/case statement, it is about the document.write() method. document.write() is not a dynamic method. It is, in fact, one of the few ones which works in run time, but it is a static method. Moreover: document.write() will overwrite the document each time when it is called within a function,

I guess you must have learned a server-side language before, so that you tend to code in the same manner in JavaScript as well. JavaScript is different: it is a client-side dynamic language language. JavaScript was meant to create/change/remove the elements of a web document, their attributes or attributes' values. In order to do that, JavaScript uses methods. Methods are nested in functions. In JavaScript functions are treated like first-class objects. Functions are triggered by events, following the user's actions.


Regarding your problem: to create/append new elements and their attributes you should use DOM methods:

http://www.howtocreate.co.uk/tutoria...t/domstructure
http://www.w3schools.com/htmldom/dom_methods.asp

[worldtraveller]

ok so what would be the proper way to write this? then?

[Kor]

ok so what would be the proper way to write this? then?

Follow those links I have posted and you'll find the answer