[RESOLVED] onload bugs everything

**WLQ** · 04-06-2010 03:20 AM

I have a click menu, which you can find here: http://www.stunicholls.com/menu/simple.html

The problem is that to have this menu working you must add onload="clickMenu('menu')" to <body> tag, otherwise the menu won't work. But if I add this to "the body" other functions on the page won't work. Is there a way to activate the menu, without adding onload="clickMenu('menu')" to the body tag?

Thanks, Yan

**tirna** · 04-06-2010 03:33 AM

For obvious security reasons I don't click on posted links in forums like these. But is sounds like you are either accidentally 'blocking out' other onload functions when you add the clickMenu() to the body onload, and thus stopping the other functions from working, or clickMenu() itself is stopping other functions from working properly somehow.

If clickMenu() is interfering with other functions then it probably won't matter where or how you start clickMenu() and you would need to figure out what might be wrong with clickMenu().

**kubas** · 04-06-2010 06:05 AM

try firebug for FF and check if theres no errors

**WLQ** · 04-07-2010 03:16 AM

No, nothing in firebug... here's the js, try it out:

Code:

clickMenu = function(menu) {
	var getEls = document.getElementById(menu).getElementsByTagName("LI");
	var getAgn = getEls;

	for (var i=0; i<getEls.length; i++) {
			getEls[i].onclick=function() {
				for (var x=0; x<getAgn.length; x++) {
				getAgn[x].className=getAgn[x].className.replace("unclick", "");
				getAgn[x].className=getAgn[x].className.replace("click", "unclick");
				}
			if ((this.className.indexOf('unclick'))!=-1) {
				this.className=this.className.replace("unclick", "");;
				}
				else {
				this.className+=" click";
				}
			}
		}
	}

**Kor** · 04-07-2010 03:38 AM

Originally Posted by WLQ

Is there a way to activate the menu, without adding onload="clickMenu('menu')" to the body tag?

Thanks, Yan

Yes. Call in onload (window.onload) from within a javascript code

Code:

<script type="text/javascript">
...//
onload=function(){
clickMenu('menu');
//.. other functions, statements, etc.
}
</script>

**WLQ** · 04-07-2010 03:55 AM

no, didn't help, I guess it has something to do with the self javascript, someone knows of any other good "click" menus?

**Kor** · 04-07-2010 04:12 AM

Originally Posted by WLQ

no, didn't help, I guess it has something to do with the self javascript, someone knows of any other good "click" menus?

Should. Unless you have other libraries or pieces of code which use window.onload as well.

You could also try to attach new handlers:

Code:

function AttachEvent(obj,evt,fnc,useCapture){
	if (!useCapture) useCapture=false;
	if (obj.addEventListener){
		obj.addEventListener(evt,fnc,useCapture);
		return true;
	} else if (obj.attachEvent) return obj.attachEvent("on"+evt,fnc);
	else{
		MyAttachEvent(obj,evt,fnc);
		obj['on'+evt]=function(){ MyFireEvent(obj,evt) };
	}
} 
function MyAttachEvent(obj,evt,fnc){
	if (!obj.myEvents) obj.myEvents={};
	if (!obj.myEvents[evt]) obj.myEvents[evt]=[];
	var evts = obj.myEvents[evt];
	evts[evts.length]=fnc;
}

function MyFireEvent(obj,evt){
	if (!obj || !obj.myEvents || !obj.myEvents[evt]) return;
	var evts = obj.myEvents[evt];
	for (var i=0,len=evts.length;i<len;i++) evts[i]();
}

AttachEvent(window,'load',function(){
clickMenu('menu');
//.. other functions, statements, etc.
},false);

**WLQ** · 04-07-2010 05:04 AM

that didn't help either, but looking through my js files, I've found out that I do have another window.onload function

**WLQ** · 04-07-2010 05:46 AM

any other way I can call my menu, other then window.onload?

**Kor** · 04-07-2010 07:40 AM

Originally Posted by WLQ

that didn't help either

No way. Should work by all means. You must have done another error... Without seeing your code I can not say which error. Have you removed onload=clickMenu('menu') from the BODY tag?

Post a link to a test page, to see what is all about.

**WLQ** · 04-07-2010 11:24 AM

I did remove it from the body tag, and added the javascript you gave in the head. Menu will work, but my search field won't work.

Should. Unless you have other libraries or pieces of code which use window.onload as well.

Js file for search begins with "window.onload=function() {"

**WLQ** · 04-08-2010 02:22 AM

could that be a problem?

**Kor** · 04-08-2010 03:00 AM

Originally Posted by WLQ

could that be a problem?

No. Try something else. If you say that your search JS file has something like:

Code:

window.onload=function(){
//... the rest of the code for search
}

put your menu starting function inside that anonymous:

Code:

window.onload=function(){
clickMenu('menu');
//... the rest of the code for search
}

**WLQ** · 04-08-2010 03:58 AM

yes, great, thanks!

Thread: [RESOLVED] onload bugs everything

Thread Tools

Display

[RESOLVED] onload bugs everything

Thread Information

Users Browsing this Thread

Bookmarks

Bookmarks

Posting Permissions