www.webdeveloper.com
Results 1 to 7 of 7

Thread: help with loop

  1. #1
    Join Date
    Apr 2010
    Posts
    29

    help with loop

    i have this code
    Code:
    function confirmUpdate() {
    	var TheForm = document.submenu_edit;
    	
    	for (i=0 ; i<=20 ; i++) {
    	if (!(TheForm + "position_" + i)) {
    		continue;
    	}
    		else {
    			if (TheForm. + "position_" + i + .value.length > 1) {
    				TheForm. + "position_" + i + .style.background = "#F62817";
    				return false;
    			}
    		}
    	}
    	return true;
    }
    and html
    HTML Code:
    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
    <html>
    <head>
    	<title>eAsociatia - User</title>
    <script type="text/javascript" src="script.js"></script>
    <body>
    <form name="submenu_edit" action="submenu_edit.php" method="post" onsubmit="return confirmUpdate()">
    <table>
    <tr><td><input type="text" class ="position" name="position_1" value="1"></td></tr>
    <tr><td><input type="text" class ="position" name="position_2" value="2"></td></tr>
    <tr><td><input type="text" class ="position" name="position_3" value="3"></td></tr>
    <tr><td><input type="text" class ="position" name="position_4" value="1"></td></tr>
    <tr><td><input type="text" class ="position" name="position_5" value="2"></td></tr>
    <tr><td><input type="text" class ="position" name="position_6" value="3"></td></tr>
    <tr><td><input type="text" class ="position" name="position_7" value="1"></td></tr>
    <tr><td><input type="text" class ="position" name="position_8" value="2"></td></tr>
    <tr><td><input type="text" class ="position" name="position_9" value="3"></td></tr>
    <tr><td><input type="text" class ="position" name="position_10" value="1"></td></tr>
    <tr><td><input type="text" class ="position" name="position_11" value="2"></td></tr>
    <tr><td><input type="text" class ="position" name="position_12" value="3"></td></tr>
    <tr><td><input type="text" class ="position" name="position_13" value="4"></td></tr>
    <tr><td><input type="text" class ="position" name="position_14" value="5"></td></tr>
    <tr><td><input type="text" class ="position" name="position_15" value="6"></td></tr>
    </table>
    <input type=submit>
    </form>
    </body>
    </html>
    now i am trying to change the background color of the field that have more than 1 char and return false if there is one (onsubmit)

  2. #2
    Join Date
    Aug 2007
    Posts
    3,767
    If you want to access an element with a string, you use this.
    Code:
    theForm["position_"+i]

  3. #3
    Join Date
    Apr 2010
    Posts
    29
    Code:
    function confirmUpdate() {
    	var theForm = document.submenu_edit;
    	
    	for (i=0 ; i<=15 ; i++) {
    	if (!(theForm["position_"+i])) {
    		continue;
    	}
    		else {
    			if (theForm["position_" + i] + value.length > 1) {
    				theForm["position_" + i] + style.background = "#F62817";
    				return false;
    			}
    		}
    	}
    	return false;
    }
    i modified it and still doesn't load i`m sure the bolded area is incorrect but dunno what to try next
    Last edited by p2xt; 04-08-2010 at 06:01 PM.

  4. #4
    Join Date
    Apr 2010
    Posts
    29
    got it working

    Code:
    function confirmUpdate() {
    	var theForm = document.submenu_edit;
    	
    	for (i=0 ; i<=15 ; i++) {
    	if (!(theForm["position_"+i])) {
    		continue;
    	}
    		else {
    			if (theForm["position_" + i].value.length > 1) {
    				theForm["position_" + i].style.background = "#F62817";
    				return false;
    			}
    		}
    	}
    	return false;
    }

  5. #5
    Join Date
    Aug 2007
    Posts
    3,767
    Just a few notes. You could really leave out the else, because if the first if passes, that won't execute anyway. But that makes no difference.
    Code:
    function confirmUpdate() {
    	var theForm = document.submenu_edit;
    	
    	for (i=0 ; i<=15 ; i++) {
    		if (!(theForm["position_"+i])) {
    			continue;
    		}
    		if (theForm["position_" + i].value.length > 1) {
    			theForm["position_" + i].style.background = "#F62817";
    			return false;
    		}
    	}
    	return false;
    }
    Also, just to make sure you get the point, any property can be accessed in two ways. One is object.property, and the other is object["property"]. So the following is perfectly valid.
    Code:
    function confirmUpdate() {
    	var theForm = window["document"]["submenu_edit"];
    	
    	for (i=0 ; i<=15 ; i++) {
    		if (!(theForm["position_"+i])) {
    			continue;
    		}
    		if (theForm["position_" + i]["value"]["length"] > 1) {
    			theForm["position_" + i]["style"]["background] = "#F62817";
    			return false;
    		}
    	}
    	return false;
    }

  6. #6
    Join Date
    Apr 2010
    Posts
    29
    i forgot the else there ... when i write it ... i write so i can understand easly and then i modify ...

    now i ended in another error ...
    i have a var
    Code:
    	var illegalChars = /\W/;
    now i wanna use - and spaces not only letter numbers and _ so i modify the var to
    Code:
    	var illegalChars = /[^a-zA-Z0-9-_ ]/;
    and to trigger
    Code:
    if (illegalChars.test(theForm["menu_name_" + i].value)) {
    			theForm["menu_name_" + i].style.background = "#F62817";
    			temp += "Numele contine caractere interzise.\n";
    it works but another part crashes (on submit there is no alert text and no return false but the rest of the code works)

    now form what i can figure out the space is causing the problem so i need a alternative
    i tryed adding \s instead of that space and i get the same error

    thank you for your time Declan1991 i really appreciate your help
    finaly javascript is starting to make some sense
    Last edited by p2xt; 04-08-2010 at 09:03 PM.

  7. #7
    Join Date
    Apr 2010
    Posts
    29
    unbelievable the error was caused by smt else...
    Code:
    		} else {
    			theForm["position_" + i].style.background = "#fff";
    			temp = "";
    		}
    	}
    Code:
    temp += "";

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center



Recent Articles