www.webdeveloper.com
Results 1 to 7 of 7

Thread: help with loop

  1. #1
    Join Date
    Apr 2010
    Posts
    29

    help with loop

    i have this code
    Code:
    function confirmUpdate() {
    	var TheForm = document.submenu_edit;
    	
    	for (i=0 ; i<=20 ; i++) {
    	if (!(TheForm + "position_" + i)) {
    		continue;
    	}
    		else {
    			if (TheForm. + "position_" + i + .value.length > 1) {
    				TheForm. + "position_" + i + .style.background = "#F62817";
    				return false;
    			}
    		}
    	}
    	return true;
    }
    and html
    HTML Code:
    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
    <html>
    <head>
    	<title>eAsociatia - User</title>
    <script type="text/javascript" src="script.js"></script>
    <body>
    <form name="submenu_edit" action="submenu_edit.php" method="post" onsubmit="return confirmUpdate()">
    <table>
    <tr><td><input type="text" class ="position" name="position_1" value="1"></td></tr>
    <tr><td><input type="text" class ="position" name="position_2" value="2"></td></tr>
    <tr><td><input type="text" class ="position" name="position_3" value="3"></td></tr>
    <tr><td><input type="text" class ="position" name="position_4" value="1"></td></tr>
    <tr><td><input type="text" class ="position" name="position_5" value="2"></td></tr>
    <tr><td><input type="text" class ="position" name="position_6" value="3"></td></tr>
    <tr><td><input type="text" class ="position" name="position_7" value="1"></td></tr>
    <tr><td><input type="text" class ="position" name="position_8" value="2"></td></tr>
    <tr><td><input type="text" class ="position" name="position_9" value="3"></td></tr>
    <tr><td><input type="text" class ="position" name="position_10" value="1"></td></tr>
    <tr><td><input type="text" class ="position" name="position_11" value="2"></td></tr>
    <tr><td><input type="text" class ="position" name="position_12" value="3"></td></tr>
    <tr><td><input type="text" class ="position" name="position_13" value="4"></td></tr>
    <tr><td><input type="text" class ="position" name="position_14" value="5"></td></tr>
    <tr><td><input type="text" class ="position" name="position_15" value="6"></td></tr>
    </table>
    <input type=submit>
    </form>
    </body>
    </html>
    now i am trying to change the background color of the field that have more than 1 char and return false if there is one (onsubmit)

  2. #2
    Join Date
    Aug 2007
    Posts
    3,767
    If you want to access an element with a string, you use this.
    Code:
    theForm["position_"+i]

  3. #3
    Join Date
    Apr 2010
    Posts
    29
    Code:
    function confirmUpdate() {
    	var theForm = document.submenu_edit;
    	
    	for (i=0 ; i<=15 ; i++) {
    	if (!(theForm["position_"+i])) {
    		continue;
    	}
    		else {
    			if (theForm["position_" + i] + value.length > 1) {
    				theForm["position_" + i] + style.background = "#F62817";
    				return false;
    			}
    		}
    	}
    	return false;
    }
    i modified it and still doesn't load i`m sure the bolded area is incorrect but dunno what to try next
    Last edited by p2xt; 04-08-2010 at 05:01 PM.

  4. #4
    Join Date
    Apr 2010
    Posts
    29
    got it working

    Code:
    function confirmUpdate() {
    	var theForm = document.submenu_edit;
    	
    	for (i=0 ; i<=15 ; i++) {
    	if (!(theForm["position_"+i])) {
    		continue;
    	}
    		else {
    			if (theForm["position_" + i].value.length > 1) {
    				theForm["position_" + i].style.background = "#F62817";
    				return false;
    			}
    		}
    	}
    	return false;
    }

  5. #5
    Join Date
    Aug 2007
    Posts
    3,767
    Just a few notes. You could really leave out the else, because if the first if passes, that won't execute anyway. But that makes no difference.
    Code:
    function confirmUpdate() {
    	var theForm = document.submenu_edit;
    	
    	for (i=0 ; i<=15 ; i++) {
    		if (!(theForm["position_"+i])) {
    			continue;
    		}
    		if (theForm["position_" + i].value.length > 1) {
    			theForm["position_" + i].style.background = "#F62817";
    			return false;
    		}
    	}
    	return false;
    }
    Also, just to make sure you get the point, any property can be accessed in two ways. One is object.property, and the other is object["property"]. So the following is perfectly valid.
    Code:
    function confirmUpdate() {
    	var theForm = window["document"]["submenu_edit"];
    	
    	for (i=0 ; i<=15 ; i++) {
    		if (!(theForm["position_"+i])) {
    			continue;
    		}
    		if (theForm["position_" + i]["value"]["length"] > 1) {
    			theForm["position_" + i]["style"]["background] = "#F62817";
    			return false;
    		}
    	}
    	return false;
    }

  6. #6
    Join Date
    Apr 2010
    Posts
    29
    i forgot the else there ... when i write it ... i write so i can understand easly and then i modify ...

    now i ended in another error ...
    i have a var
    Code:
    	var illegalChars = /\W/;
    now i wanna use - and spaces not only letter numbers and _ so i modify the var to
    Code:
    	var illegalChars = /[^a-zA-Z0-9-_ ]/;
    and to trigger
    Code:
    if (illegalChars.test(theForm["menu_name_" + i].value)) {
    			theForm["menu_name_" + i].style.background = "#F62817";
    			temp += "Numele contine caractere interzise.\n";
    it works but another part crashes (on submit there is no alert text and no return false but the rest of the code works)

    now form what i can figure out the space is causing the problem so i need a alternative
    i tryed adding \s instead of that space and i get the same error

    thank you for your time Declan1991 i really appreciate your help
    finaly javascript is starting to make some sense
    Last edited by p2xt; 04-08-2010 at 08:03 PM.

  7. #7
    Join Date
    Apr 2010
    Posts
    29
    unbelievable the error was caused by smt else...
    Code:
    		} else {
    			theForm["position_" + i].style.background = "#fff";
    			temp = "";
    		}
    	}
    Code:
    temp += "";

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.15693 seconds
  • Memory Usage 2,915KB
  • Queries Executed 15 (?)
More Information
Template Usage (34):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (11)bbcode_code
  • (1)bbcode_html
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (7)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (7)postbit
  • (7)postbit_onlinestatus
  • (7)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (70):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates