piglatin converter

**Codercoder123** · 05-06-2010 11:37 AM

HI! I'm making a program that lets you type in a word and converts it to pig latin. I wrote it out in Python originally, and the program doesn't work. Is there something wrong with my for loop??

Code:

<HTML>

<HEAD>

<SCRIPT LANGUAGE = "JavaScript">

var original = prompt('Type a word');

var count = 0

var istrue = False

var  suffix = ""

var modified = ""

var letter;

for (letter in original)

{

	if (!(istrue)){

		if(letter (!(in "aeiouy")){

			suffix = suffix + letter;

			}

		if(letter in "aeiouy"){

			istrue = True;

			}

	}

	if(istrue){

		modified = modified + letter;

		}

}

alert(modified + suffix + "ae");

</SCRIPT>

</HEAD>

<BODY>

</BODY>

</HTML>

**Gullanian** · 05-06-2010 11:41 AM

Run it in FireFox and go to the error console, it's the quickest way to locate errors. From what you have written I can see a few things that would probably fail.

**JMRKER** · 05-06-2010 11:59 AM

Originally Posted by Gullanian

Run it in FireFox and go to the error console, it's the quickest way to locate errors. From what you have written I can see a few things that would probably fail.

Then compare your solution to these

**NicTlt** · 05-06-2010 05:19 PM

"in" doesn't really work like that in javascript.

You could try something like:

Code:

var original = prompt("Type a word");

for (var i = 0, letter; letter = original[i]; i++) {
    if ("aeiouy".indexOf(letter) > -1) {
        break;
    }
}
alert(original.slice(i) + original.substr(0, i) + "ae");

**Codercoder123** · 05-06-2010 05:21 PM

whoo! that's a lot of stuff i don't know about! Thanks!

**NicTlt** · 05-06-2010 05:31 PM

And I was probably still fiddling with it as you read it...

Here is the skinny on string functions:
https://developer.mozilla.org/en/Cor...Objects/String

**NicTlt** · 05-06-2010 06:02 PM

Hmm still a bit long-winded - no real need for a breaking if statement in a for loop:

Code:

var original = prompt("Type a word");

for (var i = 0; "aeiouy".indexOf(original[i]) === -1; i++);

alert(original.slice(i) + original.substr(0, i) + "ae");

**JMRKER** · 05-06-2010 07:41 PM

Slightly easier to test if you don't have to reload every time...

Code:

<script type="text/javascript">
do {
var original = prompt("Type a word");

for (var i = 0; "aeiouy".indexOf(original[i]) === -1; i++);

alert(original.slice(i) + original.substr(0, i) + "ae");
} while (original != 'end');
</script>

Enter 'end' to stop

**NicTlt** · 05-07-2010 04:13 AM

Probably best to check for end of string as well, to be honest, as the last one really doesn't cope with (accidental) all-consonant words. And I'm not sure IE supports string indexing.

If you wanted to make it more generic, you could do:

Code:

String.prototype.emPiggen = function () {
    for (var i = 0, letter; ((letter = this.substr(i, 1)) && ("aeiouy".indexOf(letter) < 0)); i++);
    return this.slice(i) + this.substr(0, i) + "ae";
}

Then you can do:

Code:

var someString = "String";
alert(someString.emPiggen());
alert("Krakatoa".emPiggen());

etc.

**NicTlt** · 05-07-2010 09:05 AM

Or you could even replace the for loop altogether with a regexp:

Code:

String.prototype.emPiggen = function() {
    var i = this.indexOf(this.match(/[aeiouy]/i));
    return (i < 0) ? this : this.slice(i) + this.substr(0, i) + "ae";
}

So many ways to skin that cat once you open javascript's knife drawer...

**Kor** · 05-07-2010 09:22 AM

What about a translation from/to Dog Latin?

**NicTlt** · 05-07-2010 11:18 AM

And if you want to really annoy anyone tasked with maintaining your code, you can fold it down into one line:

Code:

String.prototype.emPiggen = function(i) {
    return ((i = this.indexOf(this.match(/[aeiouy]/i))) < 0) ? this : this.slice(i) + this.substr(0, i) + "ae";
}

And who says javascript isn't a "proper" language?

Thread: piglatin converter

Thread Tools

Display

piglatin converter

Thread Information

Users Browsing this Thread

Tags for this Thread

Bookmarks

Bookmarks

Posting Permissions