www.webdeveloper.com
Results 1 to 5 of 5

Thread: Regex within a switch Question

  1. #1
    Join Date
    Oct 2005
    Location
    Knoxville Tennessee
    Posts
    79

    Regex within a switch Question

    I have a simple script, in which I am trying to pull the browser type out of an agent string. This should be horribly easy but I cant seem to pull it off.

    I am using regex, and have tried a dizzying array of different configurations. The only response I am getting from the script is the default case, that being unknown. In using my own user agent string, I know the word Firefox is within the string but cant capture it.

    Code:
    $agent = $_SERVER["HTTP_USER_AGENT"];
    
    if (isset($agent)){
    switch($agent){
        case 1:
        if (preg_match('/(?:MSIE 3)/', $agent)){
            $browser = "MSIE 3";
            
        }break;
        case 2:
        if (preg_match('/(?:MSIE 4)/', $agent)){
            $browser = "MSIE 4";
            
        }break;
        case 3:
        if (preg_match('/(?:MSIE 5)/', $agent)){
            $browser = "MSIE 5";
           
        } break;
        case 4:
        if (preg_match('/(?:MSIE 6)/', $agent)){
            $browser = "MSIE 6";
            
        }break;
        case 5:
        if (preg_match('/(?:MSIE 7)/', $agent)){
            $browser = "MSIE 7";
            
        }break;
        case 6:
        if (preg_match('/?:(MSIE 8)/', $agent)){
            $browser = "MSIE 8";
         
        } break;
        case 7:
        if (preg_match('/(?:Opera)/', $agent)){
            $browser = "Opera";
            
        }break;
        case 8:
        if (preg_match('/(?:Chrome)/', $agent)){
            $browser = "Chrome";
            
        }break;
        case 9:
        if (preg_match('/(?:Safari)/', $agent)){
            $browser = "Safari";
            
        }break;
        case 10:
        if (preg_match('/^(?:(Firefox))$/', $agent)){
            $browser = "Firefox";        
        }break;
              
        default:
        $browser = "Unknown"; 
    }
    }
    I have tried the break within the if statement and outside. The script from here just goes on to enter the browser into the database.

    Any thoughts?

  2. #2
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,335
    Looks like a misunderstanding of the "case" part of a switch(). case 1: is testing if $agent == 1. Since it does not, it goes to the next case, and so on until you reach the default. Also, you don't want to anchor the "Firefox" to the start (^) and end ($) of the regexp. Lastly, by definition $agent is always set since you define it right before you do the isset(). So, here's a shortened piece of code that correctly identified by Firefox browser string:
    PHP Code:
    <?php
    $agent 
    $_SERVER["HTTP_USER_AGENT"];
    switch (
    1) {
        case 
    preg_match('/MSIE 3/'$agent):
            
    $browser "MSIE 3";
            break;
        
        case 
    preg_match('/Firefox/'$agent):
            
    $browser "Firefox";
            break;
        
        default:
            
    $browser "Unknown";
    }
    echo 
    $browser;
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  3. #3
    Join Date
    Oct 2005
    Location
    Knoxville Tennessee
    Posts
    79
    Ah I see, thank you very much nogdog, as usual you are very helpful. I understand what I was doing wrong

  4. #4
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,335
    PS: I might approach it from this direction, both as less code and ease of maintenance (just have to change the array to change the list of browsers):
    PHP Code:
    <?php
    $agent 
    $_SERVER["HTTP_USER_AGENT"];
    $browsers = array(
       
    'MSIE 3',
       
    'MSIE 4',
       
    'MSIE 5',
       
    'MSIE 6',
       
    'MSIE 7',
       
    'MSIE 8',
       
    'Chrome',
       
    'Safari',
       
    'Opera',
       
    'Firefox'
    );
    $regexp '/' implode('|'$browsers) . '/';
    $browser preg_match($regexp$agent$matches) ? $matches[0] : 'unknown';
    echo 
    $browser;
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  5. #5
    Join Date
    Oct 2005
    Location
    Knoxville Tennessee
    Posts
    79
    That makes a lot of sense, I will give that a try

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.12353 seconds
  • Memory Usage 2,885KB
  • Queries Executed 13 (?)
More Information
Template Usage (34):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (1)bbcode_code
  • (2)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (5)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (5)postbit
  • (5)postbit_onlinestatus
  • (5)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (71):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates