www.webdeveloper.com
Results 1 to 5 of 5

Thread: Javascript array problem

  1. #1
    Join Date
    Nov 2010
    Location
    Beaverton, OR
    Posts
    7

    Javascript array problem

    var Dogs = new Array();
    Dogs[0] = "Raven";
    Dogs[1] = "Arek";
    Dogs[2] = "Demo";
    Dogs[3] = "Haley";
    // Images = number of images
    var Images = new Array();
    Images[0] = 5;
    Images[1] = 7;
    Images[2] = 8;
    Images[3] = 4;

    function initDog(dog) {
    if(dog === "") { dog='Raven'; }
    imgSetNum = Dogs.indexOf(dog);
    imgMax = Images[imgSetNum];
    imgSetNum ++;
    }

    in the function initDog, imgSetNum = Dogs.indexOf(dog) always return -1 (not found). I verified that the "dog" value is correctly set to a dog name in the Dogs array.

    What am I doing wrong?

  2. #2
    Join Date
    Oct 2010
    Location
    Versailles, France
    Posts
    1,290
    How do you call initDog ? with intDog() or with initDog("") ?
    if (!dog) { dog='Raven'; } could be better as if(dog === "") {dog='Raven';} to work with both syntaxes...

    ImgMax and imgSetNum are now local variable in the function. They have to be defined with a var imgMax,imgSetNum; outside to be global variables !

  3. #3
    Join Date
    Aug 2008
    Location
    Sweden
    Posts
    227
    The code works perfectly for me. The error is outside the code you posted I believe.

    Quote Originally Posted by 007Julien View Post
    ImgMax and imgSetNum are now local variable in the function. They have to be defined with a var imgMax,imgSetNum; outside to be global variables !
    That's not true. You have to use the 'var' keyword to make a local variable, or else it will be global by default. (Variables should be declared with var somewhere though for clarity and to give it a better closure than the global scope.)

  4. #4
    Join Date
    Nov 2010
    Location
    Beaverton, OR
    Posts
    7
    The var ingSetNum and imgMax are defined locally.
    The value of 'dog' is passed using php:
    onload="initDog(<?php echo "'".$_GET['dogname']."'"?>);imgNum=0;nextImg()">

    I verified that 'dog' really contains the dog name listed in the array Dogs.

  5. #5
    Join Date
    Nov 2010
    Location
    Beaverton, OR
    Posts
    7
    Problem Solved !

    The onload="initDog(<?php echo "'".$_Get['dogname'."'" ?>" correctly makes the call to the function initDog as:

    "initDog('dognamevalue')" ---notice the single quotes.

    The function initDog(dog) stores the 'dognamevalue' with the single quotes!!!!!

    The solution is to remove the single quote:

    dog = dog.substr(1,dog.lastIndexOf("'")-1);

    The whole function now works correctly.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.31687 seconds
  • Memory Usage 2,871KB
  • Queries Executed 15 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (5)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (5)postbit
  • (5)postbit_onlinestatus
  • (5)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (71):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates