firefox and firebug error

[antares]

So I have a function that gets called when you press an arror which will update 16 img src attributes. Odd thing is, it loads them properly, however, the checkboxes which determines if a client/user likes, or in this case makes them a favorite doesn't update or even load the initial set. I was wondering what was wrong. Any ideas?

Firebug tells me its the line with the *****

function updateThumbnails()
{
	var i = (currentPage-1)*16;
	var x = 0;
	if( currentPage != totalPages )
	{
		for( i; i < i+16; i++ )
		{
			x = i-(16*(currentPage-1));
			******document.getElementById( "tb_" + x ).src = thumbnail_dir + thumbnails[i];*******
			document.getElementById( "fav_" + x ).disabled = false;
			document.getElementById( "fav_" + x ).style.display = 'inline';
			document.getElementById( "fav_" + x ).checked = false;
			if( favorites[i] )
			{
				document.getElementById( "fav_" + x ).checked = true;
			}
		}
	}
	else
	{
		
		for( i; i < thumbnails.length; i++ )
		{
			x = i-(16*(currentPage-1));
			document.getElementById( "tb_" + x ).src = thumbnail_dir + thumbnails[i];
			document.getElementById( "fav_" + x ).checked = false;
			if( favorites[i] )
			{
				document.getElementById( "fav_" + x ).checked = true;
			}
		}
		for( var k = thumbnails.length % 16; k < 16; k++)
		{
			document.getElementById( "tb_" + k ).src = "http://www.roderickpena.com/images/layout/blank.png";
			document.getElementById( "fav_" + k ).disabled = true;
			document.getElementById( "fav_" + k ).style.display = 'none';
		}
	}
}

[antares]

Anyone have any ideas why firebug would be having an error with this line?

[patrx-7]

Just a quick note that may lead somewhere. It seems to me that

		for( i; i < i+16; i++ )

results in an infinite loop (i < i+16 will always be true). The infinite loop would eventually lead to getElementById( "tb_" + x ) not finding an element, and to thumbnails[i] going out of bounds of the array.

You might try:

		var endLoop = i + 16;
		for( i; i < endLoop; i++ )

Patrick Carlo-Hickman
http://AllegroConsultants.com/opensource

[antares]

Ahh, yeah that does make sense. However, firefox still doesn't update the checkboxes. I didn't know this but I had put false for the async with the httprequest when grabbing the favorites. Guess firefox doesn't like that.

Thanks for the reply pat

[patrx-7]

Do the checkboxes have an id attribute defined? In IE, getElementById will find the element by the name attribute, if the id attribute doesn't exist. FireFox will not do this.

Just another thought.

Patrick Carlo-Hickman
http://AllegroConsultants.com/opensource