www.webdeveloper.com
Results 1 to 8 of 8

Thread: PHP || (and) operator question

  1. #1
    Join Date
    May 2009
    Posts
    9

    Thumbs up PHP || (and) operator question

    I am trying to make my navigation to change color when selected. the class for selected is "current"

    so I wrote this:

    <ul class="<?php if(myfullpath() == "http://www.domain.com/first.php" || "http://www.domain.com/second.php"){echo "current";} else echo " "; ?>">

    so if the url in the address bar is not first.php or second.php it should return false and echo " ", but for some odd reason this is returning true and posting class="current"> even if the url is posting http://www.domain.com/fourth.php.

    JUST FYI here is the myfullpath function:

    function myfullpath() { $s = empty($_SERVER["HTTPS"]) ? '' : ($_SERVER["HTTPS"] == "on") ? "s" : ""; $protocol = strleft(strtolower($_SERVER["SERVER_PROTOCOL"]), "/").$s; $port = ($_SERVER["SERVER_PORT"] == "80") ? "" : (":".$_SERVER["SERVER_PORT"]); return $protocol."://".$_SERVER['SERVER_NAME'].$port.$_SERVER['REQUEST_URI']; } function strleft($s1, $s2) { return substr($s1, 0, strpos($s1, $s2)); }


    thanks for your help.

  2. #2
    Join Date
    Jan 2011
    Posts
    19
    Hi you missed a point there
    <ul class="<?php if(myfullpath() == "http://www.domain.com/first.php" || "http://www.domain.com/second.php"){echo "current";} else echo " "; ?>">
    check If statement
    It should be
    <ul class="<?php if(myfullpath() == "http://www.domain.com/first.php" || myfullpath() == "http://www.domain.com/second.php"){echo "current";} else echo " "; ?>">
    PS: I didnt execute this code... have to check yourself

  3. #3
    Join Date
    May 2009
    Posts
    9

    Thanks!

    Hi Thank you that's right I forgot about that, I atually ended up using elseif instead, so :

    if(myfullpath() == "http://www.domain.com/first.php"){echo "current";} elseif(myfullpath() == "http://www.domain.com/second.php") {
    echo "current";}else echo " ";
    I wonder which is a better practice or if there is any difference in server resources.

    Thanks again for all your help

  4. #4
    Join Date
    Jan 2011
    Posts
    19
    Both, in this case, are the same. As in using A || B it checks A and if true it ignores B. Similarly in ifelse if first IF statement is true it ignores the second.

    But from a view of code maintenance its a single if statement thats better.

  5. #5
    Join Date
    May 2009
    Posts
    9
    yea you are right the elseif statements can become hard to figure out after a while and also || is much shorter and easier to troubleshoot. I have changed it all over to || and it works great! thank you so much !

  6. #6
    Join Date
    Jul 2007
    Location
    Wisconsin
    Posts
    468
    PHP Code:
    <?php
    $fullPath 
    myfullpath();
    $class="";
    if ( 
           (
    $fullPath == "http://www.domain.com/first.php") || 
           (
    $fullPath == "http://www.domain.com/second.php")
    )
    {
         
    $class 'class="current" ';
    }
    ?>

    <ul <?php echo $class?> >

    Just a couple of points to add:

    -- single call to the function (small improvement to performance, plus a bit easier to maintain/reuse later on)
    -- [expanding from adarshakb] wrap each IF check in it's own parenthesis, then wrap all the IF checks in parenthesis
    -- I prefer to to create the empty $class string, then populate it if needed, and echo out the entire string. This way, you don't leave unnecessary empty 'class=""' in your HTML (again, just a small personal preference)

  7. #7
    Join Date
    Jan 2006
    Location
    MN
    Posts
    440
    Just for clarification the || operator is the OR operator, not the AND operator which is &&. The thread title is a little confusing in that regard.

  8. #8
    Join Date
    Jan 2011
    Posts
    19
    YA!!! didnt notice that :P

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.15018 seconds
  • Memory Usage 2,911KB
  • Queries Executed 13 (?)
More Information
Template Usage (34):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (1)bbcode_php
  • (2)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (8)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (8)postbit
  • (8)postbit_onlinestatus
  • (8)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (71):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates