www.webdeveloper.com
Results 1 to 3 of 3

Thread: This code for buttons isn't working...

  1. #1
    Join Date
    Oct 2010
    Location
    On a BOAT!
    Posts
    7

    This code for buttons isn't working...

    Why doesn't this code work????

    Code:
    <head>
    <script language="javascript" type="text/javascript">
    var rD = 2;
    var gN = 2;
    var bL = 2;
    var iD_is;
    rD is the # of red buttons "on",
    gN is the # of green buttons "on",
    bL is the # of blue buttons "on", &
    iD_is is the id of the img to change.
    Code:
    </script>
    <script language="javascript" type="text/javascript">
    function red_down()
    {if (rD != 0);{rD-=1};
    if (rD = 0);{iD_is = 'r1'};
    if (rD = 1);{iD_is = 'r2'};
    {document.getElementById(iD_is).src = 'http://bit.ly/red_xed'};}
    </script>
    <script language="javascript" type="text/javascript">
    function green_down()
    {if (gN != 0);{bL-=1};
    if (gN = 0);{iD_is = 'g1'};
    if (gN = 1);{iD_is = 'g2'};
    {document.getElementById(iD_is).src = 'http://bit.ly/green_xed'};}
    </script>
    <script language="javascript" type="text/javascript">
    function blue_down()
    {if (bL != 0);{bL-=1};
    if (bL = 0);{iD_is = 'b1'};
    if (bL = 1);{iD_is = 'b2'};
    {document.getElementById(iD_is).src = 'http://bit.ly/blue-xed'};}
    </script>
    <script language="javascript" type="text/javascript">
    function red_up()
    {if (rD != 2);{rD+=1};
    if (rD = 2);{iD_is = 'r2'};
    if (rD = 1);{iD_is = 'r1'};
    {document.getElementById(iD_is).src = 'http://bit.ly/red_button'};}
    </script>
    <script language="javascript" type="text/javascript">
    function green_up()
    {if (gN != 2);{gN+=1};
    if (gN = 2);{iD_is = 'g2'};
    if (gN = 1);{iD_is = 'g1'};
    {document.getElementById(iD_is).src = 'http://bit.ly/green_button'};}
    </script>
    <script language="javascript" type="text/javascript">
    function blue_up()
    {if (bL != 2);{bL+=1};
    if (bL = 2);{iD_is = 'b2'};
    if (bL = 1);{iD_is = 'b1'};
    {document.getElementById(iD_is).src = 'http://bit.ly/blue-button'};}
    </script>
    </head>
    <body>
    <table>
       <tr>
          <td><button onclick="red_down()">-</button></td>
          <td><button onclick="green_down()">-</button></td>
          <td><button onclick="blue_down()">-</button></td>
       </tr>
       <tr>
          <td><img id="r1" src="http://bit.ly/red_button"></td>
          <td><img id="g1" src="http://bit.ly/green_button"></td>
          <td><img id="b1" src="http://bit.ly/blue-button"></td>
       </tr>
       <tr>
          <td><img id="r2" src="http://bit.ly/red_button"></td>
          <td><img id="g2" src="http://bit.ly/green_button"></td>
          <td><img id="b2" src="http://bit.ly/blue-button"></td>
       </tr>
       <tr>
          <td><button onclick="red_up()">+</button></td>
          <td><button onclick="green_up()">+</button></td>
          <td><button onclick="blue_up()">+</button></td>
       </tr>
    </table>
    </body>
    It is supposed be just 2 different lines of changing buttons. I was planning to use the "+" and "-" buttons to add/subtract button lights from a column. Unless I did something wrong, I think it should work, but it doesn't... Why?
    Last edited by wethammy123; 03-21-2011 at 09:17 PM.

  2. #2
    Join Date
    Sep 2008
    Location
    Jackson MS
    Posts
    585
    You use == in an if statement and there is no ; after an if statement before what you want to do if the statement is true.
    Code:
    if (rD == 2) {iD_is = 'r2';}

  3. #3
    Join Date
    Oct 2010
    Location
    On a BOAT!
    Posts
    7
    Thanks. I wasn't sure about that. I've done things like this before, but usually have to start from scratch when I want to do something new.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.15090 seconds
  • Memory Usage 2,850KB
  • Queries Executed 13 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (3)bbcode_code
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (3)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (3)postbit
  • (3)postbit_onlinestatus
  • (3)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (70):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates