www.webdeveloper.com
Results 1 to 4 of 4

Thread: JS Array Not Passing through Function

  1. #1
    Join Date
    May 2011
    Posts
    2

    Question JS Array Not Passing through Function

    I am coding a site for a friend who wants an image slideshow on her homepage. I've written a function that requests an array and that should pull in the images at timed intervals. Here is a snippet of the default.js code.

    Code:
    var nImg = 0;
    
    function slideShow(arr)
    {
    	// This changes the image
    	var fullPath = document.getElementById('img').src;
    	var lastnum = fullPath.lastIndexOf("/") + 1;
    	var parentFolder = fullPath.slice(0, lastnum);
    	var newImg = parentFolder + arr[nImg];
    	document.getElementById('img').src = newImg;
    
    	// This tests to see if it should loop back to the first image
    	if (nImg == arr.length - 1)
    	{ nImg = 0; }
    	else
    	{ nImg = nImg + 1; }
     
    	var reset = setTimeout("slideShow(" + arr + ")", 6000);
    }
    Here is the snippet from the homepage that should call the function:

    HTML Code:
    <script type="text/javascript" runat="server">
    	var arrHome = new Array("dress1.jpg", "dress2.jpg", "dress3.jpg", "dress4.jpg", "dress5.jpg", "dress6.jpg", "dress7.jpg");
    	slideShow(arrHome);
    </script>
    However, the array will not pass through the function. If I create an array within default.js, it works fine. The problem lies with trying to pass in an array from the HTML. Granted, I could just work in the JS and not worry about the HTML. However, there are two problems:
    1. Once I've finished coding this site, I want my friend to manage it herself. I do NOT want her touching the JS.
    2. I would like to be able to use this script on several pages, using different arrays.

    An alternate solution I've thought of is using JS to browse the contents of a directory and use any and all images located in that folder. I know I did this with PHP once; is there a similar code in JS?

    Any help you could give me would be greatly appreciated.

  2. #2
    Join Date
    Jul 2008
    Location
    urbana, il
    Posts
    2,787
    Code:
    var reset = setTimeout(function(){slideShow( arr )}, 6000);
    Create, Share, and Debug HTML pages and snippets with a cool new web app I helped create: pagedemos.com

  3. #3
    Join Date
    May 2011
    Posts
    2
    Such a simple solution! Thanks so very much!

  4. #4
    Join Date
    Feb 2006
    Posts
    2,930
    If your source file paths are identical except for the number, and they are sequential, just replace the image number with the next.

    Code:
    function slideShow(min, max){
        var fullpath= document.getElementById('img').src, newImg;
        
        if(typeof min== 'number'){
            slideshow.min= min;
            slideshow.max= max;
            slideshow.count= min-1;
        }
        if(++slideshow.count> slideshow.max) slideshow.count= slideshow.min;
        newImg= fullpath.replace(/\d+\.jpg/, slideshow.count+'.jpg';
        document.getElementById('img').src= newImg;
        slideshow.reset= setTimeout(slideShow, 6000);
    }
    window.onload= function(){
        slideShow(1, 7);
    }
    You would only need to handle an array if they were not named as sequential strings, or had different paths.

    Code:
    function slideShow(arr){
        var fullpath= document.getElementById('img').src, newImg;
        fullpath= fullpath.substring(0, fullpath.lastIndexOf('/')+1);  
        // if they are in the same folder -otherwise, pass and set the whole path from the array
        if(arr.constructor== Array){
            slideshow.pics= arr;
            slideshow.count= -1;
        }
        if(++slideshow.count== slideshow.pics.length) slideshow.count= 0;
        newImg= fullpath+slideshow.pics[slideshow.count];
        document.getElementById('img').src= newImg;
        slideshow.reset= setTimeout(slideShow, 6000);
    }
    window.onload= function(){
        slideShow(["aline.jpg", "mini.jpg", "maxi.jpg", "sheath.jpg", "sari.jpg", "wedding.jpg", "lilblack.jpg"]);
    
    //It's good to be able to pause and restart a slideshow:
    
        document.getElementById('img').onclick= function(){
            if(slideshow.reset){
                clearTimeout(slideshow.reset);
                delete slideshow.reset;
            }
            else slideShow();
        }
    }
    Last edited by mrhoo; 05-11-2011 at 11:26 AM. Reason: seqential

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.09104 seconds
  • Memory Usage 2,868KB
  • Queries Executed 13 (?)
More Information
Template Usage (34):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (4)bbcode_code
  • (1)bbcode_html
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (4)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (4)postbit
  • (4)postbit_onlinestatus
  • (4)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (71):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates