Photo Galleries Javascript

**webiter** · 07-19-2011 04:32 AM

I have 3 Galleries on a website controlled by on each of the seperate pages by <body onLoad="photoGallery()"> with the function detail for each of the galleries in the <head> section of the individual pages.... and everything worked fine!

When I seek to collect all my Javascripts bits into a .js file the Galleries no longer work! The .js file connects with the pages fine as all the other javascripts work.

I am using
var c=0
var s
function photoGallery()
{
if (c%3==0){document.getElementById('photo-gallery').src = "sequence1.jpg";}
if (c%3==1){document.getElementById('photo-gallery').src = "sequence2.jpg";}
if (c%3==2){document.getElementById('photo-gallery').src = "sequence3.jpg";}
c=c+1
s=setTimeout("photoGallery()",1600)
}

I have tried different things to give the Galleries a different identity but cannot get to work! Is there a way around this or do I have to keep the function script in the head sections?

**JMRKER** · 07-19-2011 10:17 AM

Show a link to your combined code so we can see it in action.

**webiter** · 07-19-2011 11:59 AM

Currently only this on my WAMP Localhost.

**rnd me** · 07-19-2011 12:10 PM

make sure the different set have different vars.

it looks like this would be a good chance to rewrite that overly-repetitive code as well.

**webiter** · 07-19-2011 01:04 PM

Many thanks. Got them working from the .js file. However I am still working with the overly-repetitve code!

**JMRKER** · 07-19-2011 02:43 PM

One easy change from ...

Code:

var c=0
var s
function photoGallery()
{
if (c&#37;3==0){document.getElementById('photo-gallery').src = "sequence1.jpg";}
if (c%3==1){document.getElementById('photo-gallery').src = "sequence2.jpg";}
if (c%3==2){document.getElementById('photo-gallery').src = "sequence3.jpg";}
c=c+1
s=setTimeout("photoGallery()",1600)
}

to...

Code:

var c=0
var s

function photoGallery() {
  var tcnt = (c % 3) + 1;
  document.getElementById('photo-gallery').src = "sequence"+tcnt+".jpg";
  c=c+1;
  s=setTimeout("photoGallery()",1600);
}

Untested, but it should be close to what you want.

**rnd me** · 07-19-2011 02:50 PM

Code:

  s=setTimeout("photoGallery()",1600);

should be

Code:

s=setTimeout(photoGallery, 1600);

**webiter** · 07-21-2011 02:54 PM

Hi JMRKER & rnd me.. working on the chain..

The reduced and tightened code certainly reduces the overly-repetitve code in a photoGallery with a large number of images. However, I have not as yet got the reduced code to work!

**JMRKER** · 07-21-2011 03:12 PM

Originally Posted by webiter

Currently only this on my WAMP Localhost.

Originally Posted by webiter

Hi JMRKER & rnd me.. working on the chain..

The reduced and tightened code certainly reduces the overly-repetitve code in a photoGallery with a large number of images. However, I have not as yet got the reduced code to work!

I'm not exactly sure how we can help without seeing your whole code associated with the gallery
with your post explanations published above.

**webiter** · 07-21-2011 04:08 PM

The working code in the long form which is working by displaying the sequence

var c=0
var s
function photoGallery()
{
if (c%7==0){document.getElementById('photo-Gallery').src = "sequence1.jpg";}
if (c%7==1){document.getElementById('photo-Gallery').src = "sequence2.jpg";}
if (c%7==2){document.getElementById('photo-Gallery').src = "sequence3.jpg";}
if (c%7==3){document.getElementById('photo-Gallery').src = "sequence4.jpg";}
if (c%7==4){document.getElementById('photo-Gallery').src = "sequence5.jpg";}
if (c%7==5){document.getElementById('photo-Gallery').src = "sequence6.jpg";}
if (c%7==6){document.getElementById('photo-Gallery').src = "sequence7.jpg";}
c=c+1
s=setTimeout("photoGallery()",1600)
}

Trying to get this reduced (your) code working but currently without success. Thanks for your patients.

var c=0
var s
function photoGallery() {
var tcnt = (c % 7) + 1;
document.getElementById('photo-gallery').src = "sequence"+tcnt+".jpg";
c=c+1;
s=setTimeout(photoGallery, 1600);
}

**JMRKER** · 07-21-2011 06:49 PM

In the first section of "if ..." you have an id="photo-Gallery"
but in the second (reduced) form, you use id="photo-gallery"

Can't be both and work correctly.

**webiter** · 07-24-2011 04:10 PM

Hi JMRKER,
Got it. A great result. Thanks for the tip.

**JMRKER** · 07-24-2011 06:35 PM

Originally Posted by webiter

Hi JMRKER,
Got it. A great result. Thanks for the tip.

You're most welcome from all of us, I'm sure.
Happy to help.
Good Luck!

**webiter** · 07-28-2011 04:10 PM

I have a lot of images feeding three of these javascript image galleries. I tried tidying up by putting all the images in a folder named box. l then placed the folder name box as follows .src = "box/sequence"+tcnt+".jpg"; but it did not work!

var c=0
var s
function imageGallery() {
var tcnt = (c % 7) + 1;
document.getElementById('photo-gallery').src = "sequence"+tcnt+".jpg";
c=c+1;
s=setTimeout(imageGallery, 1600);
}

Is there a way to achieve the tidy up?

**JMRKER** · 07-28-2011 08:01 PM

Where is the "box" directory in relation to the script directory?

If below it:
xxx.src = "./box/sequence"+tcnt+".jpg";

If on same level:
xxx.src = "../box/sequence"+tcnt+".jpg";

If somewhere else, specify path...
xxx.src = 'http://domain.???/box/sequence'+tcnt+".jpg";

UNLESS "sequence" is also a directory, then add '/' after, like: 'sequence/'

Difficult to give a specific answer without more information.

Thread: Photo Galleries Javascript

Thread Tools

Display

Photo Galleries Javascript

Thread Information

Users Browsing this Thread

Tags for this Thread

Bookmarks

Bookmarks

Posting Permissions