Where is "Wally"??

**pakoppan1** · 10-19-2011 11:22 AM

Hello,

I'm looking for "Wally in this piece of code but just can't figure out why the javascript is always sending me the "GOOOOODDD" message even when I enter 'aaa' in the text box.
From my perspective, when aaa is found, the BAAADDD!!! message should be issued and it's not.

"Wally" is the error that I can't figure out.

If someone could give me hint where this is going bad I'd really appreciate.

Than You for your time

___________________________________________________________

SOURCE CODE:

HTML Code:

<script language="javascript" type="text/javascript">
<!--
function GetAAA(that)  
{  
 	var mytext=document.getElementById("BLABLA")  
 
 	if (mytext == "aaa")
 	 	
 		alert("BAAAAADDDDD!!!!" + mytext.value);
 	else
 		alert(" GOOOODDDD!!!!" + mytext.value);	
}
	-->  
</script>  
</head>

<body>  
	<form id="form1" method="get" onsubmit="getAAA(this)" />
	<input 	name="BLABLA" 
			size="3"  
			type="text"/> Input Data 
			
		<br/><br/>
			
	<input name="Submit1" type="submit" value="submit" />
	
</body>
</html>

**svidgen** · 10-19-2011 02:45 PM

mytext is a node, not a string. Use:

Code:

 	if (mytext.value == "aaa")

... also use http://w3schools.com/ ....

**JunkMale** · 10-19-2011 03:50 PM

function GetAAA(that)

<form id="form1" method="get" onsubmit="getAAA(this)" />

Typos also bring down javascripts like a house of cards...

I will also say that you want to chose a naming convention that is meaningful, "BLABLA" is not a meaningful variable, if you were to have called it UserResponse then you would know what data it may contain.

**pakoppan1** · 10-19-2011 03:54 PM

Thanks for the reply svidgen,

I changed it and now I get me this message:

Uncaught exception: TypeError: Cannot convert 'mytext' to object
Error thrown at line 7, column 2 in getAAA(that)
if (mytext.value == "aaa")
called from line 1, column 0 in <anonymous function>(event):
getAAA(this)

Is there a way to fix this?

thanks

**pakoppan1** · 10-19-2011 04:10 PM

Thanks for the reply, Junkmale,

I agree with you regarding the convention, but this is just a test.

In the real world, all have meaningful names.

Anyway, thanks for the heads-up.

**JunkMale** · 10-19-2011 04:20 PM

I did a test of my own and found other issues like a missing </form tag and wrote the code below.

Code:

<script type="text/javascript">

function GetAAA(that){  
	
mytext=that.BLABLA.value;  
if( mytext == "aaa" ){
	Disp = "Bad";
	}else{
		Disp = "Good";
		}

alert( Disp + " Choice " + mytext);
return false;
}
	-->  
</script>  
</head>

<body>  
	<form id="form1" method="get" action="" onSubmit="return GetAAA(this);">
	<input 	name="BLABLA"  type="text" value=""> Input Data <br><br>
	<input name="Submit1" type="submit" value="submit">
	</form>
</body>
</html>

The idea is simple and you use the that variable that you pass on the submit of a form when the function is called. prefixing the return to it allows you to either allow the form to submit or to fail by returning true or false.

Hope that helps you, I kept your naming convention so you can see how it works.

Thread: Where is "Wally"??

Thread Tools

Display

Where is "Wally"??

Thread Information

Users Browsing this Thread

Bookmarks

Bookmarks

Posting Permissions