www.webdeveloper.com
Results 1 to 3 of 3

Thread: function stoped working when added another function to code

  1. #1
    Join Date
    Mar 2012
    Posts
    23

    function stoped working when added another function to code

    Hi,

    some time ago I posted a question on how to calculate average value out of radio buttons group and in mean time I come up with some code a function but when I use two functions (old-hide/show div and new-calculate average) the first dont work...

    can you have a look at it and suggest what needs to be changed

    THANKS
    Code:
    <script type="text/javascript">
    var lastDiv = "";
    function showDiv(divName) {
    	// hide last div
    	if (lastDiv) {
    		document.getElementById(lastDiv).className = "hiddenDiv";
    	}
    
    	if (divName && document.getElementById(divName)) {
    		document.getElementById(divName).className = "visibleDiv";
    		lastDiv = divName;
    	}
    }
    
    
    function DisplayGrade(grade){ new function , with that code the upper function dont work 
       var val1 = 0; 
       for( i = 0; i < document.semester1.web.length; i++ ){
       if( document.semester1.[i].checked == true ){
       val1 = document.semester1.web[i].value;
       	}
    	}
    
    var val2 = 0;
    for( i = 0; i < document.semester1.pr.length; i++ ){
    f( document.semester1.pr[i].checked == true ){
    val2 = document.semeseter1.pr[i].value;
       	}
    	}
                            
    var sum=parseInt(val1) + parseInt(val2);
    document.getElementById('totalSum').value=sum;
       }
    }
    
    </script>

  2. #2
    Join Date
    Feb 2003
    Location
    Michigan, USA
    Posts
    5,774

  3. #3
    Join Date
    Mar 2012
    Posts
    23
    hi and thanks for answer
    you were right about that funcion so I just got deleted it and replaced with different one.

    now show/hide div works so its half way, the grade function dont work corectly so any help appreciated here

    Code:
    <script type="text/javascript"> 
    function grade (r1, r2, r3, total)  {
    var r1 = document.getElementById("web").value;
    var r2 = document.getElementById("pr").value;
    var r3 = document.getElementById("ics").value;
    total = (  (r1 + r2 + r3) /3 )  ; 
    }
                            
    //-->
    </script>
    <body>
    	<input type="text" name="grade" id="grade" value="" size="2" readonly="readonly">
    	hello student1
    		<form id="FormName" action="blah.php" method="get" name="FormName">
    			<select name="selectName" size="1" onchange="showDiv(this.value);">
    				<option value="">Choose semester</option>
    				<option value="one">first</option>
    				<option value="two">second</option>
    			</select>
    		</form>
    		<p id="one" class="hiddenDiv" form name="semester1" action"#"> 
    		whats your scores in these modules?</br>
    		Web developement:
    		<label> <input type = "radio"  name = "web"  
                           value = "fail"  /> 0-39 </label>
            <label> <input type = "radio"  name = "web"  
                           value = "59" /> 40-59 </label>
            <label> <input type = "radio"  name = "web"  
                           value = "75" /> 60-75 </label>
            <label> <input type = "radio"  name = "web"  
                           value = "89" /> 76-89 </label>
            <label> <input type = "radio"  name = "web"  
                           value = "100" /> 90-100 </label>
           </br></br>
         Programming: <label> <input type = "radio"  name = "pr"  
                           value = "fail"  /> 0-39 </label>
            <label> <input type = "radio"  name = "pr"  
                           value = "59" /> 40-59 </label>
            <label> <input type = "radio"  name = "pr"  
                           value = "75" /> 60-75 </label>
            <label> <input type = "radio"  name = "pr"  
                           value = "89" /> 76-89 </label>
            <label> <input type = "radio"  name = "pr"  
                           value = "100" /> 90-100 </label>
          </br></br>
          Interactive case study: <label> <input type = "radio"  name = "ics"  
                           value = "fail" /> 0-39 </label>
            <label> <input type = "radio"  name = "ics"  
                           value = "59" /> 40-59 </label>
            <label> <input type = "radio"  name = "ics"  
                           value = "75" /> 60-75 </label>
            <label> <input type = "radio"  name = "ics"  
                           value = "89" /> 76-89 </label>
            <label> <input type = "radio"  name = "ics"  
                           value = "100" /> 90-100 </label>		</br>
            <input type = "button"  name = "submit"  
                           onclick="grade(total)" value="submit" name="submit" type="submit" />
    these button should calculate total /average and display it on readonly box

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center



Recent Articles