[RESOLVED] Unable to pass value to function

[johnrock]

I was writing a reusable function for checking and unchecking some checkboxes according to button cllicks. But I am unable to pass the "id" param through the function call.

Please help.

function checkorUncheck(id)
{
if(document.getElementById("id").checked == false)
	{
	document.getElementById("id").checked = true;
	}
	else
	{
	document.getElementById("id").checked = false;
	}

}

Function is called here.

 lHtml += "<li><input id='btn17' type='button'value='Select' onmouseup='return checkorUncheck(ABC)' ><input type='checkbox' DISABLED name='ABC' id='ABC' value='YES' class='checkclass'  />" + getI18nLabel("LABEL_COUGH") + "</li>";

checkorUncheck(ABC), checkorUncheck('ABC'),checkorUncheck(''ABC'') everything returns error. Can any one help me.

[manjuhugar24]

onmouseup='return checkorUncheck(ABC);'

i think semicolon is missing..i am not sure

[Gray1989]

getElementById(id)

and

onmouseup="checkorUncheck('ABC')"

[johnrock]

No , It is not working, as i cant give a double quote inside that.

onmouseup="checkorUncheck('ABC')" is error.

and if i give onmouseup='checkorUncheck('ABC')' it returns syntax error.

[Troy III]

 lHtml += "<li>"+
"<input id=btn17 type=button value=Select onclick='checkorUncheck(\'ABC\')'>"+
"<input type=checkbox id=ABC value=YES class=checkclass disabled>" + 
getI18nLabel("LABEL_COUGH") + 
"</li>";

[Troy III]

if( !document.getElementById(id).checked )
	{
	document.getElementById(id).checked = true;
	}
	else
	{
	document.getElementById(id).checked = false;
	}

[007Julien]

With a not disabled check box it could be work better !

[johnrock]

Error: syntax error
Source File: file:///.../index.html
Line: 1, Column: 15
Source Code:
checkorUncheck(

used the same

onclick='checkorUncheck(\'ABC\')'

function checkorUncheck(id)
{
if( !document.getElementById(id).checked )
	{
	document.getElementById(id).checked = true;
	}
	else
	{
	document.getElementById(id).checked = false;
	}

}

[007Julien]

<input type='checkbox' DISABLED name='ABC' id='ABC' value='YES' class='checkclass'  />

[johnrock]

No, i 've removed that. Still not working. Error console says some syntax error.
I just tried with a new fresh code too.

[Gray1989]

Sorry, missed the fact it is already being displayed in a variable. Other guy missed the fact that "\" doesn't escape HTML quotes. Try this:

<input id=btn17 type=button value=Select onclick='checkorUncheck(\"ABC\")'>

[johnrock]

Yeah.. It works

Thank You Gray1989