if else help!

[thewebiphyer]

the problem I have with the following script was that no matter what response the result still came out as "Nope!"... any ideas?

function ques1() {
var x=document.forms['ques1'].elements['response1'];
if (x==2) {
document.forms['ques1'].elements['result1'].value="Correct!";
}
else {
document.forms['ques1'].elements['result1'].value="Nope!";
}
}

[thewebiphyer]

i also tried

function ques1() {
var x=document.forms['ques1'].elements['response1'];
if (x="2") {
document.forms['ques1'].elements['result1'].value="Correct!";
}
else if (x!="2"){
document.forms['ques1'].elements['result1'].value="Nope!";
}
}

and instead it says "correct!" no matter what i put in

[xelawho]

kinda hard to say without knowing what

document.forms['ques1'].elements['response1']

is.

although

if (x="2")

will never work, but

if (x=="2")

might

[thewebiphyer]

i tried that and it still puts "Nope!" in the result box no matter what input is in the response field... but here is the whole thing..

<script type="text/javascript">
function ques1() {
var x=document.forms['ques1'].elements['response'];
if (x=="2") {
document.forms['ques1'].elements['result'].value="Correct!";
}
else if (x!="2"){
document.forms['ques1'].elements['result'].value="Nope!";
}
}
</script>
<form action="Javascript:ques1();" name="ques1">
<font size="5"><b><i>HOW MANY
<img src="http://melodicpulse.webs.com/pics/exercises/qnote.jpg" width="50"/>==
<img src="http://melodicpulse.webs.com/pics/exercises/hnote.jpg" width="50"/>?</i></b></font>
<input type="text" name="response" value="type answer here" />
<input type="text" name="result" value="result appears here" />
<input type="submit" name="submit" value="Submit" />
<input type="reset" name="reset" value="Reset Form" />
</form>

still doesn't work right

[xelawho]

var x=document.forms['ques1'].elements['response'].value;
if (x=="2") {
//etc...

[Kor]

Your problem is that you try to use a submit button, and the submit action to do something in JavaScript, which is an error. The submit process changes the session, and any changing of the session will make all the javascript calculation lost.

You may block the submit action by returning false:

function ques1() {
// whichever code
return false
}
...
...
<form action="" name="ques1" onsubmit="return ques1()">

Or you may simply use a type="button" input, not a submit one:

<form action="" name="ques1">
...
<input type="button"  value="Submit" />
</form>

[Troy III]

var x=document.forms['ques1'].elements['response'].value;
if (x=="2") {
//etc...

Yap, that's how it's done,
-can't compare a "DOM Element" to a "Number", or a "String" instead of its "value" and hope for the best.

[Kor]

Yap, that's how it's done,
-can't compare a "DOM Element" to a "Number", or a "String" instead of its "value" and hope for the best.

Agree. But in his particular case that is not enough (see my comment above)

[xelawho]

Agree. But in his particular case that is not enough (see my comment above)

actually, weird as it is, in this case it is enough (works in FF, Chrome & IE at least)... look at the form action... it seems the antiquated "javascript:" blocks the submission action

but I would agree - there's no point in a submit button that is not actually submitting anything.

on a side note, the function could easily be simplified using the ternary...

function ques1() {
var x=document.forms['ques1'].elements['response'].value;
document.forms['ques1'].elements['result'].value=x=="2"?"Correct!":"Nope!";
}