cant seem to read file

[vinny619]

I am having a problem reading a file, I have permission to do so as I can create and write to the file

static public String getContents(File aFile) {
        StringBuilder contents = new StringBuilder();
        try {
            BufferedReader input =  new BufferedReader(new FileReader(aFile));
            try {
                String line;
                while (( line = input.readLine()) != null){
                contents.append(line);
                }
            }
            finally {
                input.close();
            }
        } catch (IOException ex){
        }
        return contents.toString();
    }
  
    static public void setContents(File aFile, String aContents) throws FileNotFoundException, IOException {
        if (aFile == null) {
        throw new IllegalArgumentException("File should not be null.");
        }
        if (!aFile.exists()) {
        throw new FileNotFoundException ("File does not exist: " + aFile);
        }
        if (!aFile.isFile()) {
        throw new IllegalArgumentException("Should not be a directory: " + aFile);
        }
        if (!aFile.canWrite()) {
        throw new IllegalArgumentException("File cannot be written: " + aFile);
        }
        Writer output = new BufferedWriter(new FileWriter(aFile));
        try {
        output.write( aContents );
        }
        finally {
        output.close();
        }
    }

    public static void main(String[] args) throws IOException {
        String uuid = "";
        String pcname = "";
        String pcusername = "";
        UUID id = new UUID();
        
        java.net.InetAddress localMachine = java.net.InetAddress.getLocalHost();

        boolean mkdir = (new File(System.getenv("APPDATA") + "\\.okapinetwork").mkdir());
        
        if( mkdir ) {
            String fileName = System.getenv("APPDATA") + "\\.okapinetwork\\system.txt";

            File f = new File(fileName);
            if(!f.exists()){
                f.createNewFile();
                setContents(f, "UUID: " + id.toString() + ", PC_NAME: " + localMachine.getHostName() + ", LOGGED_IN_USER: " + System.getProperty("user.name") + "");
                uuid = id.toString();
                pcname = localMachine.getHostName();
                pcusername = USER[1];
            }else{
                String contents = getContents(f);
                String[] parts = contents.split(", ");
                String[] UID = parts[0].split(": ");
                String[] PC = parts[1].split(": ");
                String[] USER = parts[2].split(": ");
                uuid = UID[1];
                pcname = PC[1];
                pcusername = USER[1];
            }
        }

[vinny619]

Well thanks for the help, I think from now on I will go find a better community of people who will happily help with simple problems like this

[criterion9]

Are you getting any error messages? Don't want to take the time to look for errors in your code when a message would narrow that effort down to probable issues.

[vinny619]

I am using NETBEANS and this is all that is in the output when I run the application

run:
log4j:WARN No appenders could be found for logger (com.jniwrapper.DefaultLibraryLoader).
log4j:WARN Please initialize the log4j system properly.

[criterion9]

You might want to notify yourself in the event of an IO error:

} catch (IOException ex){
//might want to log or alert in some way here
}

[vinny619]

thanks for your help, I actually changed the code a bit, then added toString() to the loaded parts, and its working now
this is the final code

        UUID id = new UUID();

        String uuid = id.toString();
        String pcname = localMachine.getHostName();
        String pcusername = System.getProperty("user.name");
        
        boolean mkdir = (new File(System.getenv("APPDATA") + "\\.okapinetwork").mkdir());
        
        if( mkdir ) {
            String fileName = System.getenv("APPDATA") + "\\.okapinetwork\\uuid.txt";

            File f = new File(fileName);
            if(!f.exists()){
                f.createNewFile();
                setContents(f, "UUID: " + uuid + ", PCNAME: " + pcname + ", PCUSERNAME: " + pcusername);
            }else{
                String contents = getContents(f);
                String[] parts = contents.split(", ");
                String[] UID = parts[0].split(": ");
                String[] PC = parts[1].split(": ");
                String[] NAME = parts[2].split(": ");
                uuid = UID[1].toString();
                pcname = PC[1].toString();
                pcusername = NAME[1].toString();
            }
        }