www.webdeveloper.com
Results 1 to 7 of 7

Thread: rewriting a func. using a loop, not working

  1. #1
    Join Date
    Mar 2010
    Posts
    281

    rewriting a func. using a loop, not working

    i'm trying to re-write the following function using a loop but it's not working and i don't know why.

    PHP Code:
    $(function () {
            $(
    '#acchdr1').click(function(){
            
    runAccordion(1);
            });
            $(
    '#acchdr2').click(function(){
            
    runAccordion(2);
            });
            $(
    '#acchdr3').click(function(){
            
    runAccordion(3);
            });  
    //etc., etc., 
    so instead, i tried this,.....
    PHP Code:
    $(function () {
        
    hdrNum 11;
        for(
    i=0;i<hdrNun;i++) {
            $(
    '#acchdr'+i).click(function(){
            
    runAccordion(i);
            });
        }
    }) 
    the result is that the only the last header opens (#11). Here's my online example:
    http://www.tomcarden.net/dev/faux.html

    Thanks for any help with this!!

  2. #2
    Join Date
    Nov 2010
    Posts
    1,276
    it's a closure problem. I'm not sure what the exact solution looks like in jQuery, but translated from vanilla js it looks something like this:
    Code:
    for(i=0;i<11;i++) {
    		$('#acchdr'+i).click(function(i){
    		return function(){
    				runAccordion(i);
    				}
    			}); (i)
    		}

  3. #3
    Join Date
    Nov 2010
    Posts
    1,276
    or maybe like this?
    Code:
    for(i=0;i<11;i++) {
    		$('#acchdr'+i).click(function(i){
    		return function(){
    				runAccordion(i);
    				}
    			} (i)
    		);
    	}

  4. #4
    Join Date
    Mar 2010
    Posts
    281
    awesome!, thank you xelawho.

    the second one worked (first did not).

    that syntax looks strange to me. i don't get that last (i), ...after the bracket?

    i ran it without just to see and it failed.

    thanks again

  5. #5
    Join Date
    Nov 2010
    Posts
    1,276
    it does look weird. I'd explain it, but I'd only be paraphrasing what I read here, which is a pretty good explanation. This guy compares some other techniques for solving the same problem, but seems to prefer the one I posted, too

  6. #6
    Join Date
    Aug 2007
    Posts
    3,767
    I strongly suggest you write that as:
    Code:
    for(i=0;i<11;i++) {
      $('#acchdr'+i).click((function(i){
        return function(){
          runAccordion(i);
        };
      })(i));
    }
    For the following reasons.
    Those extra parentheses make is so much easier to read!

    And personally and totally equivalently, I prefer to write it as:
    Code:
    for (var i = 0; i < 11; i++) {
      (function (i) {
        // do stuff exactly as normal
      )(i);
    }
    Last edited by Declan1991; 04-27-2012 at 05:47 AM.

  7. #7
    Join Date
    Mar 2010
    Posts
    281
    thank you Declan

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.23975 seconds
  • Memory Usage 2,908KB
  • Queries Executed 15 (?)
More Information
Template Usage (34):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (4)bbcode_code
  • (2)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (7)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (7)postbit
  • (7)postbit_onlinestatus
  • (7)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (72):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates