www.webdeveloper.com
Results 1 to 3 of 3

Thread: Javascript beginner

Hybrid View

  1. #1
    Join Date
    Apr 2012
    Posts
    3

    Javascript beginner

    Hello, I've got a fairly simple question (for you, not for me).
    I'm new to this javascript thingy, and tbh, it just doen't make any sense for me.

    I'm stuck at the following code:
    Code:
    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
    <html xmlns="http://www.w3.org/1999/xhtml">
    
    <head><title> Validation </title>
    <script>
    var lname, fname, age, weight, middle;
    
    function Check()
    {
    	if (lname!=1 || fname!=1 || age!=1 || weight!=1 || middle!=1)
    	{
    		alert("Please fill out the form correctly.");
    		return false;
    	}
    }
    
    function Checklname()
    {
    	var value=document.forms["form"]["flastname"].value;
    	
    	if (value='')
    	{
    		alert("Enter your last name.");
    		lname=0;
    		return false;
    	}
    }
    	
    function Checkfname()
    {
    	var value=document.forms["form"]["ffirstname"].value;
    	
    	if (value='')
    	{
    		alert("Enter your first name.");
    		fname=0;
    		return false;
    	}
    }
    
    function Checkmiddle()
    {
    	var value=document.forms["form"]["fmiddleinit"].value;
    	
    	if (value='')
    	{
    		alert("Enter your middle initial.");
    		middle=0;
    		return false;
    	}
    }
    
    function Checkage()
    {
    	var value=document.forms["form"]["fage"].value;
    	
    	if (value='')
    	{
    		alert("Enter your age.");
    		weight=0;
    		return false;
    	}
    	
    	if (int)value<17)
    	{
    		alert("You're too young.");
    		age=0;
    		return false;
    	}
    }
    
    function Checkweight()
    {
    	var value=document.forms["form"]["fweight"].value;
    		
    	if (value='')
    	{
    		alert("Enter your weight.");
    		weight=0;
    		return false;
    	}
    	
    	if ((int)value < 18 || (int)value > 300)
    	{
    		alert("You've entered a strange value for weight.");
    		weight=0;
    		return false;
    	}
    }
    </script>
    		
    
    
    </head>
    
    <body>
    <form name="form" action="" onsubmit="return Check()">
    Last name: <input type="text" name="flastname" onblur="Checklname()"> <br />
    First name: <input type="text" name="ffirstname" onblur="Checkfname()"> <br />
    Middle initial: <input type="text" name="fmiddleinit" onblur="Checkmiddle()"> <br />
    Age: <input type="text" name="fage" onblur="Checkage()"> <br />
    Weight: <input type="text" name="fweight" onblur="Checkweight()"> <br />
    <input type="submit" value="submit">
    </body>
    </body>
    I've tried to debug it by putting alerts in the functions when they should be called, but the alerts were never shown, therefore I think something's wrong with my function calls. But I've got not a single clue of what that might be...

    Could anybody help me?

  2. #2
    Join Date
    May 2006
    Location
    Somewhere behind your screen
    Posts
    1,648
    count the brackets

    Code:
    Inline script compilation
    Syntax error at line 60 while loading: expected ';', got ')'
    	if (int)value<17)
    	----------------^
    xxx: Guess Buddhist riddle: "What is the sound of one hand clapping?"
    yyy: facepalm

  3. #3
    Join Date
    Feb 2012
    Location
    Bokaro Steel City (Jharkhand), India!
    Posts
    194
    Lots of errors!
    HTML Code:
    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
    <html xmlns="http://www.w3.org/1999/xhtml">
    <head>
        <title>Validation</title>
        <script>
            "use strict";
            var lname, fname, age, weight, middle;
    
            function Check() {
                if (lname!=1 || fname!=1 || age!=1 || weight!=1 || middle!=1) {
                    alert("Please fill out the form correctly.");
                    return false;
                }
            }
    
            function Checklname() {
                var value=document.forms["form"].elements["flastname"].value;
                if (value=='') {
                    alert("Enter your last name.");
                    lname=0;
                    return false;
                } else lname = 1;
            }
        
            function Checkfname() {
                var value=document.forms["form"].elements["ffirstname"].value;
                if (value=='') {
                    alert("Enter your first name.");
                    fname=0;
                    return false;
                } else fname = 1;
            }
    
            function Checkmiddle() {
                var value=document.forms["form"].elements["fmiddleinit"].value;
                if (value=='') {
                    alert("Enter your middle initial.");
                    middle=0;
                    return false;
                } else middle = 1;
            }
    
            function Checkage() {
                var value=document.forms["form"].elements["fage"].value;
                if (value=='') {
                    alert("Enter your age.");
                    age=0;
                    return false;
                } else if (parseInt(value)<17) {
                    alert("You're too young.");    
                    age=0;
                    return false;
                } else age = 1;
            }
    
            function Checkweight() {
                var value=document.forms["form"].elements["fweight"].value;
                if (value=='') {
                    alert("Enter your weight.");
                    weight=0;
                    return false;
                } else if (parseInt(value) < 18 || parseInt(value) > 300) {
                    alert("You've entered a strange value for weight.");
                    weight=0;
                    return false;
                } else weight = 1;
            }
        </script>
    </head>
    
    <body>
        <form name="form" action="" onsubmit="return Check()">
            Last name: <input type="text" name="flastname" onblur="Checklname()"> <br />
            First name: <input type="text" name="ffirstname" onblur="Checkfname()"> <br />
            Middle initial: <input type="text" name="fmiddleinit" onblur="Checkmiddle()"> <br />
            Age: <input type="text" name="fage" onblur="Checkage()"> <br />
            Weight: <input type="text" name="fweight" onblur="Checkweight()"> <br />
            <input type="submit" value="submit">
        </form>
    </body>
    </html>
    Note: The code that I have given after correction is ERROR FREE but it is still BAD CODING. It can be improved and shortened a lot!
    "It will never rain roses: when we want to have more roses, we must plant more roses." - George Eliot

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center



Recent Articles