www.webdeveloper.com
Results 1 to 2 of 2

Thread: innerHTML create and remove elements

  1. #1
    Join Date
    May 2012
    Posts
    2

    innerHTML create and remove elements

    Hi! I made simple script, that creates and removes <div> element. I'm experiencing a problem, I can't remove the <div>. Although it may seem trivial, I don't know how to solve it. Moreover, chrome and firefox don't give me the error description.

    Code:
    function removeDOMforChart(id) {
    var tmpElementVar = document.getElementById(id);
    tmpElementVar.innerHTML = "";
    //tmpElementVar.parentNode.removeChild(tmpElementVar); 
    }
    
    function addDOMforChart() {
    var parentID = document.getElementById("furtherCharts");
    var childFreeID = returnFirstFreeNo();
    var fullID = 'chart'+childFreeID;
    var divID = 'd'+fullID;
    	parentID.innerHTML +='<div id="'+divID+'" style="width:800px;">';
    	parentID.innerHTML +='<canvas id="'+fullID+'" width=780 style="float:left;"></canvas>';
    	parentID.innerHTML +='<img src="goUp.png" style="float:right;" onclick="removeDOMforChart(\''+divID+'\');">';
    	parentID.innerHTML +='<img src="closeChart.png" style="float:right;">';
    	parentID.innerHTML +='</div>'
    }
    The HTML looks like this :

    Code:
    <div id="furtherCharts"></div>
    I attach next div's of name dchart0,dchart1, to a div of id = "furtherCharts" etc. Within every new div there is an img with onclick function passing argument of ID (dchart0,...) to a function removeDOMforChart(id) to remove itself.

    I try to remove the content of element (chart0,...) with tmpElementVar.innerHTML = "";, no joy but no error also, with
    tmpElementVar.parentNode.removeChild(tmpElementVar);
    I get nothing for the first click, after this, every next click triggers an error
    "Uncaught TypeError: Cannot set property 'innerHTML' of null";

    Looks like the div element gets removed, but on the screen nothing changes ? How is this even possible ? Please, help me with this.

  2. #2
    Join Date
    May 2012
    Posts
    2
    HTML Code:
    <script>
    var childFreeID=0;
    function removeDOMforChart(id) {
    
    var fullID = 'chart'+id;
    var divID = 'd'+fullID;
    var tmpElementVar = document.getElementById(divID);
    tmpElementVar.innerHTML = "aaaa";
    tmpElementVar.parentNode.removeChild(tmpElementVar);
    }
    //////////////////////////////////////////////////////
    function addDOMforChart() {
    
    var parentID = document.getElementById("furtherCharts");
    var fullID = 'chart'+childFreeID;
    var divID = 'd'+fullID;
    	parentID.innerHTML +='<div id="'+divID+'" style="">';
    	parentID.innerHTML +='</div>'
    	
    var parentID = document.getElementById(divID);
    	parentID.innerHTML +='<canvas id="'+fullID+'" width=780 height=200"></canvas>';
    	parentID.innerHTML +='element of id: '+fullID+'<br>';
    	parentID.innerHTML +='<a href="javascript:removeDOMforChart('+childFreeID+')" >remove</a>';
    	
    childFreeID ++;
    }
    </script>
    <a href="javascript:addDOMforChart()" >add</a>
    <div id="furtherCharts">
    </div>
    This works well, I add elements sequentially, like this :

    Code:
    var parentID = document.getElementById("furtherCharts");
    var fullID = 'chart'+childFreeID;
    var divID = 'd'+fullID;
    	parentID.innerHTML +='<div id="'+divID+'" style="">';
    	parentID.innerHTML +='</div>'
    and then I find by id created element, 'innerHTML' to it.

    Code:
    var parentID = document.getElementById(divID);
    	parentID.innerHTML +='<canvas id="'+fullID+'" width=780 height=200"></canvas>';
    	parentID.innerHTML +='element of id: '+fullID+'<br>';
    	parentID.innerHTML +='<a href="javascript:removeDOMforChart('+childFreeID+')" >remove</a>';
    Still don't know why it didn't work well when I added all of the elements (with id's) at once.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.49643 seconds
  • Memory Usage 2,838KB
  • Queries Executed 13 (?)
More Information
Template Usage (34):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (4)bbcode_code
  • (1)bbcode_html
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (2)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (2)postbit
  • (2)postbit_onlinestatus
  • (2)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (70):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates