www.webdeveloper.com
Results 1 to 8 of 8

Thread: Alternative to "SELECT *"

  1. #1
    Join Date
    Feb 2010
    Location
    Grantham, UK
    Posts
    103

    Alternative to "SELECT *"

    Am having lots of questions pop up, so am posting them as I think them..hope you don't mind

    Having read that ideally, you should not use SELECT * and specify which columns you want instead, e.g.

    Code:
    SELECT column1, column2 FROM...
    I have successfully changed all my coding accordingly with one exception:


    Code:
    while ($gptp <=5)
    	{
    	$gptplan="plan".$gptp;
    	$gptget = mysql_query("SELECT * FROM $gptplan
    		WHERE userid = '$gptuser' AND email = '$gptemail' LIMIT 1");
    		while($row = mysql_fetch_array($gptget))
    		{
    			$_SESSION[plantot][$gptp]=$row[plantot];
    			$_SESSION[plannew][$gptp]=$row[plannew];
    			$gptlvl=1;
    			while ($gptlvl <=9)
    			{
    				$gpttot="lvl".$gptlvl."tot";
    				$gptnew="lvl".$gptlvl."new";
    				$_SESSION[gpttot][$gptp][$gptlvl]=$row[$gpttot];
    				$_SESSION[gptnew][$gptp][$gptlvl]=$row[$gptnew];
    				$gptlvl++;
    			}
    		}
    	$gptp++;	
    	}

    Any ideas how I could work this one? Or am I allowed to occasionally have an exception to the rule?

  2. #2
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,284
    Looks to me like you use 4 columns -- just look at which array indexes are used with $row -- so you could make them the columns used in your SELECT. (Note that if those are the only 4 columns in that table, then it's not bad performance-wise to just use "*", though that makes your source code a bit less readable.)
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  3. #3
    Join Date
    Jan 2006
    Location
    MN
    Posts
    440
    Are these ;

    $_SESSION[gpttot][$gptp][$gptlvl]=$row[$gpttot];
    $_SESSION[gptnew][$gptp][$gptlvl]=$row[$gptnew];

    supposed to be

    $_SESSION[gpttot][$gptp][$gptlvl]=$row[gpttot];
    $_SESSION[gptnew][$gptp][$gptlvl]=$row[gptnew];

  4. #4
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,284
    Quote Originally Posted by Dasher View Post
    Are these ;

    $_SESSION[gpttot][$gptp][$gptlvl]=$row[$gpttot];
    $_SESSION[gptnew][$gptp][$gptlvl]=$row[$gptnew];

    supposed to be

    $_SESSION[gpttot][$gptp][$gptlvl]=$row[gpttot];
    $_SESSION[gptnew][$gptp][$gptlvl]=$row[gptnew];
    I didn't notice that before, but probably explains the OP's question: it looks like the table must have a bunch of columns with names like lvl1new, lvl1tot, lvl2new, lvl2tot, etc.... Now I'm sort of leaning toward a DB redesign to move those enumerated columns into one or more separate tables with a foreign key into the main table.
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  5. #5
    Join Date
    Feb 2010
    Location
    Grantham, UK
    Posts
    103
    Thankyou for your help.

    NogDog - you are correct. There are approx 18 columns being called in each table (5 of them) out of 20 columns. The other 2 being my verification (userid and email)

    It would be possible to list them all in the SELECT, but would make reading very difficult. If I am calling all but two of the columns, would that be acceptable use of the *?

    I have heard of foreign keys before, but as yet have had no introduction, so do not understand them yet.


    As an additional question, I am also going to have to set all the lvl1new, lvl2new etc... to 0 upon each login. Is there any way of doing this as within the original query, or do I have to run it as a separate UPDATE query? (which is what i am expecting)
    Last edited by max2474; 05-20-2012 at 07:03 AM. Reason: addition

  6. #6
    Join Date
    May 2012
    Posts
    5
    having lots of questions pop up, so am posting them as I think them..hope you don't mind

    Having read that ideally, you should not use SELECT * and specify which columns you want instead

    By
    best dividend stocks

  7. #7
    Join Date
    Feb 2010
    Location
    Grantham, UK
    Posts
    103
    interesting cna....? :/

  8. #8
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,284
    Quote Originally Posted by max2474 View Post
    interesting cna....? :/
    Would you like some ketchup with that spam?

    (I've reported the post in question, so hopefully before long late-comers to this thread will wonder what you were talking about.)
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.31275 seconds
  • Memory Usage 2,925KB
  • Queries Executed 15 (?)
More Information
Template Usage (34):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (2)bbcode_code
  • (2)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (8)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (8)postbit
  • (8)postbit_onlinestatus
  • (8)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (72):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates